| Message ID | 20181211095319.11393-2-linus.walleij@linaro.org |
|---|---|
| State | Accepted |
| Commit | f306d76082358fa9a3fb3e66674a5852bb48845f |
| Headers | show |
| Series | [1/2] regulator: wm8994: Rely on core to handle GPIO descriptor | expand |
On Tue, Dec 11, 2018 at 10:53:19AM +0100, Linus Walleij wrote: > After making sure that the regulator core always take over > handling of the GPIO descriptors, the gpiod_put() > on the errorpath of the Arizona LDO1 driver becomes > redundant. > > Reported-by: Charles Keepax <ckeepax@opensource.cirrus.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
diff --git a/drivers/regulator/arizona-ldo1.c b/drivers/regulator/arizona-ldo1.c index 9a72eae4926d..b9a93049e41e 100644 --- a/drivers/regulator/arizona-ldo1.c +++ b/drivers/regulator/arizona-ldo1.c @@ -283,9 +283,6 @@ static int arizona_ldo1_common_init(struct platform_device *pdev, of_node_put(config.of_node); if (IS_ERR(ldo1->regulator)) { - if (config.ena_gpiod) - gpiod_put(config.ena_gpiod); - ret = PTR_ERR(ldo1->regulator); dev_err(&pdev->dev, "Failed to register LDO1 supply: %d\n", ret);
After making sure that the regulator core always take over handling of the GPIO descriptors, the gpiod_put() on the errorpath of the Arizona LDO1 driver becomes redundant. Reported-by: Charles Keepax <ckeepax@opensource.cirrus.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/regulator/arizona-ldo1.c | 3 --- 1 file changed, 3 deletions(-) -- 2.19.2