diff mbox series

[1/4] mfd: exynos-lpass: Enable UART module support

Message ID 20181214113410.22848-2-m.szyprowski@samsung.com
State New
Headers show
Series [1/4] mfd: exynos-lpass: Enable UART module support | expand

Commit Message

Marek Szyprowski Dec. 14, 2018, 11:34 a.m. UTC
From: Beomho Seo <beomho.seo@samsung.com>


This patch enables support for UART module in Exynos Audio SubSystem.
There are boards (for example TM2), which use it for communication with
bluetooth chip.

Signed-off-by: Beomho Seo <beomho.seo@samsung.com>

[mszyprow: rephrased commit message, added UART reset]
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

---
 drivers/mfd/exynos-lpass.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.17.1

Comments

Lee Jones Dec. 21, 2018, 10:13 a.m. UTC | #1
On Fri, 14 Dec 2018, Marek Szyprowski wrote:

> From: Beomho Seo <beomho.seo@samsung.com>

> 

> This patch enables support for UART module in Exynos Audio SubSystem.

> There are boards (for example TM2), which use it for communication with

> bluetooth chip.


Does it though?  Or does it enable the interrupt and reset something?
These calls would probably benefit from some documentation by way of
comments.

> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>

> [mszyprow: rephrased commit message, added UART reset]

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

> ---

>  drivers/mfd/exynos-lpass.c | 4 +++-

>  1 file changed, 3 insertions(+), 1 deletion(-)

> 

> diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c

> index ca829f85672f..2713de989f05 100644

> --- a/drivers/mfd/exynos-lpass.c

> +++ b/drivers/mfd/exynos-lpass.c

> @@ -82,11 +82,13 @@ static void exynos_lpass_enable(struct exynos_lpass *lpass)

>  		     LPASS_INTR_SFR | LPASS_INTR_DMA | LPASS_INTR_I2S);

>  

>  	regmap_write(lpass->top, SFR_LPASS_INTR_CPU_MASK,

> -		     LPASS_INTR_SFR | LPASS_INTR_DMA | LPASS_INTR_I2S);

> +		     LPASS_INTR_SFR | LPASS_INTR_DMA | LPASS_INTR_I2S |

> +		     LPASS_INTR_UART);

>  

>  	exynos_lpass_core_sw_reset(lpass, LPASS_I2S_SW_RESET);

>  	exynos_lpass_core_sw_reset(lpass, LPASS_DMA_SW_RESET);

>  	exynos_lpass_core_sw_reset(lpass, LPASS_MEM_SW_RESET);

> +	exynos_lpass_core_sw_reset(lpass, LPASS_UART_SW_RESET);

>  }

>  

>  static void exynos_lpass_disable(struct exynos_lpass *lpass)


-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
diff mbox series

Patch

diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c
index ca829f85672f..2713de989f05 100644
--- a/drivers/mfd/exynos-lpass.c
+++ b/drivers/mfd/exynos-lpass.c
@@ -82,11 +82,13 @@  static void exynos_lpass_enable(struct exynos_lpass *lpass)
 		     LPASS_INTR_SFR | LPASS_INTR_DMA | LPASS_INTR_I2S);
 
 	regmap_write(lpass->top, SFR_LPASS_INTR_CPU_MASK,
-		     LPASS_INTR_SFR | LPASS_INTR_DMA | LPASS_INTR_I2S);
+		     LPASS_INTR_SFR | LPASS_INTR_DMA | LPASS_INTR_I2S |
+		     LPASS_INTR_UART);
 
 	exynos_lpass_core_sw_reset(lpass, LPASS_I2S_SW_RESET);
 	exynos_lpass_core_sw_reset(lpass, LPASS_DMA_SW_RESET);
 	exynos_lpass_core_sw_reset(lpass, LPASS_MEM_SW_RESET);
+	exynos_lpass_core_sw_reset(lpass, LPASS_UART_SW_RESET);
 }
 
 static void exynos_lpass_disable(struct exynos_lpass *lpass)