[edk2,edk2-platforms] Silicon/AMD: drop ArmBds remnant Pcd imports from StyxDtbLoaderLib

Message ID 20181218183832.31950-1-leif.lindholm@linaro.org
State New
Headers show
Series
  • [edk2,edk2-platforms] Silicon/AMD: drop ArmBds remnant Pcd imports from StyxDtbLoaderLib
Related show

Commit Message

Leif Lindholm Dec. 18, 2018, 6:38 p.m.
ArmPkg PcdArmLinuxFdtMaxOffset and PcdArmLinuxFdtAlignment are still
referenced in StyxDtbLoaderLib.inf, but not actually used anywhere -
so drop them.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

---
 Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf | 2 --
 1 file changed, 2 deletions(-)

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ard Biesheuvel Dec. 19, 2018, 10:08 a.m. | #1
On Tue, 18 Dec 2018 at 19:38, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>

> ArmPkg PcdArmLinuxFdtMaxOffset and PcdArmLinuxFdtAlignment are still

> referenced in StyxDtbLoaderLib.inf, but not actually used anywhere -

> so drop them.

>

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>


Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


> ---

>  Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf | 2 --

>  1 file changed, 2 deletions(-)

>

> diff --git a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf

> index 23c5e563bb..3fbc0548aa 100644

> --- a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf

> +++ b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf

> @@ -52,8 +52,6 @@ [Pcd]

>  [FixedPcd]

>    gAmdModulePkgTokenSpaceGuid.PcdXgbeEnable

>    gArmPlatformTokenSpaceGuid.PcdCoreCount

> -  gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset

> -  gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment

>    gAmdStyxTokenSpaceGuid.PcdEnableKcs

>    gAmdStyxTokenSpaceGuid.PcdSata1PortCount

>

> --

> 2.11.0

>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Leif Lindholm Dec. 19, 2018, 11:53 a.m. | #2
On Wed, Dec 19, 2018 at 11:08:32AM +0100, Ard Biesheuvel wrote:
> On Tue, 18 Dec 2018 at 19:38, Leif Lindholm <leif.lindholm@linaro.org> wrote:

> >

> > ArmPkg PcdArmLinuxFdtMaxOffset and PcdArmLinuxFdtAlignment are still

> > referenced in StyxDtbLoaderLib.inf, but not actually used anywhere -

> > so drop them.

> >

> > Contributed-under: TianoCore Contribution Agreement 1.1

> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

> 

> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


Thanks!
Pushed as c718cc0378.

> > ---

> >  Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf | 2 --

> >  1 file changed, 2 deletions(-)

> >

> > diff --git a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf

> > index 23c5e563bb..3fbc0548aa 100644

> > --- a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf

> > +++ b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf

> > @@ -52,8 +52,6 @@ [Pcd]

> >  [FixedPcd]

> >    gAmdModulePkgTokenSpaceGuid.PcdXgbeEnable

> >    gArmPlatformTokenSpaceGuid.PcdCoreCount

> > -  gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset

> > -  gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment

> >    gAmdStyxTokenSpaceGuid.PcdEnableKcs

> >    gAmdStyxTokenSpaceGuid.PcdSata1PortCount

> >

> > --

> > 2.11.0

> >

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
index 23c5e563bb..3fbc0548aa 100644
--- a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
+++ b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
@@ -52,8 +52,6 @@  [Pcd]
 [FixedPcd]
   gAmdModulePkgTokenSpaceGuid.PcdXgbeEnable
   gArmPlatformTokenSpaceGuid.PcdCoreCount
-  gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset
-  gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment
   gAmdStyxTokenSpaceGuid.PcdEnableKcs
   gAmdStyxTokenSpaceGuid.PcdSata1PortCount