diff mbox series

[edk2] ArmPkg: drop ArmBds remnant Pcds from .dec

Message ID 20181218183846.31999-1-leif.lindholm@linaro.org
State Accepted
Commit 5f0b035f107d51a75de836345fd4b403d066a209
Headers show
Series [edk2] ArmPkg: drop ArmBds remnant Pcds from .dec | expand

Commit Message

Leif Lindholm Dec. 18, 2018, 6:38 p.m. UTC 
The following Pcds
- gArmTokenSpaceGuid.PcdArmLinuxSpinTable
- gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset
- gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset
- gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment
remained defined, without actual users.
So get rid of them.

One reference to be deleted separately from edk2-platforms.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

---
 ArmPkg/ArmPkg.dec | 20 --------------------
 1 file changed, 20 deletions(-)

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ard Biesheuvel Dec. 19, 2018, 10:08 a.m. UTC | #1 
On Tue, 18 Dec 2018 at 19:38, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>

> The following Pcds

> - gArmTokenSpaceGuid.PcdArmLinuxSpinTable

> - gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset

> - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset

> - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment

> remained defined, without actual users.

> So get rid of them.

>

> One reference to be deleted separately from edk2-platforms.

>

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>


Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


> ---

>  ArmPkg/ArmPkg.dec | 20 --------------------

>  1 file changed, 20 deletions(-)

>

> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec

> index d99eb6769f..0ec5e8efd6 100644

> --- a/ArmPkg/ArmPkg.dec

> +++ b/ArmPkg/ArmPkg.dec

> @@ -80,10 +80,6 @@ [PcdsFeatureFlag.common]

>    # it has been configured by the CPU DXE

>    gArmTokenSpaceGuid.PcdDebuggerExceptionSupport|FALSE|BOOLEAN|0x00000032

>

> -  # Define if the spin-table mechanism is used by the secondary cores when booting

> -  # Linux (instead of PSCI)

> -  gArmTokenSpaceGuid.PcdArmLinuxSpinTable|FALSE|BOOLEAN|0x00000033

> -

>    # Define if the GICv3 controller should use the GICv2 legacy

>    gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042

>

> @@ -173,16 +169,6 @@ [PcdsFixedAtBuild.ARM]

>    # By default we do not do a transition to non-secure mode

>    gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x0|UINT32|0x0000003E

>

> -  # The Linux ATAGs are expected to be under 0x4000 (16KB) from the beginning of the System Memory

> -  gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset|0x4000|UINT32|0x00000020

> -

> -  # If the fixed FDT address is not available, then it should be loaded below the kernel.

> -  # The recommendation from the Linux kernel is to have the FDT below 16KB.

> -  # (see the kernel doc: Documentation/arm/Booting)

> -  gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x4000|UINT32|0x00000023

> -  # The FDT blob must be loaded at a 64bit aligned address.

> -  gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x8|UINT32|0x00000026

> -

>    # Non Secure Access Control Register

>    # - BIT15 : NSASEDIS - Disable Non-secure Advanced SIMD functionality

>    # - BIT14 : NSD32DIS - Disable Non-secure use of D16-D31

> @@ -221,12 +207,6 @@ [PcdsFixedAtBuild.AARCH64]

>    # Other modes include using SP0 or switching to Aarch32, but these are

>    # not currently supported.

>    gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x3c9|UINT32|0x0000003E

> -  # If the fixed FDT address is not available, then it should be loaded above the kernel.

> -  # The recommendation from the AArch64 Linux kernel is to have the FDT below 512MB.

> -  # (see the kernel doc: Documentation/arm64/booting.txt)

> -  gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x20000000|UINT32|0x00000023

> -  # The FDT blob must be loaded at a 2MB aligned address.

> -  gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x00200000|UINT32|0x00000026

>

>

>  #

> --

> 2.11.0

>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Leif Lindholm Dec. 19, 2018, 11:53 a.m. UTC | #2 
On Wed, Dec 19, 2018 at 11:08:48AM +0100, Ard Biesheuvel wrote:
> On Tue, 18 Dec 2018 at 19:38, Leif Lindholm <leif.lindholm@linaro.org> wrote:

> >

> > The following Pcds

> > - gArmTokenSpaceGuid.PcdArmLinuxSpinTable

> > - gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset

> > - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset

> > - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment

> > remained defined, without actual users.

> > So get rid of them.

> >

> > One reference to be deleted separately from edk2-platforms.

> >

> > Contributed-under: TianoCore Contribution Agreement 1.1

> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

> 

> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


Thanks!
Pushed as 5f0b035f10.

> > ---

> >  ArmPkg/ArmPkg.dec | 20 --------------------

> >  1 file changed, 20 deletions(-)

> >

> > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec

> > index d99eb6769f..0ec5e8efd6 100644

> > --- a/ArmPkg/ArmPkg.dec

> > +++ b/ArmPkg/ArmPkg.dec

> > @@ -80,10 +80,6 @@ [PcdsFeatureFlag.common]

> >    # it has been configured by the CPU DXE

> >    gArmTokenSpaceGuid.PcdDebuggerExceptionSupport|FALSE|BOOLEAN|0x00000032

> >

> > -  # Define if the spin-table mechanism is used by the secondary cores when booting

> > -  # Linux (instead of PSCI)

> > -  gArmTokenSpaceGuid.PcdArmLinuxSpinTable|FALSE|BOOLEAN|0x00000033

> > -

> >    # Define if the GICv3 controller should use the GICv2 legacy

> >    gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042

> >

> > @@ -173,16 +169,6 @@ [PcdsFixedAtBuild.ARM]

> >    # By default we do not do a transition to non-secure mode

> >    gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x0|UINT32|0x0000003E

> >

> > -  # The Linux ATAGs are expected to be under 0x4000 (16KB) from the beginning of the System Memory

> > -  gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset|0x4000|UINT32|0x00000020

> > -

> > -  # If the fixed FDT address is not available, then it should be loaded below the kernel.

> > -  # The recommendation from the Linux kernel is to have the FDT below 16KB.

> > -  # (see the kernel doc: Documentation/arm/Booting)

> > -  gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x4000|UINT32|0x00000023

> > -  # The FDT blob must be loaded at a 64bit aligned address.

> > -  gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x8|UINT32|0x00000026

> > -

> >    # Non Secure Access Control Register

> >    # - BIT15 : NSASEDIS - Disable Non-secure Advanced SIMD functionality

> >    # - BIT14 : NSD32DIS - Disable Non-secure use of D16-D31

> > @@ -221,12 +207,6 @@ [PcdsFixedAtBuild.AARCH64]

> >    # Other modes include using SP0 or switching to Aarch32, but these are

> >    # not currently supported.

> >    gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x3c9|UINT32|0x0000003E

> > -  # If the fixed FDT address is not available, then it should be loaded above the kernel.

> > -  # The recommendation from the AArch64 Linux kernel is to have the FDT below 512MB.

> > -  # (see the kernel doc: Documentation/arm64/booting.txt)

> > -  gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x20000000|UINT32|0x00000023

> > -  # The FDT blob must be loaded at a 2MB aligned address.

> > -  gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x00200000|UINT32|0x00000026

> >

> >

> >  #

> > --

> > 2.11.0

> >

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox series

Patch

diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
index d99eb6769f..0ec5e8efd6 100644
--- a/ArmPkg/ArmPkg.dec
+++ b/ArmPkg/ArmPkg.dec
@@ -80,10 +80,6 @@  [PcdsFeatureFlag.common]
   # it has been configured by the CPU DXE
   gArmTokenSpaceGuid.PcdDebuggerExceptionSupport|FALSE|BOOLEAN|0x00000032
 
-  # Define if the spin-table mechanism is used by the secondary cores when booting
-  # Linux (instead of PSCI)
-  gArmTokenSpaceGuid.PcdArmLinuxSpinTable|FALSE|BOOLEAN|0x00000033
-
   # Define if the GICv3 controller should use the GICv2 legacy
   gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042
 
@@ -173,16 +169,6 @@  [PcdsFixedAtBuild.ARM]
   # By default we do not do a transition to non-secure mode
   gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x0|UINT32|0x0000003E
 
-  # The Linux ATAGs are expected to be under 0x4000 (16KB) from the beginning of the System Memory
-  gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset|0x4000|UINT32|0x00000020
-
-  # If the fixed FDT address is not available, then it should be loaded below the kernel.
-  # The recommendation from the Linux kernel is to have the FDT below 16KB.
-  # (see the kernel doc: Documentation/arm/Booting)
-  gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x4000|UINT32|0x00000023
-  # The FDT blob must be loaded at a 64bit aligned address.
-  gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x8|UINT32|0x00000026
-
   # Non Secure Access Control Register
   # - BIT15 : NSASEDIS - Disable Non-secure Advanced SIMD functionality
   # - BIT14 : NSD32DIS - Disable Non-secure use of D16-D31
@@ -221,12 +207,6 @@  [PcdsFixedAtBuild.AARCH64]
   # Other modes include using SP0 or switching to Aarch32, but these are
   # not currently supported.
   gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x3c9|UINT32|0x0000003E
-  # If the fixed FDT address is not available, then it should be loaded above the kernel.
-  # The recommendation from the AArch64 Linux kernel is to have the FDT below 512MB.
-  # (see the kernel doc: Documentation/arm64/booting.txt)
-  gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x20000000|UINT32|0x00000023
-  # The FDT blob must be loaded at a 2MB aligned address.
-  gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x00200000|UINT32|0x00000026
 
 
 #