| Message ID | 1363674681-4015-3-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
On 03/19/2013 07:31 AM, Sachin Kamat wrote: > Fixes the following warnings: > drivers/pinctrl/pinctrl-ab9540.c:382:28: warning: > symbol 'ab9540alternate_functions' was not declared. Should it be static? > drivers/pinctrl/pinctrl-ab9540.c:457:32: warning: > symbol 'ab9540_gpio_irq_cluster' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > Cc: Patrice Chotard <patrice.chotard@stericsson.com> > --- > drivers/pinctrl/pinctrl-ab9540.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-ab9540.c b/drivers/pinctrl/pinctrl-ab9540.c > index 7610bd0..27835ce 100644 > --- a/drivers/pinctrl/pinctrl-ab9540.c > +++ b/drivers/pinctrl/pinctrl-ab9540.c > @@ -379,7 +379,8 @@ static const struct abx500_function ab9540_functions[] = { > * alt_A | 1 | 0 | 0 > */ > > -struct alternate_functions ab9540alternate_functions[AB9540_GPIO_MAX_NUMBER + 1] = { > +static struct > +alternate_functions ab9540alternate_functions[AB9540_GPIO_MAX_NUMBER + 1] = { > /* GPIOSEL1 - bits 4-7 are reserved */ > ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */ > ALTERNATE_FUNCTIONS(1, 0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */ > @@ -454,7 +455,7 @@ struct alternate_functions ab9540alternate_functions[AB9540_GPIO_MAX_NUMBER + 1] > ALTERNATE_FUNCTIONS(54, 5, UNUSED, UNUSED, 0, 0, 0), /* GPIO54 = GPIO60, altA controlled by bit 5 */ > }; > > -struct abx500_gpio_irq_cluster ab9540_gpio_irq_cluster[] = { > +static struct abx500_gpio_irq_cluster ab9540_gpio_irq_cluster[] = { > GPIO_IRQ_CLUSTER(10, 13, AB8500_INT_GPIO10R), > GPIO_IRQ_CLUSTER(24, 25, AB8500_INT_GPIO24R), > GPIO_IRQ_CLUSTER(40, 41, AB8500_INT_GPIO40R), Fyi, don't use my stericsson email address as it has been disabled. Acked-by: Patrice Chotard <patrice.chotard@st.com>
On Tue, Mar 19, 2013 at 7:31 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > Fixes the following warnings: > drivers/pinctrl/pinctrl-ab9540.c:382:28: warning: > symbol 'ab9540alternate_functions' was not declared. Should it be static? > drivers/pinctrl/pinctrl-ab9540.c:457:32: warning: > symbol 'ab9540_gpio_irq_cluster' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > Cc: Patrice Chotard <patrice.chotard@stericsson.com> Patch applied with Patrice's ACK. Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-ab9540.c b/drivers/pinctrl/pinctrl-ab9540.c index 7610bd0..27835ce 100644 --- a/drivers/pinctrl/pinctrl-ab9540.c +++ b/drivers/pinctrl/pinctrl-ab9540.c @@ -379,7 +379,8 @@ static const struct abx500_function ab9540_functions[] = { * alt_A | 1 | 0 | 0 */ -struct alternate_functions ab9540alternate_functions[AB9540_GPIO_MAX_NUMBER + 1] = { +static struct +alternate_functions ab9540alternate_functions[AB9540_GPIO_MAX_NUMBER + 1] = { /* GPIOSEL1 - bits 4-7 are reserved */ ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */ ALTERNATE_FUNCTIONS(1, 0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */ @@ -454,7 +455,7 @@ struct alternate_functions ab9540alternate_functions[AB9540_GPIO_MAX_NUMBER + 1] ALTERNATE_FUNCTIONS(54, 5, UNUSED, UNUSED, 0, 0, 0), /* GPIO54 = GPIO60, altA controlled by bit 5 */ }; -struct abx500_gpio_irq_cluster ab9540_gpio_irq_cluster[] = { +static struct abx500_gpio_irq_cluster ab9540_gpio_irq_cluster[] = { GPIO_IRQ_CLUSTER(10, 13, AB8500_INT_GPIO10R), GPIO_IRQ_CLUSTER(24, 25, AB8500_INT_GPIO24R), GPIO_IRQ_CLUSTER(40, 41, AB8500_INT_GPIO40R),
Fixes the following warnings: drivers/pinctrl/pinctrl-ab9540.c:382:28: warning: symbol 'ab9540alternate_functions' was not declared. Should it be static? drivers/pinctrl/pinctrl-ab9540.c:457:32: warning: symbol 'ab9540_gpio_irq_cluster' was not declared. Should it be static? Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Cc: Patrice Chotard <patrice.chotard@stericsson.com> --- drivers/pinctrl/pinctrl-ab9540.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)