| Message ID | 1363674681-4015-4-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
On 03/19/2013 07:31 AM, Sachin Kamat wrote: > Silences the following warnings: > drivers/pinctrl/pinctrl-ab8540.c:302:28: warning: > symbol 'ab8540_alternate_functions' was not declared. Should it be static? > drivers/pinctrl/pinctrl-ab8540.c:379:32: warning: > symbol 'ab8540_gpio_irq_cluster' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > Cc: Patrice Chotard <patrice.chotard@stericsson.com> > --- > drivers/pinctrl/pinctrl-ab8540.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-ab8540.c b/drivers/pinctrl/pinctrl-ab8540.c > index 8ee1e8d..9867535 100644 > --- a/drivers/pinctrl/pinctrl-ab8540.c > +++ b/drivers/pinctrl/pinctrl-ab8540.c > @@ -299,7 +299,8 @@ static const struct abx500_function ab8540_functions[] = { > * > */ > > -struct alternate_functions ab8540_alternate_functions[AB8540_GPIO_MAX_NUMBER + 1] = { > +static struct > +alternate_functions ab8540_alternate_functions[AB8540_GPIO_MAX_NUMBER + 1] = { > /* GPIOSEL1 - bit 4-7 reserved */ > ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */ > ALTERNATE_FUNCTIONS(1, 0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */ > @@ -376,7 +377,7 @@ static struct pullud ab8540_pullud = { > * GPIO43 to GPIO44 > * GPIO51 to GPIO54 > */ > -struct abx500_gpio_irq_cluster ab8540_gpio_irq_cluster[] = { > +static struct abx500_gpio_irq_cluster ab8540_gpio_irq_cluster[] = { > GPIO_IRQ_CLUSTER(43, 43, AB8540_INT_GPIO43F), > GPIO_IRQ_CLUSTER(44, 44, AB8540_INT_GPIO44F), > GPIO_IRQ_CLUSTER(51, 54, AB9540_INT_GPIO51R), Acked-by: Patrice Chotard <patrice.chotard@st.com>
On Tue, Mar 19, 2013 at 7:31 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > Silences the following warnings: > drivers/pinctrl/pinctrl-ab8540.c:302:28: warning: > symbol 'ab8540_alternate_functions' was not declared. Should it be static? > drivers/pinctrl/pinctrl-ab8540.c:379:32: warning: > symbol 'ab8540_gpio_irq_cluster' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > Cc: Patrice Chotard <patrice.chotard@stericsson.com> Patch applied with Patrice's ACK. Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-ab8540.c b/drivers/pinctrl/pinctrl-ab8540.c index 8ee1e8d..9867535 100644 --- a/drivers/pinctrl/pinctrl-ab8540.c +++ b/drivers/pinctrl/pinctrl-ab8540.c @@ -299,7 +299,8 @@ static const struct abx500_function ab8540_functions[] = { * */ -struct alternate_functions ab8540_alternate_functions[AB8540_GPIO_MAX_NUMBER + 1] = { +static struct +alternate_functions ab8540_alternate_functions[AB8540_GPIO_MAX_NUMBER + 1] = { /* GPIOSEL1 - bit 4-7 reserved */ ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */ ALTERNATE_FUNCTIONS(1, 0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */ @@ -376,7 +377,7 @@ static struct pullud ab8540_pullud = { * GPIO43 to GPIO44 * GPIO51 to GPIO54 */ -struct abx500_gpio_irq_cluster ab8540_gpio_irq_cluster[] = { +static struct abx500_gpio_irq_cluster ab8540_gpio_irq_cluster[] = { GPIO_IRQ_CLUSTER(43, 43, AB8540_INT_GPIO43F), GPIO_IRQ_CLUSTER(44, 44, AB8540_INT_GPIO44F), GPIO_IRQ_CLUSTER(51, 54, AB9540_INT_GPIO51R),
Silences the following warnings: drivers/pinctrl/pinctrl-ab8540.c:302:28: warning: symbol 'ab8540_alternate_functions' was not declared. Should it be static? drivers/pinctrl/pinctrl-ab8540.c:379:32: warning: symbol 'ab8540_gpio_irq_cluster' was not declared. Should it be static? Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Cc: Patrice Chotard <patrice.chotard@stericsson.com> --- drivers/pinctrl/pinctrl-ab8540.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)