From patchwork Tue Dec 18 22:06:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaldo Carvalho de Melo X-Patchwork-Id: 154208 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4235678ljp; Tue, 18 Dec 2018 14:10:34 -0800 (PST) X-Google-Smtp-Source: AFSGD/UNkVrteDqG1dM/zbD8q5kSIe/ZHiLzfhODwvVtHsfdb7s3NpGbU0F7HwNAnFpd9AlGw5OV X-Received: by 2002:a63:4926:: with SMTP id w38mr16504680pga.353.1545171034776; Tue, 18 Dec 2018 14:10:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545171034; cv=none; d=google.com; s=arc-20160816; b=yzti+Y9WexLjF3XDJlHute8EvnDWeqU8E0kURurshQFqgpOzt1pPv1M/q13AtsiRJY fXmROnRu3I9K8HBaroRXSIHIEe0ocL5rkyVdUTlJ6tHSBRj7N86B0ELgJRZ0pEMbt4wo iF0a1VJOHNR3F6c/TeOUbY8VRfM59QCHFXXW7TpEhgPjTmxILu5diRDq1CkLCN7QjD3A E4vzYoZY3N6bZFaOFcn1ojcrSyyF6D51JxUucFoy16Ck+BiatvcIBuxTWnIcmRph8dqH bxOnOa7RSX6H0NR++ns1LaPJSpJi2ORxr2EhMKj611/PnNxFKNR51+yycoG9pO1NAhDS 7Ucg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=h1K5R8uoqGuXhoUpSQ7Pm+ywjWFbTGgZsBUPkK96eq4=; b=DmaKCiffehMAbe7Bpm476Gdp5oxHSOerBR+WZCPkyimq44lre3Ay7EV/F/F8ERpTYh H086nwZur3AQ6mPdgTVruUujK+ngfhc0mrrw+peSIjN5ymEOgQemUOktFfCcuDy6ZGDB 97G4qZOfOWqqKDnb2Scemrg8L+ZAuhvWL64YNDXPFHf9qcOcV6XfZRetZ+4wFdKxnd+a R+7Ni2UXvXwGa+5g4EpZk3a1DkrHSYb/LhiedoygjMX1UMh/VFIdrxUAWrtfFjt65rxs ypXTWKrZBdpWN3GxbeXPQ9FZkBKYZ7At0i0CWxa0j1Iht8/x/o25F996ZqChg5HjKPCh rqTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=L6sUO9NN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l38si14554031plb.48.2018.12.18.14.10.34; Tue, 18 Dec 2018 14:10:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=L6sUO9NN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728053AbeLRWKd (ORCPT + 31 others); Tue, 18 Dec 2018 17:10:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:39050 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726706AbeLRWKb (ORCPT ); Tue, 18 Dec 2018 17:10:31 -0500 Received: from quaco.ghostprotocols.net (unknown [189.40.101.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7FC81218A4; Tue, 18 Dec 2018 22:10:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545171030; bh=2XbbrSZ3VWRHzIl/rl3R6odns74eUNOIkDCSwgQAQIc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L6sUO9NNzapzceUPXET1PMApjDeULMFOzKUIn2Trz4t2WYNZ2N1rfuA/klwi52dZM kxdKzO5vLQ0UFcBYxx73p903S+vZHUTIK8HUNcEGziO4fmCGBOfoEtOt+TGxk/S1hr RUBI8S5NM9twPw12ki+2BImGdYvc9GWIOPmTbEFA= From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Leo Yan , Alexander Shishkin , Jiri Olsa , Mathieu Poirier , Mike Leach , Namhyung Kim , Robert Walker , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, Arnaldo Carvalho de Melo Subject: [PATCH 28/63] perf cs-etm: Remove unused 'trace_on' in cs_etm_decoder Date: Tue, 18 Dec 2018 19:06:58 -0300 Message-Id: <20181218220733.15839-29-acme@kernel.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181218220733.15839-1-acme@kernel.org> References: <20181218220733.15839-1-acme@kernel.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Leo Yan cs_etm_decoder::trace_on is being assigned when TRACE_ON or NO_SYNC element is coming, but it is never used hence it is redundant and can be removed. So let's remove 'trace_on' field from cs_etm_decoder struct. Suggested-by: Mathieu Poirier Signed-off-by: Leo Yan Reviewed-by: Mathieu Poirier Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Mathieu Poirier Cc: Mike Leach Cc: Namhyung Kim Cc: Robert Walker Cc: coresight@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/1544513908-16805-4-git-send-email-leo.yan@linaro.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 3 --- 1 file changed, 3 deletions(-) -- 2.19.2 diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c index 0b4c8629f578..97b39b1f5759 100644 --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c @@ -36,7 +36,6 @@ struct cs_etm_decoder { void *data; void (*packet_printer)(const char *msg); - bool trace_on; dcd_tree_handle_t dcd_tree; cs_etm_mem_cb_type mem_access; ocsd_datapath_resp_t prev_return; @@ -411,12 +410,10 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer( case OCSD_GEN_TRC_ELEM_UNKNOWN: break; case OCSD_GEN_TRC_ELEM_NO_SYNC: - decoder->trace_on = false; break; case OCSD_GEN_TRC_ELEM_TRACE_ON: resp = cs_etm_decoder__buffer_trace_on(decoder, trace_chan_id); - decoder->trace_on = true; break; case OCSD_GEN_TRC_ELEM_INSTR_RANGE: resp = cs_etm_decoder__buffer_range(decoder, elem,