From patchwork Tue Dec 18 22:07:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaldo Carvalho de Melo X-Patchwork-Id: 154211 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4235970ljp; Tue, 18 Dec 2018 14:10:54 -0800 (PST) X-Google-Smtp-Source: AFSGD/We2upI7TkGFO+m/5WBP1OA6M3BhDkIzHAeQydHD0N/DfiP4ZscKRLxcXhUx/4ni6JCfUc5 X-Received: by 2002:a17:902:4624:: with SMTP id o33mr17653632pld.289.1545171054416; Tue, 18 Dec 2018 14:10:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545171054; cv=none; d=google.com; s=arc-20160816; b=ZL6Q76271pLz37uJLw8iEGCSRQySUnRsiZcoXM2SELY+a9vOsz5ohtxXbATailTERN xHeCRfOmqYAAI2L4eieG5s8ob9/Mmc8NKjPan8HAXiLIAhr9GCjUMR6RsOGUSDqq7lkg Nark+degtF1bROoHL71gfxau3kzGC3SaWQacwkd1ypEEt4FQN1B82MGIDtsK70cmfP5X rbUYi1cikHqCobRiwBnQ7AlGMlMp///+Z+dwS+r0wMfpDU9CppdBKGcctQWtiYo6rFVW BLdGS3lPUn/jGR0LQLXAoOthR1UUfuVOc0kWlCkKPpiqC7EbJvw0Vpc0W5hM5VgYbhKG ip0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xARfhUZNG+hAHCDu1A0m7f0R3gpeTBOKSjAxbD28ifY=; b=hkxwOfJ8ojKyQ58LoBVnxr3R0wEdwIANq0bo7EcXJCDK4pzIWe6ZyqmhkuXYGzqI57 RyCONG84cpEkJHodKCYNLY816qtxCl4oNxa9bHwpDEVisyuWJ2y6MVwGE53NT0AKH/CA 2nUoXwuS/WH9q61HxxgQ1ZJw0VHoyUWrp6j6ZnV7RBpgGLT9sa5rR2t6S9m++JpWjvlv ke+Qz4lDVv0HXaNeU0Dz2cjzrpCyb0BX7qvCdXALRgYEgBZAL61a428PTKxTpOcAg1RX ZSle5RSmnpJeXQjPasdoh67eg1N7cmLsU+5Bg5ivba55dU0kR5/HBKIBEu8EvAyQSifC PYiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Pdwzuogh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r18si14359344pgo.9.2018.12.18.14.10.54; Tue, 18 Dec 2018 14:10:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Pdwzuogh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728076AbeLRWKx (ORCPT + 31 others); Tue, 18 Dec 2018 17:10:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:39528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726802AbeLRWKv (ORCPT ); Tue, 18 Dec 2018 17:10:51 -0500 Received: from quaco.ghostprotocols.net (unknown [189.40.101.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1EC28217D9; Tue, 18 Dec 2018 22:10:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545171051; bh=cV+EWGCRKnKm1DJ1KLIkyVctuTBV9Z0WKj287fkcmBs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PdwzuoghBI4wfKX/C0uq8Uekn/FGzX03KX9zup9NgNq1dHXmToQE3cqVs1xuQcNm9 zuBfYowSkxCc0Ptkpx8JzbDVz+ECwr+HVqOUVDQ8VXBp2RA1ygqFN4y++HrQ6b7VN+ trDBxxzs+b0FhXO4rwCj0Rx6as938zmKaax0WlmQ= From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Leo Yan , Alexander Shishkin , Jiri Olsa , Mike Leach , Namhyung Kim , Robert Walker , coresight ml , linux-arm-kernel@lists.infradead.org, Arnaldo Carvalho de Melo Subject: [PATCH 31/63] perf cs-etm: Treat NO_SYNC element as trace discontinuity Date: Tue, 18 Dec 2018 19:07:01 -0300 Message-Id: <20181218220733.15839-32-acme@kernel.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181218220733.15839-1-acme@kernel.org> References: <20181218220733.15839-1-acme@kernel.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Leo Yan The CoreSight tracer driver might insert barrier packets between different buffers, thus the decoder can spot the boundaries based on the barrier packet; it is possible for the decoder to hit a barrier packet and emit a NO_SYNC element, then the decoder will find a periodic synchronisation point inside that next trace block that starts the trace again but does not have the TRACE_ON element as indicator - usually because this trace block has wrapped the buffer so we have lost the original point when the trace was enabled. In the first case it causes the insertion of a OCSD_GEN_TRC_ELEM_NO_SYNC in the middle of the tracing stream, but as we were not handling the NO_SYNC element properly this ends up making users miss the discontinuity indications. Though OCSD_GEN_TRC_ELEM_NO_SYNC is different from CS_ETM_TRACE_ON when output from the decoder, both indicate that the trace data is discontinuous; this patch treats OCSD_GEN_TRC_ELEM_NO_SYNC as a trace discontinuity and generates a CS_ETM_DISCONTINUITY packet for it, so cs-etm can handle the discontinuity for this case, finally it saves the last trace data for the previous trace block and restart samples for the new block. Signed-off-by: Leo Yan Reviewed-by: Mathieu Poirier Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Mike Leach Cc: Namhyung Kim Cc: Robert Walker Cc: coresight ml Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/1544513908-16805-7-git-send-email-leo.yan@linaro.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 1 - 1 file changed, 1 deletion(-) -- 2.19.2 diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c index 1039f364f4cc..bee026e76a4c 100644 --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c @@ -410,7 +410,6 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer( case OCSD_GEN_TRC_ELEM_UNKNOWN: break; case OCSD_GEN_TRC_ELEM_NO_SYNC: - break; case OCSD_GEN_TRC_ELEM_TRACE_ON: resp = cs_etm_decoder__buffer_discontinuity(decoder, trace_chan_id);