From patchwork Wed Dec 19 12:41:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 154258 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4890404ljp; Wed, 19 Dec 2018 04:42:56 -0800 (PST) X-Google-Smtp-Source: AFSGD/U7tpY6xBzyqausHtRkB01uxtHZf9gNIfoFyZMi3jM+Fs6bWPZ1bFI5nsLvGLDduvxIr5vR X-Received: by 2002:a17:902:8d8e:: with SMTP id v14mr20015345plo.133.1545223376187; Wed, 19 Dec 2018 04:42:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545223376; cv=none; d=google.com; s=arc-20160816; b=t9vWxH3aOhU/ZQR089a1vTdAvbE9HgEq4RR1ocwoqnB+SMLVDbdi/z3GqjJMOwvVfN ycyx4FGEFPA4EkG6vDAIr18vaTkEztd0FMkwHqzhNewNWJDTITKmkpYnQ9D5DTDSbP2w hKiJMLdez6BCfWsSlfb1RJHw4i0x6/+ZL82ueK4yPWM67NuwT40Ak8UC7mXLTNWkteo7 /wzTxyVciXbdrXwqGrmnBLePwA6rxGwnt64Tti5ea4xfi3RSMlbUK75QiSiNQ5EFFhOS t3Gza15CcNp3zPWBj66h2TYUTmfvsUBuvXznj3f4N/dNWNAnTZ1wnQBhsf5cgiu2ASya WPbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=tUqtMhWdpAvQJvFjUSGA83BB/8fhxvBVfFQdnpC737Y=; b=cLqamnnPwux0oR2BBVsz3Z9WTZjAtKkstT4/qER5tJwQs4c8JVi2UhwJEceofwsZ0L 2E4k6YFXKHwMECAD3cSaWHFZoU/lJ5XDWZHrdWifOD2jtUCl8+CLswcxAxU1SLEZ2xgq tfe6z4Nthf6EZwxLGHzZPJlK/xzUohhffeHvchXl2pAxleCXDnBQjlON+PaFny2hfMyi V/XNpinNaJsK9699SaX63QVwE63z0swqgYxgUe6tX4AeKJ+b/imAD0bQlcWvU8DUCK/e gwt2uGWUvLvaTAxQVELw3VCySNEx994P3gjfWHfY2lyXZVtKFhZeXgvLn7N+AhB+YALh mvGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=PaBeUMaX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f13si17233486pln.368.2018.12.19.04.42.55; Wed, 19 Dec 2018 04:42:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=PaBeUMaX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729781AbeLSMmz (ORCPT + 31 others); Wed, 19 Dec 2018 07:42:55 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:36206 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729725AbeLSMmx (ORCPT ); Wed, 19 Dec 2018 07:42:53 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id wBJCgXcU126318; Wed, 19 Dec 2018 06:42:33 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1545223353; bh=tUqtMhWdpAvQJvFjUSGA83BB/8fhxvBVfFQdnpC737Y=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=PaBeUMaXd8/XPHx12/5eYnkTBusopQc1o98+U5Y/P9Q2LfqCS4uuWOKDNYdzb0k+3 rYzLKq6Ras0uVMORaFtQqEQbyOJM05v9N3Zcy7hUo9A7nIWcOth70H7RAojgGCU3wr h+mJ2q8cei7MY1c2LtPmsiCbaJaqzPeyb5G0KDR0= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id wBJCgXxt051563 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 19 Dec 2018 06:42:33 -0600 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Wed, 19 Dec 2018 06:42:33 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Wed, 19 Dec 2018 06:42:33 -0600 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id wBJCgNZl003940; Wed, 19 Dec 2018 06:42:30 -0600 From: Kishon Vijay Abraham I To: Murali Karicheri , Lorenzo Pieralisi , Gustavo Pimentel , Marc Zyngier CC: Bjorn Helgaas , Jingoo Han , , , , Subject: [PATCH 02/10] PCI: keystone: Use "dummy_irq_chip" instead of new irqchip for legacy interrupt handling Date: Wed, 19 Dec 2018 18:11:59 +0530 Message-ID: <20181219124207.13479-3-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181219124207.13479-1-kishon@ti.com> References: <20181219124207.13479-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of creating a new irqchip with empty callback functions, use dummy_irq_chip. Since there is nothing to do in the irqchip callback functions, use handle_simple_irq instead of handle_level_irq. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 24 ++--------------------- 1 file changed, 2 insertions(+), 22 deletions(-) -- 2.17.1 diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index 5286a480f76b..1ef443009da5 100644 --- a/drivers/pci/controller/dwc/pci-keystone.c +++ b/drivers/pci/controller/dwc/pci-keystone.c @@ -266,31 +266,12 @@ static irqreturn_t ks_pcie_handle_error_irq(struct keystone_pcie *ks_pcie) return IRQ_HANDLED; } -static void ks_pcie_ack_legacy_irq(struct irq_data *d) -{ -} - -static void ks_pcie_mask_legacy_irq(struct irq_data *d) -{ -} - -static void ks_pcie_unmask_legacy_irq(struct irq_data *d) -{ -} - -static struct irq_chip ks_pcie_legacy_irq_chip = { - .name = "Keystone-PCI-Legacy-IRQ", - .irq_ack = ks_pcie_ack_legacy_irq, - .irq_mask = ks_pcie_mask_legacy_irq, - .irq_unmask = ks_pcie_unmask_legacy_irq, -}; - static int ks_pcie_init_legacy_irq_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw_irq) { - irq_set_chip_and_handler(irq, &ks_pcie_legacy_irq_chip, - handle_level_irq); + irq_set_chip_and_handler(irq, &dummy_irq_chip, + handle_simple_irq); irq_set_chip_data(irq, d->host_data); return 0; @@ -298,7 +279,6 @@ static int ks_pcie_init_legacy_irq_map(struct irq_domain *d, static const struct irq_domain_ops ks_pcie_legacy_irq_domain_ops = { .map = ks_pcie_init_legacy_irq_map, - .xlate = irq_domain_xlate_onetwocell, }; /**