diff mbox series

[v2,1/2] dt/bindings: add bindings for optional optee rng-uuid property

Message ID 1545300998-10069-2-git-send-email-sumit.garg@linaro.org
State Superseded
Headers show
Series Add OP-TEE based hwrng driver | expand

Commit Message

Sumit Garg Dec. 20, 2018, 10:16 a.m. UTC
Add bindings for OP-TEE based optional hardware random number
generator identifier property. It could be used on ARM based devices
where entropy source is not accessible to normal world (linux in this
case).

Signed-off-by: Sumit Garg <sumit.garg@linaro.org>

---
 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.7.4

Comments

Daniel Thompson Dec. 20, 2018, 12:08 p.m. UTC | #1
On Thu, Dec 20, 2018 at 03:46:37PM +0530, Sumit Garg wrote:
> Add bindings for OP-TEE based optional hardware random number

> generator identifier property. It could be used on ARM based devices

> where entropy source is not accessible to normal world (linux in this

> case).

> 

> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>

> ---

>  Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt | 4 ++++

>  1 file changed, 4 insertions(+)

> 

> diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt

> index d38834c..e3a4c35 100644

> --- a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt

> +++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt

> @@ -20,6 +20,9 @@ the reference implementation maintained by Linaro.

>                     "hvc" : HVC #0, with the register assignments specified

>  		           in drivers/tee/optee/optee_smc.h

>  

> +- rng-uuid       : Optional OP-TEE based RNG service identifier in case

> +                   hardware entropy source is not accesible to normal world

> +                   (Linux).


This what I mean about the TEE bus being missing.

UUID -> universally unique identifier. In other words a kernel driver
should know the set up UUIDs it supports and this can then match to a
list of UUIDs present in the TEE (the list of UUIDs present in the TEE
probably needs to be in the device tree but what they mean does not...
by being unique they effectively self-describe).


>  

>  

>  Example:

> @@ -27,5 +30,6 @@ Example:

>  		optee {

>  			compatible = "linaro,optee-tz";

>  			method = "smc";

> +			rng-uuid = "ab7a617c-b8e7-4d8f-8301-d09b61036b64";

>  		};

>  	};

> -- 

> 2.7.4

>
Sumit Garg Dec. 21, 2018, 9:37 a.m. UTC | #2
On Thu, 20 Dec 2018 at 17:38, Daniel Thompson
<daniel.thompson@linaro.org> wrote:
>

> On Thu, Dec 20, 2018 at 03:46:37PM +0530, Sumit Garg wrote:

> > Add bindings for OP-TEE based optional hardware random number

> > generator identifier property. It could be used on ARM based devices

> > where entropy source is not accessible to normal world (linux in this

> > case).

> >

> > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>

> > ---

> >  Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt | 4 ++++

> >  1 file changed, 4 insertions(+)

> >

> > diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt

> > index d38834c..e3a4c35 100644

> > --- a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt

> > +++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt

> > @@ -20,6 +20,9 @@ the reference implementation maintained by Linaro.

> >                     "hvc" : HVC #0, with the register assignments specified

> >                          in drivers/tee/optee/optee_smc.h

> >

> > +- rng-uuid       : Optional OP-TEE based RNG service identifier in case

> > +                   hardware entropy source is not accesible to normal world

> > +                   (Linux).

>

> This what I mean about the TEE bus being missing.

>

> UUID -> universally unique identifier. In other words a kernel driver

> should know the set up UUIDs it supports and this can then match to a

> list of UUIDs present in the TEE (the list of UUIDs present in the TEE

> probably needs to be in the device tree but what they mean does not...

> by being unique they effectively self-describe).

>


Other way could be that the list of UUIDs present in TEE be queried
from TEE implementation (OP-TEE) during corresponding init. I think it
could be created as another fast-call to OP-TEE.

-Sumit

>

> >

> >

> >  Example:

> > @@ -27,5 +30,6 @@ Example:

> >               optee {

> >                       compatible = "linaro,optee-tz";

> >                       method = "smc";

> > +                     rng-uuid = "ab7a617c-b8e7-4d8f-8301-d09b61036b64";

> >               };

> >       };

> > --

> > 2.7.4

> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt
index d38834c..e3a4c35 100644
--- a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt
+++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt
@@ -20,6 +20,9 @@  the reference implementation maintained by Linaro.
                    "hvc" : HVC #0, with the register assignments specified
 		           in drivers/tee/optee/optee_smc.h
 
+- rng-uuid       : Optional OP-TEE based RNG service identifier in case
+                   hardware entropy source is not accesible to normal world
+                   (Linux).
 
 
 Example:
@@ -27,5 +30,6 @@  Example:
 		optee {
 			compatible = "linaro,optee-tz";
 			method = "smc";
+			rng-uuid = "ab7a617c-b8e7-4d8f-8301-d09b61036b64";
 		};
 	};