[edk2,edk2-platforms] Platform/Various: drop DefaultExceptionHandlerLibBase reference

Message ID 20181220173153.11576-1-ard.biesheuvel@linaro.org
State New
Headers show
Series
  • [edk2,edk2-platforms] Platform/Various: drop DefaultExceptionHandlerLibBase reference
Related show

Commit Message

Ard Biesheuvel Dec. 20, 2018, 5:31 p.m.
Now that DebugAgentSymbolsBaseLib from ArmPkg no longer requires
a DefaultExceptionHandlerLib resolution, drop the overrides from
the [LibraryClasses.SEC] sections of various platforms.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              | 1 -
 Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                | 1 -
 Platform/LeMaker/CelloBoard/CelloBoard.dsc                  | 1 -
 Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 -
 Silicon/Hisilicon/Hisilicon.dsc.inc                         | 2 --
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc               | 1 -
 6 files changed, 7 deletions(-)

-- 
2.19.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Jan. 16, 2019, 7:32 p.m. | #1
On Thu, Dec 20, 2018 at 06:31:53PM +0100, Ard Biesheuvel wrote:
> Now that DebugAgentSymbolsBaseLib from ArmPkg no longer requires

> a DefaultExceptionHandlerLib resolution, drop the overrides from

> the [LibraryClasses.SEC] sections of various platforms.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


Whoops, sorry, I missed this one somehow.
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


> ---

>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              | 1 -

>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                | 1 -

>  Platform/LeMaker/CelloBoard/CelloBoard.dsc                  | 1 -

>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 -

>  Silicon/Hisilicon/Hisilicon.dsc.inc                         | 2 --

>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc               | 1 -

>  6 files changed, 7 deletions(-)

> 

> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc

> index 49671eefbdea..93d351de5a27 100644

> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc

> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc

> @@ -173,7 +173,6 @@ [LibraryClasses.common.SEC]

>    ArmPlatformLib|Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf

>  

>    DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf

> -  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf

>  

>    ArmGicArchLib|ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf

>  

> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc

> index 713c5637b074..e7a77c0ad957 100644

> --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc

> +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc

> @@ -148,7 +148,6 @@ [LibraryClasses.common]

>  

>  [LibraryClasses.common.SEC]

>    DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf

> -  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf

>  

>  !ifdef $(EDK2_SKIP_PEICORE)

>    PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf

> diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc

> index a70f91bb02d5..dad9cae97ed4 100644

> --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc

> +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc

> @@ -156,7 +156,6 @@ [LibraryClasses.common.SEC]

>    ArmPlatformLib|Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf

>  

>    DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf

> -  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf

>  

>    ArmGicArchLib|ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf

>  

> diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc

> index 722c4adb7a72..7e9728d0430e 100644

> --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc

> +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc

> @@ -155,7 +155,6 @@ [LibraryClasses.common.SEC]

>    ArmPlatformLib|Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf

>  

>    DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf

> -  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf

>  

>    ArmGicArchLib|ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf

>  

> diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc

> index 63d28a57406b..1282a97801b6 100644

> --- a/Silicon/Hisilicon/Hisilicon.dsc.inc

> +++ b/Silicon/Hisilicon/Hisilicon.dsc.inc

> @@ -127,8 +127,6 @@ [LibraryClasses.common]

>    NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf

>  

>  [LibraryClasses.common.SEC]

> -  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf

> -

>    ArmGicArchLib|ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf

>    PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf

>    BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf

> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc

> index b3fd1846c0bf..92ff1daf8391 100644

> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc

> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc

> @@ -154,7 +154,6 @@ [LibraryClasses.common]

>  

>  [LibraryClasses.common.SEC]

>    DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf

> -  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf

>  

>    PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf

>    ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf

> -- 

> 2.19.2

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Jan. 16, 2019, 8:27 p.m. | #2
On Wed, 16 Jan 2019 at 20:33, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>

> On Thu, Dec 20, 2018 at 06:31:53PM +0100, Ard Biesheuvel wrote:

> > Now that DebugAgentSymbolsBaseLib from ArmPkg no longer requires

> > a DefaultExceptionHandlerLib resolution, drop the overrides from

> > the [LibraryClasses.SEC] sections of various platforms.

> >

> > Contributed-under: TianoCore Contribution Agreement 1.1

> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>

> Whoops, sorry, I missed this one somehow.

> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>


Thanks

Pushed as 307f7f5bfc4f..ca70cbbcc000

> > ---

> >  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              | 1 -

> >  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                | 1 -

> >  Platform/LeMaker/CelloBoard/CelloBoard.dsc                  | 1 -

> >  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 -

> >  Silicon/Hisilicon/Hisilicon.dsc.inc                         | 2 --

> >  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc               | 1 -

> >  6 files changed, 7 deletions(-)

> >

> > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc

> > index 49671eefbdea..93d351de5a27 100644

> > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc

> > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc

> > @@ -173,7 +173,6 @@ [LibraryClasses.common.SEC]

> >    ArmPlatformLib|Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf

> >

> >    DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf

> > -  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf

> >

> >    ArmGicArchLib|ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf

> >

> > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc

> > index 713c5637b074..e7a77c0ad957 100644

> > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc

> > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc

> > @@ -148,7 +148,6 @@ [LibraryClasses.common]

> >

> >  [LibraryClasses.common.SEC]

> >    DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf

> > -  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf

> >

> >  !ifdef $(EDK2_SKIP_PEICORE)

> >    PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf

> > diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc

> > index a70f91bb02d5..dad9cae97ed4 100644

> > --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc

> > +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc

> > @@ -156,7 +156,6 @@ [LibraryClasses.common.SEC]

> >    ArmPlatformLib|Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf

> >

> >    DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf

> > -  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf

> >

> >    ArmGicArchLib|ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf

> >

> > diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc

> > index 722c4adb7a72..7e9728d0430e 100644

> > --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc

> > +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc

> > @@ -155,7 +155,6 @@ [LibraryClasses.common.SEC]

> >    ArmPlatformLib|Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf

> >

> >    DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf

> > -  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf

> >

> >    ArmGicArchLib|ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf

> >

> > diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc

> > index 63d28a57406b..1282a97801b6 100644

> > --- a/Silicon/Hisilicon/Hisilicon.dsc.inc

> > +++ b/Silicon/Hisilicon/Hisilicon.dsc.inc

> > @@ -127,8 +127,6 @@ [LibraryClasses.common]

> >    NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf

> >

> >  [LibraryClasses.common.SEC]

> > -  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf

> > -

> >    ArmGicArchLib|ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf

> >    PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf

> >    BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf

> > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc

> > index b3fd1846c0bf..92ff1daf8391 100644

> > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc

> > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc

> > @@ -154,7 +154,6 @@ [LibraryClasses.common]

> >

> >  [LibraryClasses.common.SEC]

> >    DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf

> > -  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf

> >

> >    PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf

> >    ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf

> > --

> > 2.19.2

> >

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index 49671eefbdea..93d351de5a27 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -173,7 +173,6 @@  [LibraryClasses.common.SEC]
   ArmPlatformLib|Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf
 
   DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf
-  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf
 
   ArmGicArchLib|ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf
 
diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
index 713c5637b074..e7a77c0ad957 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
@@ -148,7 +148,6 @@  [LibraryClasses.common]
 
 [LibraryClasses.common.SEC]
   DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf
-  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf
 
 !ifdef $(EDK2_SKIP_PEICORE)
   PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
index a70f91bb02d5..dad9cae97ed4 100644
--- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
+++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
@@ -156,7 +156,6 @@  [LibraryClasses.common.SEC]
   ArmPlatformLib|Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf
 
   DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf
-  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf
 
   ArmGicArchLib|ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf
 
diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
index 722c4adb7a72..7e9728d0430e 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
@@ -155,7 +155,6 @@  [LibraryClasses.common.SEC]
   ArmPlatformLib|Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf
 
   DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf
-  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf
 
   ArmGicArchLib|ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf
 
diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc
index 63d28a57406b..1282a97801b6 100644
--- a/Silicon/Hisilicon/Hisilicon.dsc.inc
+++ b/Silicon/Hisilicon/Hisilicon.dsc.inc
@@ -127,8 +127,6 @@  [LibraryClasses.common]
   NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
 
 [LibraryClasses.common.SEC]
-  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf
-
   ArmGicArchLib|ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf
   PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
   BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index b3fd1846c0bf..92ff1daf8391 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -154,7 +154,6 @@  [LibraryClasses.common]
 
 [LibraryClasses.common.SEC]
   DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf
-  DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf
 
   PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
   ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf