From patchwork Fri Dec 21 11:50:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Preudhomme X-Patchwork-Id: 154391 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp820712ljp; Fri, 21 Dec 2018 03:51:11 -0800 (PST) X-Google-Smtp-Source: ALg8bN4w6d47jl8GkSpGitY5JDYVtspHTizP1PdXwLysaQ1rXOhQVXyUQ60o1urq3kk7zstRT4Fz X-Received: by 2002:a63:6bc1:: with SMTP id g184mr2121668pgc.25.1545393071583; Fri, 21 Dec 2018 03:51:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545393071; cv=none; d=google.com; s=arc-20160816; b=cEzXnyEzm5dKAuWnZP17Qq1GAE1ErQ4u5M6WGKziiolrWYskpfwzSGJCRfUbr9pGvI /bYrlqMmIWdjdWQwhl8OlRktJ9ireg9NCimGEeDFT7sTPmZ5Xn3TB+teb4t6htuR5XuB WRd7DdgcCVCi/2JUUdTY3cICscBqUq+oaOjVvM9Qu6/MZW4tZ0uP2Nvu53mIFJ/LbSX6 kI1VOaxxECsfGk2NKCKKgUiWQL/nq4e7b1dedkjt+nwS6plbwgnnEVr2bBEuJkGa0V7J 2La+h6+ZF5GdGSftq7PUkcvABxU0wsAj9XCD77EjQ0mOK4/EFGqpButeVL49JpjG/I0k +EGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:subject:message-id:date:from:mime-version:dkim-signature :delivered-to:sender:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mailing-list:dkim-signature :domainkey-signature; bh=QJ1/sdrqqnfdY0Xp5lk805u1/hTv1gze6trgug6Nifg=; b=LlpFe1/dDio0zBjVYBIMCL4u+vNNwC4ljilFBqBMKg/Si/NT+2fjmBHfih8FO61dh6 4yDCvCScq3hY45wRjS4CAD6Hw7zXbitVnPnhB6ESKYCpLfsgXADhCw151dvH/q5BsqkB O7u2zX1tVWT1Pv32ap72Fz9bESO7MeJlpN4YbGxbhBIwPZiiJ1NpJJ0jvFGDxUYjd98r aHUye8a4ZN/zAo18fdQ49MeDSjP/SB2opQac9/HYV5CnHwD0f/e88PWh4ptrvXMRZsH+ /FkoRCtUaO1bJzKR3F/dNC1duEty6g5wO2glYdyK3vFQR7uq/EnEGUA3So05UJ7d91fd ys7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=hTrC5uik; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=S1zcDmbV; spf=pass (google.com: domain of gcc-patches-return-492983-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="gcc-patches-return-492983-patch=linaro.org@gcc.gnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id m187si22177436pfm.51.2018.12.21.03.51.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Dec 2018 03:51:11 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-492983-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=hTrC5uik; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=S1zcDmbV; spf=pass (google.com: domain of gcc-patches-return-492983-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="gcc-patches-return-492983-patch=linaro.org@gcc.gnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=j1i837OK0VF5UC/yRsaRlO2KImcE2ZBvAq/mpO0ZBugTyJ RyyJXREUhdpce8QSugLAA8NIau8PXt5dhtQQc2OHCXhCOyNHBsJpVn9xMuzOo2YJ OMfLolnWuPQgQUmCJMHqQghqDOvrHja9KlKVFzOx+wDPXKhv4l9Uc3WvK700A= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=mggjtnhXUrkc3jjaRSD6+s5MGUM=; b=hTrC5uikr8ICMt66Z03A 7F6ni2Y2wqGkbo7Meof5AzvuxuTBr1Kkh+tjrrYoD4N5SOkT2EW3Rr4DbPnMZk4Q D96M6ZMxAH3Fza3BTAeONdSIZiuRjvMS8jbnnAXwhevUEBAuc8dCjsI5lTQqjCYT p702MLwiR2gblp+bdWfheBU= Received: (qmail 61672 invoked by alias); 21 Dec 2018 11:50:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 61661 invoked by uid 89); 21 Dec 2018 11:50:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=thomas.preudhomme@linaro.org, Preudhomme, preud'homme, thomaspreudhommelinaroorg X-HELO: mail-it1-f170.google.com Received: from mail-it1-f170.google.com (HELO mail-it1-f170.google.com) (209.85.166.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Dec 2018 11:50:57 +0000 Received: by mail-it1-f170.google.com with SMTP id g85so6428849ita.3 for ; Fri, 21 Dec 2018 03:50:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=fnp8oIl6STat6fN49XsS5cDbAt4kBTk4VPaPYqzz/mY=; b=S1zcDmbVu9kHfFjWY1pKEYfgb4BaZHWauFwQRyXHCNTmffFKo7qfaterdxTPg3tG1G SkB+6XpY0tzFDREORxKKf7Kd46Gq/DpYgG5y1INtygRCgMjaRt69Twjcvmjhd06EeMY2 b8DkYfl60CNGrFaBh8HGdZW+j/nkmMt+3kNHY= MIME-Version: 1.0 From: Thomas Preudhomme Date: Fri, 21 Dec 2018 11:50:43 +0000 Message-ID: Subject: [PATCH, ARM, committed] Fix size-optimization-ieee testcase failure To: gcc-patches@gcc.gnu.org X-IsSubscribed: yes I've committed the obvious attached patch to fix the gcc.target/arm/size-optimization-ieee-* testcase failures. On some version of dejagnu, options in RUNTESTFLAGS are appended to the command-line and thus any -mfloat-abi=softfp or -mfloat-abi=hard in there overwrite the -mfloat-abi=soft in the dg-options for size-optimization-ieee-* tests. Test is still run though because arm_soft_ok returns true if -mfloat-abi=soft is accepted, even if the file is not compiled for softfloat due to a later -mfloat-abi on the command line. This patch adds a dg-skip-if to those tests to ensure they are not run in softfp or hard mode. 2018-12-21 Thomas Preud'homme gcc/testsuite/ * gcc.target/arm/size-optimization-ieee-1.c: Skip if passing -mfloat-abi=softfp or -mfloat-abi=hard. * gcc.target/arm/size-optimization-ieee-2.c: Likewise. * gcc.target/arm/size-optimization-ieee-3.c: Likewise. >From c13cca23aa64a07f66c80f14dbdd79c63163783c Mon Sep 17 00:00:00 2001 From: thopre01 Date: Fri, 21 Dec 2018 11:49:04 +0000 Subject: [PATCH] [ARM] Fix size-optimization-ieee testcase failure On some version of dejagnu, options in RUNTESTFLAGS are appended to the command-line and thus any -mfloat-abi=softfp or -mfloat-abi=hard in there overwrite the -mfloat-abi=soft in the dg-options for size-optimization-ieee-* tests. Test is still run though because arm_soft_ok returns true if -mfloat-abi=soft is accepted, even if the file is not compiled for softfloat due to a later -mfloat-abi on the command line. This patch adds a dg-skip-if to those tests to ensure they are not run in softfp or hard mode. 2018-12-21 Thomas Preud'homme gcc/testsuite/ * gcc.target/arm/size-optimization-ieee-1.c: Skip if passing -mfloat-abi=softfp or -mfloat-abi=hard. * gcc.target/arm/size-optimization-ieee-2.c: Likewise. * gcc.target/arm/size-optimization-ieee-3.c: Likewise. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@267323 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/testsuite/ChangeLog | 7 +++++++ gcc/testsuite/gcc.target/arm/size-optimization-ieee-1.c | 1 + gcc/testsuite/gcc.target/arm/size-optimization-ieee-2.c | 1 + gcc/testsuite/gcc.target/arm/size-optimization-ieee-3.c | 1 + 4 files changed, 10 insertions(+) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index dcac93bb275..1569e7aaa0f 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2018-12-21 Thomas Preud'homme + + * gcc.target/arm/size-optimization-ieee-1.c: Skip if passing + -mfloat-abi=softfp or -mfloat-abi=hard. + * gcc.target/arm/size-optimization-ieee-2.c: Likewise. + * gcc.target/arm/size-optimization-ieee-3.c: Likewise. + 2018-12-21 Jakub Jelinek PR target/88547 diff --git a/gcc/testsuite/gcc.target/arm/size-optimization-ieee-1.c b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-1.c index 34090f20fec..61475eb4c67 100644 --- a/gcc/testsuite/gcc.target/arm/size-optimization-ieee-1.c +++ b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-1.c @@ -1,4 +1,5 @@ /* { dg-do link { target arm_soft_ok } } */ +/* { dg-skip-if "Feature is -mfloat-abi=soft only" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=soft" } } */ /* { dg-options "-mfloat-abi=soft" } */ int diff --git a/gcc/testsuite/gcc.target/arm/size-optimization-ieee-2.c b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-2.c index 75337894a9c..b4699271cea 100644 --- a/gcc/testsuite/gcc.target/arm/size-optimization-ieee-2.c +++ b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-2.c @@ -1,4 +1,5 @@ /* { dg-do link { target arm_soft_ok } } */ +/* { dg-skip-if "Feature is -mfloat-abi=soft only" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=soft" } } */ /* { dg-options "-mfloat-abi=soft" } */ int diff --git a/gcc/testsuite/gcc.target/arm/size-optimization-ieee-3.c b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-3.c index 63c92b3bbb7..34b1ebe7afd 100644 --- a/gcc/testsuite/gcc.target/arm/size-optimization-ieee-3.c +++ b/gcc/testsuite/gcc.target/arm/size-optimization-ieee-3.c @@ -1,4 +1,5 @@ /* { dg-do link { target arm_soft_ok } } */ +/* { dg-skip-if "Feature is -mfloat-abi=soft only" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=soft" } } */ /* { dg-options "-mfloat-abi=soft" } */ int -- 2.19.1