diff mbox series

[Xen-devel,for-4.12,v3,7/8] xenalyze: Build for Both ARM and x86 Platforms

Message ID 20181221162650.11515-8-julien.grall@arm.com
State New
Headers show
Series xen/arm: Add xentrace support | expand

Commit Message

Julien Grall Dec. 21, 2018, 4:26 p.m. UTC 
From: Benjamin Sanda <ben.sanda@dornerworks.com>

Modified to provide building of the xenalyze binary for both ARM and
x86 platforms. The xenalyze binary is now built as part of the BIN
list for both platforms.

Signed-off-by: Benjamin Sanda <ben.sanda@dornerworks.com>
Signed-off-by: Julien Grall <julien.grall@arm.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Stefano Stabellini <sstabelini@kernel.org>

---
    Changes in v3:
        - Add Stefano's acked-by

    Changes in v2:
        - Add Wei's acked-by
---
 tools/xentrace/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Julien Grall Dec. 21, 2018, 4:28 p.m. UTC | #1 
Hi,

On 21/12/2018 16:26, Julien Grall wrote:
> From: Benjamin Sanda <ben.sanda@dornerworks.com>
> 
> Modified to provide building of the xenalyze binary for both ARM and
> x86 platforms. The xenalyze binary is now built as part of the BIN
> list for both platforms.
> 
> Signed-off-by: Benjamin Sanda <ben.sanda@dornerworks.com>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> Acked-by: Stefano Stabellini <sstabelini@kernel.org>

I made a typo in the address e-mail. Stefano, could you fix it on commit?

Cheers,

> 
> ---
>      Changes in v3:
>          - Add Stefano's acked-by
> 
>      Changes in v2:
>          - Add Wei's acked-by
> ---
>   tools/xentrace/Makefile | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
> index 0bad942bdf..9fb7fc96e7 100644
> --- a/tools/xentrace/Makefile
> +++ b/tools/xentrace/Makefile
> @@ -9,8 +9,7 @@ LDLIBS += $(LDLIBS_libxenevtchn)
>   LDLIBS += $(LDLIBS_libxenctrl)
>   LDLIBS += $(ARGP_LDFLAGS)
>   
> -BIN-$(CONFIG_X86) = xenalyze
> -BIN      = $(BIN-y)
> +BIN      = xenalyze
>   SBIN     = xentrace xentrace_setsize
>   LIBBIN   = xenctx
>   SCRIPTS  = xentrace_format
>
Stefano Stabellini Dec. 21, 2018, 5:48 p.m. UTC | #2 
On Fri, 21 Dec 2018, Julien Grall wrote:
> Hi,
> 
> On 21/12/2018 16:26, Julien Grall wrote:
> > From: Benjamin Sanda <ben.sanda@dornerworks.com>
> > 
> > Modified to provide building of the xenalyze binary for both ARM and
> > x86 platforms. The xenalyze binary is now built as part of the BIN
> > list for both platforms.
> > 
> > Signed-off-by: Benjamin Sanda <ben.sanda@dornerworks.com>
> > Signed-off-by: Julien Grall <julien.grall@arm.com>
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
> > Acked-by: Stefano Stabellini <sstabelini@kernel.org>
> 
> I made a typo in the address e-mail. Stefano, could you fix it on commit?

Yes, fixed on commit. First 7 patches have been committed.


> > ---
> >      Changes in v3:
> >          - Add Stefano's acked-by
> > 
> >      Changes in v2:
> >          - Add Wei's acked-by
> > ---
> >   tools/xentrace/Makefile | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
> > index 0bad942bdf..9fb7fc96e7 100644
> > --- a/tools/xentrace/Makefile
> > +++ b/tools/xentrace/Makefile
> > @@ -9,8 +9,7 @@ LDLIBS += $(LDLIBS_libxenevtchn)
> >   LDLIBS += $(LDLIBS_libxenctrl)
> >   LDLIBS += $(ARGP_LDFLAGS)
> >   -BIN-$(CONFIG_X86) = xenalyze
> > -BIN      = $(BIN-y)
> > +BIN      = xenalyze
> >   SBIN     = xentrace xentrace_setsize
> >   LIBBIN   = xenctx
> >   SCRIPTS  = xentrace_format
> > 
> 
> -- 
> Julien Grall
>
diff mbox series

Patch

diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
index 0bad942bdf..9fb7fc96e7 100644
--- a/tools/xentrace/Makefile
+++ b/tools/xentrace/Makefile
@@ -9,8 +9,7 @@  LDLIBS += $(LDLIBS_libxenevtchn)
 LDLIBS += $(LDLIBS_libxenctrl)
 LDLIBS += $(ARGP_LDFLAGS)
 
-BIN-$(CONFIG_X86) = xenalyze
-BIN      = $(BIN-y)
+BIN      = xenalyze
 SBIN     = xentrace xentrace_setsize
 LIBBIN   = xenctx
 SCRIPTS  = xentrace_format