From patchwork Wed Jan 2 09:17:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 154641 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp12686402ljp; Wed, 2 Jan 2019 01:19:57 -0800 (PST) X-Google-Smtp-Source: AFSGD/UptAlw4CA8yeXVopLHoPeiO3AJ9gaOqJV2SpiLC0v2/ASaKp9Yxi4Gr4NxqQGlUwi5q1Fj X-Received: by 2002:a62:cf02:: with SMTP id b2mr45295429pfg.183.1546420797742; Wed, 02 Jan 2019 01:19:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546420797; cv=none; d=google.com; s=arc-20160816; b=caCfxltNhW05gE7+f4L01DTppuAXraH7dcXJnVbUESgVGVY7Fwq8QAOmNmOwKZsTHk q1IDEwXy8fVvmmQWY40tJjkkYjtdbLL/qKl9+lyDRt5HgdV1bnzDhew6UBE72brkNvLh D65uS8RVppC/WHach/BuCabckGILUprqX9fwqAQd4pzJjnqjqUHItlHw/6+9VCIDE011 hmlM5jUyTLbwh5MnESWiOHTC35jY+wPBXeezPmidUnKSpjYOjFkE3o+H/bNIZv74UuDA GRxRGxP91jCoQuPdTIEjxiVuzoMn0H41XE0hbEgBLUiNfaacsjBIMfOhn3PkcIfzHb0h X5vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+jOmYh454MZBmswy3pXGa5T7U3PVFxski1zAQACZifs=; b=CwHQZCRQEO0L6s0zVrQX5k9m0n2pz2oj4L7BZbMYkluiHDX3n07AsAPUl8x7eVOCZi fzPxcM2TPFDed+KTmathZBgDTlW3NVbcEjxrS4iYzjC45wmPkTde4hXlJOi1wG54gkzQ Db+tQrdfST4LirfTt8ZKtbIVR2m4b0u7Hu8oU4T0zHHy9uSgcl1R8H8jbXom0aGHjL/f 6Q/ygvSY8H7adHEdg94hCf2tW1UBVOXFfrO2dcKgPK4/gvL+T0dgt11OeJpNMW6iRch/ h3em25+AaYM8wuR2TN2zhz/x7cwxQFKvD3MYiknZJktYNTHuu9VTsrOhKofsggXrgqfX 0Rrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2crBKOFl; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t17si14908523pgk.217.2019.01.02.01.19.57; Wed, 02 Jan 2019 01:19:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2crBKOFl; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729150AbfABJT4 (ORCPT + 10 others); Wed, 2 Jan 2019 04:19:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:46818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726782AbfABJT4 (ORCPT ); Wed, 2 Jan 2019 04:19:56 -0500 Received: from localhost.localdomain (unknown [171.76.109.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 823462171F; Wed, 2 Jan 2019 09:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546420795; bh=1sWof/2cFdPJlwhUxyC71vY9rTlmh05IdxWncznxeEc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2crBKOFlRLvDkR/DGGqNxZ3A6h7FVruncp0Ekl0aLVXkdUDlL9R4j0Cr+vQhy/3/e BjSOcUGc9jBzGPI/Rgl1wJ1t6mUfU+PFljLGkqoy+fhIzm+YnRh+fW79d5D5/Nd660 EdRrg6U6szxpxA0/yup+nsH21p6ejcns3CMgJ6Z8= From: Vinod Koul To: "David S . Miller" Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Niklas Cassel , Bjorn Andersson , Vinod Koul , Andrew Lunn , Florian Fainelli Subject: [PATCH 5/7] net: phy: at803x: Rework at803x_config_init() Date: Wed, 2 Jan 2019 14:47:27 +0530 Message-Id: <20190102091729.18582-6-vkoul@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190102091729.18582-1-vkoul@kernel.org> References: <20190102091729.18582-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Rework at803x_config_init() function to check and program the tx and rx delay enable separately. This will help in checking the delay to be programmed based on other conditions as well. Signed-off-by: Vinod Koul --- drivers/net/phy/at803x.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) -- 2.20.1 diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index e74a047a846e..63e3d3d774d1 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -249,6 +249,7 @@ static int at803x_probe(struct phy_device *phydev) static int at803x_config_init(struct phy_device *phydev) { + bool rx_delay = false, tx_delay = false; int ret; ret = genphy_config_init(phydev); @@ -256,14 +257,19 @@ static int at803x_config_init(struct phy_device *phydev) return ret; if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID || - phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) { + phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) + rx_delay = true; + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID || + phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) + tx_delay = true; + + if (rx_delay) { ret = at803x_enable_rx_delay(phydev); if (ret < 0) return ret; } - if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID || - phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) { + if (tx_delay) { ret = at803x_enable_tx_delay(phydev); if (ret < 0) return ret;