From patchwork Wed Jan 2 15:28:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Firoz Khan X-Patchwork-Id: 154666 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp292675ljp; Wed, 2 Jan 2019 07:29:25 -0800 (PST) X-Google-Smtp-Source: ALg8bN7osGa6Pkzhq+JKOVBOKApG8PgoaEeF9UgZh3HyB3lWhx7A3rBgYBJpwHzqOMWr7GyJ2HFs X-Received: by 2002:a63:dd55:: with SMTP id g21mr13589572pgj.86.1546442965720; Wed, 02 Jan 2019 07:29:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546442965; cv=none; d=google.com; s=arc-20160816; b=z1EPdguI2fLYF6FcW7HPPL+3H60Zy1ZaKpwpuPmQteIEvQsQ1AqivT1X6m5pxKfmJS 4FAvDRLaSFIYrBf/vZCHCDTgN5dPy44VSxBzwQjs2BHyk1C2obBqqvAc5Y8/T3iD+q7u 7NTkKcbeE/SlicguKCEHtpwUNLC0vGsrVzmcMBddvN9LJXH/+L8V5P3jU/xOTE+62QEH x7cY0HbDHwLDtrm/LuM/QySk1FJXEsZxMiXP54d9stdWN8eSbBENZxi8fUlaL63BcK3X /Fi4+/VQbLVCRJAy4rbgmR1VSrRu/30qYq/x02QM1ocv8XXzjpph5uiLND8PaFpjHqNw wYyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=myGiGPFYzEzo3ceYJtj1+5n7XmY861E8tGq+s31tnXA=; b=OiB4wZAqqeHjCHpcs401uoSfBgq3GJKlFe12KWpFvbqA4S+pESEGZnMUEczEGkn+m1 f412k3wWsyirTpOLmIewqjjVEwFhygGgc36/y+dWYY4kZpgtm7abM04iti4LCCvYf9x6 PIooeDOKWIyVqX4rvy9M881H0AAbXhbAYRwSFC8+LPn45kuKPGCT7CyQmByDqMvLsckE yHpHj6glsP7QqXuo9KWTJa8xZxVhzy7YFvdEjywXdr/OWpceO5h2HUbObCgt/yToaIj3 5vX9DZ09wc0gkJw+csehXeyOxc/vlF1W3nRlAuKDT89sPeQventosCT32jiTCZ4dB5ks qZ5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QC8VEHME; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r14si9530927pfh.229.2019.01.02.07.29.25; Wed, 02 Jan 2019 07:29:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QC8VEHME; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730152AbfABP3X (ORCPT + 31 others); Wed, 2 Jan 2019 10:29:23 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:44785 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730137AbfABP3W (ORCPT ); Wed, 2 Jan 2019 10:29:22 -0500 Received: by mail-pl1-f194.google.com with SMTP id e11so14630072plt.11 for ; Wed, 02 Jan 2019 07:29:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=myGiGPFYzEzo3ceYJtj1+5n7XmY861E8tGq+s31tnXA=; b=QC8VEHMElJnlDDPtKVmbXwhtKQ8Xxe/7/+6XLmYHwJPcOwskfIZHyggVVl5gURJ5+0 3gY+0RgpiHio56Z6sYWWsTHq9aDLP9I9aXiBpIdcFzICrFZJ7cnjTtiX0KBEjwfNVdAL FIZaheFYrOX6ILzPP4iPpmh7eqtnJkvLFDL6o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=myGiGPFYzEzo3ceYJtj1+5n7XmY861E8tGq+s31tnXA=; b=StGvtghbxQWKQ8iv0r5WNMyIlkdzSYN8WvYxMua2U7RA+YBodjYAERUDFsndOHVfJR ErWwZDyxk3gjB2I5lA7yzp7Y9o5bPjzHc4s2bx/KwbevvGf8PmJSlG3aDJAYMpmd4Rru 6FE6dh5CFfSTaqkm8ajNsPQucMenLjm8RNQg4Oj/sSuQOnMx+3IfzBdmrrALj2pkOza/ pdnjzNh8NrXyVz8TrWN5NlayybZoprYjY8GXS8PSXbpWHoO7xBZJUn1Uji3cUz8ax3ZG wLXQbwEZMfUM03Es7/lkqPgC7+koc/vklUzNfcHCAFT2A9BKNxeFco0xcR3iEoTF5pV3 hPaQ== X-Gm-Message-State: AJcUukf3YaHAqKFiUJs+VaXLPMcHAlhuyLtMxb7DzropBVNs0V48Uhl6 hYS53sZH+mYkjlDBf4sUd8zZfQ== X-Received: by 2002:a17:902:b01:: with SMTP id 1mr44490225plq.331.1546442961658; Wed, 02 Jan 2019 07:29:21 -0800 (PST) Received: from qualcomm-HP-ZBook-14-G2.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id k191sm63030673pgd.9.2019.01.02.07.29.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 02 Jan 2019 07:29:21 -0800 (PST) From: Firoz Khan To: Chris Zankel , Max Filippov , Dominik Brodowski , linux-xtensa@linux-xtensa.org, Greg Kroah-Hartman , Philippe Ombredanne , Thomas Gleixner , Kate Stewart Cc: y2038@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, arnd@arndb.de, deepa.kernel@gmail.com, marcin.juszkiewicz@linaro.org, firoz.khan@linaro.org Subject: [PATCH 1/2] xtensa: remove nargs from __SYSCALL Date: Wed, 2 Jan 2019 20:58:31 +0530 Message-Id: <1546442912-20818-2-git-send-email-firoz.khan@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1546442912-20818-1-git-send-email-firoz.khan@linaro.org> References: <1546442912-20818-1-git-send-email-firoz.khan@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The __SYSCALL macro's arguments are system call number, system call entry name and number of arguments for the system call. Argument- nargs in __SYSCALL(nr, entry, nargs) is neither calculated nor used anywhere. So it would be better to keep the implementaion as __SYSCALL(nr, entry). This will unifies the implementation with some other architetures too. Signed-off-by: Firoz Khan --- arch/xtensa/kernel/syscall.c | 2 +- arch/xtensa/kernel/syscalls/syscalltbl.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- 1.9.1 Acked-by: Max Filippov Acked-by: Max Filippov diff --git a/arch/xtensa/kernel/syscall.c b/arch/xtensa/kernel/syscall.c index 2c415fc..0665339 100644 --- a/arch/xtensa/kernel/syscall.c +++ b/arch/xtensa/kernel/syscall.c @@ -31,7 +31,7 @@ syscall_t sys_call_table[__NR_syscalls] /* FIXME __cacheline_aligned */= { [0 ... __NR_syscalls - 1] = (syscall_t)&sys_ni_syscall, -#define __SYSCALL(nr, entry, nargs)[nr] = (syscall_t)entry, +#define __SYSCALL(nr, entry)[nr] = (syscall_t)entry, #include #undef __SYSCALL }; diff --git a/arch/xtensa/kernel/syscalls/syscalltbl.sh b/arch/xtensa/kernel/syscalls/syscalltbl.sh index 85d78d9..904b8e6 100644 --- a/arch/xtensa/kernel/syscalls/syscalltbl.sh +++ b/arch/xtensa/kernel/syscalls/syscalltbl.sh @@ -13,10 +13,10 @@ emit() { t_entry="$3" while [ $t_nxt -lt $t_nr ]; do - printf "__SYSCALL(%s, sys_ni_syscall, )\n" "${t_nxt}" + printf "__SYSCALL(%s,sys_ni_syscall)\n" "${t_nxt}" t_nxt=$((t_nxt+1)) done - printf "__SYSCALL(%s, %s, )\n" "${t_nxt}" "${t_entry}" + printf "__SYSCALL(%s,%s)\n" "${t_nxt}" "${t_entry}" } grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (