[1/2] gdb-cross-canadian: Add bison-native for gdb-cross-canadian

Message ID 20190102192111.33587-1-raj.khem@gmail.com
State New
Headers show
Series
  • [1/2] gdb-cross-canadian: Add bison-native for gdb-cross-canadian
Related show

Commit Message

Khem Raj Jan. 2, 2019, 7:21 p.m.
From: pino-kim <sungwon.pino@gmail.com>


This fixes RISC-V gdb-cross-canadian cross compile configure failure on missing bison.

Signed-off-by: pino-kim <sungwon.pino@gmail.com>

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.20.1

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Jacob Kroon Jan. 2, 2019, 7:32 p.m. | #1
On Wed, Jan 2, 2019 at 8:21 PM Khem Raj <raj.khem@gmail.com> wrote:
>

> From: pino-kim <sungwon.pino@gmail.com>

>

> This fixes RISC-V gdb-cross-canadian cross compile configure failure on missing bison.

>

> Signed-off-by: pino-kim <sungwon.pino@gmail.com>

> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> ---

>  meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)

>

> diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc

> index 475e4f08ef..e54766bbb2 100644

> --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc

> +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc

> @@ -6,7 +6,8 @@ PN = "gdb-cross-canadian-${TRANSLATED_TARGET_ARCH}"

>  BPN = "gdb"

>

>  DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \

> -           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-libc"

> +           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk \

> +           virtual/nativesdk-libc bison-native"

>


Would it make sense to restrict this to DEPENDS_append_riscv32/64 ?

>  GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"

>

> --

> 2.20.1

>

> --

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj Jan. 2, 2019, 7:42 p.m. | #2
On Wed, Jan 2, 2019 at 11:32 AM Jacob Kroon <jacob.kroon@gmail.com> wrote:
>

> On Wed, Jan 2, 2019 at 8:21 PM Khem Raj <raj.khem@gmail.com> wrote:

> >

> > From: pino-kim <sungwon.pino@gmail.com>

> >

> > This fixes RISC-V gdb-cross-canadian cross compile configure failure on missing bison.

> >

> > Signed-off-by: pino-kim <sungwon.pino@gmail.com>

> > Signed-off-by: Khem Raj <raj.khem@gmail.com>

> > ---

> >  meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-

> >  1 file changed, 2 insertions(+), 1 deletion(-)

> >

> > diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc

> > index 475e4f08ef..e54766bbb2 100644

> > --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc

> > +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc

> > @@ -6,7 +6,8 @@ PN = "gdb-cross-canadian-${TRANSLATED_TARGET_ARCH}"

> >  BPN = "gdb"

> >

> >  DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \

> > -           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-libc"

> > +           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk \

> > +           virtual/nativesdk-libc bison-native"

> >

>

> Would it make sense to restrict this to DEPENDS_append_riscv32/64 ?


Its not particular to riscv, it just happens to unearth the problem
for us since its building gdb from upstream
master, we are going to land into this problem eventually when we upgrade.

>

> >  GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"

> >

> > --

> > 2.20.1

> >

> > --

> > _______________________________________________

> > Openembedded-core mailing list

> > Openembedded-core@lists.openembedded.org

> > http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Richard Purdie Jan. 2, 2019, 9:31 p.m. | #3
On Wed, 2019-01-02 at 11:42 -0800, Khem Raj wrote:
> On Wed, Jan 2, 2019 at 11:32 AM Jacob Kroon <jacob.kroon@gmail.com>

> wrote:

> > On Wed, Jan 2, 2019 at 8:21 PM Khem Raj <raj.khem@gmail.com> wrote:

> > > From: pino-kim <sungwon.pino@gmail.com>

> > > 

> > > This fixes RISC-V gdb-cross-canadian cross compile configure

> > > failure on missing bison.

> > > 

> > > Signed-off-by: pino-kim <sungwon.pino@gmail.com>

> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>

> > > ---

> > >  meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-

> > >  1 file changed, 2 insertions(+), 1 deletion(-)

> > > 

> > > diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc

> > > b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc

> > > index 475e4f08ef..e54766bbb2 100644

> > > --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc

> > > +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc

> > > @@ -6,7 +6,8 @@ PN = "gdb-cross-canadian-

> > > ${TRANSLATED_TARGET_ARCH}"

> > >  BPN = "gdb"

> > > 

> > >  DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \

> > > -           virtual/${HOST_PREFIX}gcc-crosssdk

> > > virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-libc"

> > > +           virtual/${HOST_PREFIX}gcc-crosssdk

> > > virtual/${HOST_PREFIX}binutils-crosssdk \

> > > +           virtual/nativesdk-libc bison-native"

> > > 

> > 

> > Would it make sense to restrict this to DEPENDS_append_riscv32/64 ?

> 

> Its not particular to riscv, it just happens to unearth the problem

> for us since its building gdb from upstream

> master, we are going to land into this problem eventually when we

> upgrade.


Is this not a tarball verses source control issue (the git version
needs the dependency, the tarball doesn't)?

Cheers,

Richard



-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj Jan. 2, 2019, 9:35 p.m. | #4
On Wed, Jan 2, 2019 at 1:31 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>

> On Wed, 2019-01-02 at 11:42 -0800, Khem Raj wrote:

> > On Wed, Jan 2, 2019 at 11:32 AM Jacob Kroon <jacob.kroon@gmail.com>

> > wrote:

> > > On Wed, Jan 2, 2019 at 8:21 PM Khem Raj <raj.khem@gmail.com> wrote:

> > > > From: pino-kim <sungwon.pino@gmail.com>

> > > >

> > > > This fixes RISC-V gdb-cross-canadian cross compile configure

> > > > failure on missing bison.

> > > >

> > > > Signed-off-by: pino-kim <sungwon.pino@gmail.com>

> > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>

> > > > ---

> > > >  meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-

> > > >  1 file changed, 2 insertions(+), 1 deletion(-)

> > > >

> > > > diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc

> > > > b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc

> > > > index 475e4f08ef..e54766bbb2 100644

> > > > --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc

> > > > +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc

> > > > @@ -6,7 +6,8 @@ PN = "gdb-cross-canadian-

> > > > ${TRANSLATED_TARGET_ARCH}"

> > > >  BPN = "gdb"

> > > >

> > > >  DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \

> > > > -           virtual/${HOST_PREFIX}gcc-crosssdk

> > > > virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-libc"

> > > > +           virtual/${HOST_PREFIX}gcc-crosssdk

> > > > virtual/${HOST_PREFIX}binutils-crosssdk \

> > > > +           virtual/nativesdk-libc bison-native"

> > > >

> > >

> > > Would it make sense to restrict this to DEPENDS_append_riscv32/64 ?

> >

> > Its not particular to riscv, it just happens to unearth the problem

> > for us since its building gdb from upstream

> > master, we are going to land into this problem eventually when we

> > upgrade.

>

> Is this not a tarball verses source control issue (the git version

> needs the dependency, the tarball doesn't)?


yes that has triggered it but I have also seen it on certain bare
minimum build host OSes in past
even with tarballs.
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
index 475e4f08ef..e54766bbb2 100644
--- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
+++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
@@ -6,7 +6,8 @@  PN = "gdb-cross-canadian-${TRANSLATED_TARGET_ARCH}"
 BPN = "gdb"
 
 DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \
-           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-libc"
+           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk \
+           virtual/nativesdk-libc bison-native"
 
 GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"