| Message ID | 20190103135743.22089-1-tomi.valkeinen@ti.com |
|---|---|
| State | Accepted |
| Commit | 9fba099b7a84308922017cd6ca1c4c8b4954cb99 |
| Headers | show |
| Series | drm/bridge: sii902x: add sampling edge | expand |
Hi Tomi,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on next-20190103]
[cannot apply to v4.20]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Tomi-Valkeinen/drm-bridge-sii902x-add-sampling-edge/20190104-041208
config: x86_64-randconfig-x012-201900 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/bridge/sii902x.c:463:19: error: 'DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE' undeclared here (not in a function); did you mean 'DRM_BUS_FLAG_PIXDATA_NEGEDGE'?
.sampling_edge = DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
DRM_BUS_FLAG_PIXDATA_NEGEDGE
>> drivers/gpu/drm/bridge/sii902x.c:464:6: error: 'DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE' undeclared here (not in a function); did you mean 'DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE'?
| DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE
vim +463 drivers/gpu/drm/bridge/sii902x.c
461
462 static const struct drm_bridge_timings default_sii902x_timings = {
> 463 .sampling_edge = DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE
> 464 | DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE
465 | DRM_BUS_FLAG_DE_HIGH,
466 };
467
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi Tomi,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on next-20190103]
[cannot apply to v4.20]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Tomi-Valkeinen/drm-bridge-sii902x-add-sampling-edge/20190104-041208
config: nds32-allmodconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 6.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=6.4.0 make.cross ARCH=nds32
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/bridge/sii902x.c:463:19: error: 'DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE' undeclared here (not in a function)
.sampling_edge = DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/bridge/sii902x.c:464:6: error: 'DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE' undeclared here (not in a function)
| DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE +463 drivers/gpu/drm/bridge/sii902x.c
461
462 static const struct drm_bridge_timings default_sii902x_timings = {
> 463 .sampling_edge = DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE
> 464 | DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE
465 | DRM_BUS_FLAG_DE_HIGH,
466 };
467
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index bfa902013aa4..799581be98dc 100644 --- a/drivers/gpu/drm/bridge/sii902x.c +++ b/drivers/gpu/drm/bridge/sii902x.c @@ -459,6 +459,12 @@ static int sii902x_i2c_bypass_deselect(struct i2c_mux_core *mux, u32 chan_id) return 0; } +static const struct drm_bridge_timings default_sii902x_timings = { + .sampling_edge = DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE + | DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE + | DRM_BUS_FLAG_DE_HIGH, +}; + static int sii902x_probe(struct i2c_client *client, const struct i2c_device_id *id) { @@ -529,6 +535,7 @@ static int sii902x_probe(struct i2c_client *client, sii902x->bridge.funcs = &sii902x_bridge_funcs; sii902x->bridge.of_node = dev->of_node; + sii902x->bridge.timings = &default_sii902x_timings; drm_bridge_add(&sii902x->bridge); i2c_set_clientdata(client, sii902x);
The driver always sets InputBusFmt:EDGE to 0 (falling edge). Add drm_bridge_timings's sampling_edge to reflect that the bridge samples on falling edges. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> --- NOTE: This needs Laurent's "drm: Clarify definition of the DRM_BUS_FLAG_(PIXDATA|SYNC)_* macros" drivers/gpu/drm/bridge/sii902x.c | 7 +++++++ 1 file changed, 7 insertions(+)