diff mbox series

[edk2,3/8] StandaloneMmPkg/StandaloneMmCoreEntryPoint: use %a modifier for ASCII strings

Message ID 20190104110315.18339-4-ard.biesheuvel@linaro.org
State Superseded
Headers show
Series StandaloneMmPkg: assorted fixes and improvements | expand

Commit Message

Ard Biesheuvel Jan. 4, 2019, 11:03 a.m. UTC
PE/COFF section names are ASCII strings so use %a not %s.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Supreeth Venkatesh Jan. 4, 2019, 5:51 p.m. UTC | #1
On Fri, 2019-01-04 at 12:03 +0100, Ard Biesheuvel wrote:
> PE/COFF section names are ASCII strings so use %a not %s.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>


> ---

>  StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermis

> sions.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git

> a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermi

> ssions.c

> b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermi

> ssions.c

> index 60c1f66b83fa..3ca7f6660f47 100644

> ---

> a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermi

> ssions.c

> +++

> b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermi

> ssions.c

> @@ -78,7 +78,7 @@ UpdateMmFoundationPeCoffPermissions (

>              "%a: Section %d of image at 0x%lx has 0x%x

> permissions\n",

>              __FUNCTION__, Index, ImageContext->ImageAddress,

> SectionHeader.Characteristics));

>      DEBUG ((DEBUG_INFO,

> -            "%a: Section %d of image at 0x%lx has %s name\n",

> +            "%a: Section %d of image at 0x%lx has %a name\n",

>              __FUNCTION__, Index, ImageContext->ImageAddress,

> SectionHeader.Name));

>      DEBUG ((DEBUG_INFO,

>              "%a: Section %d of image at 0x%lx has 0x%x address\n",


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox series

Patch

diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c
index 60c1f66b83fa..3ca7f6660f47 100644
--- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c
+++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c
@@ -78,7 +78,7 @@  UpdateMmFoundationPeCoffPermissions (
             "%a: Section %d of image at 0x%lx has 0x%x permissions\n",
             __FUNCTION__, Index, ImageContext->ImageAddress, SectionHeader.Characteristics));
     DEBUG ((DEBUG_INFO,
-            "%a: Section %d of image at 0x%lx has %s name\n",
+            "%a: Section %d of image at 0x%lx has %a name\n",
             __FUNCTION__, Index, ImageContext->ImageAddress, SectionHeader.Name));
     DEBUG ((DEBUG_INFO,
             "%a: Section %d of image at 0x%lx has 0x%x address\n",