mailbox: tegra-hsp: mark PM functions as __maybe_unused

Message ID 20190108143713.15120-1-anders.roxell@linaro.org
State New
Headers show
Series
  • mailbox: tegra-hsp: mark PM functions as __maybe_unused
Related show

Commit Message

Anders Roxell Jan. 8, 2019, 2:37 p.m.
Without CONFIG_PM_SLEEP, we get annoying warnings about unused
functions:

drivers/mailbox/tegra-hsp.c:782:12: warning: ‘tegra_hsp_resume’ defined but not used [-Wunused-function]
 static int tegra_hsp_resume(struct device *dev)
            ^~~~~~~~~~~~~~~~

Mark them as __maybe_unused to shut up the warning and silently drop the
functions without having to add ugly #ifdefs.

Fixes: 9a63f0f40599 ("mailbox: tegra-hsp: Add suspend/resume support")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

---
 drivers/mailbox/tegra-hsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.19.2

Comments

Thierry Reding Jan. 10, 2019, 8:16 a.m. | #1
On Tue, Jan 08, 2019 at 03:37:13PM +0100, Anders Roxell wrote:
> Without CONFIG_PM_SLEEP, we get annoying warnings about unused

> functions:

> 

> drivers/mailbox/tegra-hsp.c:782:12: warning: ‘tegra_hsp_resume’ defined but not used [-Wunused-function]

>  static int tegra_hsp_resume(struct device *dev)

>             ^~~~~~~~~~~~~~~~

> 

> Mark them as __maybe_unused to shut up the warning and silently drop the

> functions without having to add ugly #ifdefs.

> 

> Fixes: 9a63f0f40599 ("mailbox: tegra-hsp: Add suspend/resume support")

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

> ---

>  drivers/mailbox/tegra-hsp.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)


Acked-by: Thierry Reding <treding@nvidia.com>
Anders Roxell June 19, 2019, 7:56 a.m. | #2
On Thu, 10 Jan 2019 at 09:16, Thierry Reding <thierry.reding@gmail.com> wrote:
>

> On Tue, Jan 08, 2019 at 03:37:13PM +0100, Anders Roxell wrote:

> > Without CONFIG_PM_SLEEP, we get annoying warnings about unused

> > functions:

> >

> > drivers/mailbox/tegra-hsp.c:782:12: warning: ‘tegra_hsp_resume’ defined but not used [-Wunused-function]

> >  static int tegra_hsp_resume(struct device *dev)

> >             ^~~~~~~~~~~~~~~~

> >

> > Mark them as __maybe_unused to shut up the warning and silently drop the

> > functions without having to add ugly #ifdefs.

> >

> > Fixes: 9a63f0f40599 ("mailbox: tegra-hsp: Add suspend/resume support")

> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

> > ---

> >  drivers/mailbox/tegra-hsp.c | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

>

> Acked-by: Thierry Reding <treding@nvidia.com>


Will this be picked up ?

Cheers,
Anders
Anders Roxell June 19, 2019, 7:57 a.m. | #3
On Wed, 19 Jun 2019 at 09:56, Anders Roxell <anders.roxell@linaro.org> wrote:
>

> On Thu, 10 Jan 2019 at 09:16, Thierry Reding <thierry.reding@gmail.com> wrote:

> >

> > On Tue, Jan 08, 2019 at 03:37:13PM +0100, Anders Roxell wrote:

> > > Without CONFIG_PM_SLEEP, we get annoying warnings about unused

> > > functions:

> > >

> > > drivers/mailbox/tegra-hsp.c:782:12: warning: ‘tegra_hsp_resume’ defined but not used [-Wunused-function]

> > >  static int tegra_hsp_resume(struct device *dev)

> > >             ^~~~~~~~~~~~~~~~

> > >

> > > Mark them as __maybe_unused to shut up the warning and silently drop the

> > > functions without having to add ugly #ifdefs.

> > >

> > > Fixes: 9a63f0f40599 ("mailbox: tegra-hsp: Add suspend/resume support")

> > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

> > > ---

> > >  drivers/mailbox/tegra-hsp.c | 2 +-

> > >  1 file changed, 1 insertion(+), 1 deletion(-)

> >

> > Acked-by: Thierry Reding <treding@nvidia.com>

>

> Will this be picked up ?


its already solved.

Sorry for the noice. =/

Anders

>

> Cheers,

> Anders

Patch

diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-hsp.c
index e443f6a2ec4b..b9ce823f79ab 100644
--- a/drivers/mailbox/tegra-hsp.c
+++ b/drivers/mailbox/tegra-hsp.c
@@ -779,7 +779,7 @@  static int tegra_hsp_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int tegra_hsp_resume(struct device *dev)
+static __maybe_unused int tegra_hsp_resume(struct device *dev)
 {
 	struct tegra_hsp *hsp = dev_get_drvdata(dev);
 	unsigned int i;