From patchwork Tue Jan 8 16:29:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 154998 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp5072614jaa; Tue, 8 Jan 2019 08:32:32 -0800 (PST) X-Google-Smtp-Source: ALg8bN7LSYIz/hpEktiLv5XMJBcmuHX9cOHTcA46mwuhOAUeEBBE0PTedZTvAUWQbnSIiwRdVAFm X-Received: by 2002:a17:902:bf44:: with SMTP id u4mr2433621pls.5.1546965152066; Tue, 08 Jan 2019 08:32:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546965152; cv=none; d=google.com; s=arc-20160816; b=oW9zkQc02boVslC+iXCGc47+YH+3BoebfspgrvV4lEDflkDV4tfhzVxHfCyOrJkucA MIb1K9dFvsxe1oAQKJqjlUri6GcsR9wmARBe8vDiHZIV+vC+zHtizm8R+gWexC1VOCCL 5j5aBh5+Md2P8942c2WrNpvECwBfoTVysD7uQFqSUUZVJZT9md8QEBdfiUozBk1sY2GT jkfqHNm4yP1eMXO1m18uxJY/Jm4cwlJZxzz0aKiuSHIqB7s8P598/UZ37NqDlYFemQ+R vQn/EgfvD8jxZZIv7UfWbddaAAA1YtxWa+vJCILPlpE7TPiW0F0KQFxg5O3RubHhJ2dL hQdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NQ7Kqa4saE2CRJVGge0eDVg21X9XPCE13iXA966wHT8=; b=mzzL0enZcpq1Vq7iMeilIoCM3KUOK4qc6XSsCLhEOTGa0nID1VuAyVU2dLxQNFVPV/ yq5i2xiGK/jEnLmhgIGV1gOkGSFL67Lveu311KxS6oEqg0zVEe3RgdKreQy+RWoo2CMF 9YP7di0cWoJai+k7bvt9Hv3bBlZX9qaRNTwdqJlwHXxVX1v16NI+ylksJZ+SUXRCug7J DDXQIhEsQO8TugyylprhfhRf3Qk6cnW8i18Dp7Wfe4UNT9OPDrcCOvDxjxi7I4qRIkwl 5abyXy2Hdh8czfrxg5T7M3Vi08M8bUvpXTfBj4XfxPgX6OYGvtTjlsX1lFWz906GWU87 EXmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Evs7m7rT; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d13si11388024pgu.40.2019.01.08.08.32.31; Tue, 08 Jan 2019 08:32:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Evs7m7rT; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729695AbfAHQca (ORCPT + 10 others); Tue, 8 Jan 2019 11:32:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:40036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729683AbfAHQc3 (ORCPT ); Tue, 8 Jan 2019 11:32:29 -0500 Received: from localhost.localdomain (unknown [171.76.109.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7161620827; Tue, 8 Jan 2019 16:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546965148; bh=hJBdDaIkVQ96WaiIuyIkj8YnYpzlU8oVZTUe42xDvQE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Evs7m7rTz0f+ofwWmRg2gKrDjoreqTAQEUlG8s7KRpzxSaq4rxUMjNRysCfOWuHMj 5T0YFQkP1ateQGeTFOOijnnjohfFa0p+twfFWdBO/rohFSsuAB+Kkn5Ble4AhuPNmG mml7exYwi4/ikIZWuIYxrExkNRJlMfwkkrsWlfGo= From: Vinod Koul To: David S Miller Cc: netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Niklas Cassel , Bjorn Andersson , Vinod Koul , Andrew Lunn , Florian Fainelli Subject: [PATCH v2 5/5] net: dsa: qca8k: disable delay for RGMII mode Date: Tue, 8 Jan 2019 21:59:26 +0530 Message-Id: <20190108162926.17806-6-vkoul@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190108162926.17806-1-vkoul@kernel.org> References: <20190108162926.17806-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In RGMII mode we should not have any delay in phy, so disable the delay. Signed-off-by: Vinod Koul --- drivers/net/dsa/qca8k.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) -- 2.20.1 diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 7e97e620bd44..a4b6cda38016 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -420,7 +420,7 @@ qca8k_mib_init(struct qca8k_priv *priv) static int qca8k_set_pad_ctrl(struct qca8k_priv *priv, int port, int mode) { - u32 reg; + u32 reg, val; switch (port) { case 0: @@ -439,17 +439,9 @@ qca8k_set_pad_ctrl(struct qca8k_priv *priv, int port, int mode) */ switch (mode) { case PHY_INTERFACE_MODE_RGMII: - qca8k_write(priv, reg, - QCA8K_PORT_PAD_RGMII_EN | - QCA8K_PORT_PAD_RGMII_TX_DELAY(3) | - QCA8K_PORT_PAD_RGMII_RX_DELAY(3)); - - /* According to the datasheet, RGMII delay is enabled through - * PORT5_PAD_CTRL for all ports, rather than individual port - * registers - */ - qca8k_write(priv, QCA8K_REG_PORT5_PAD_CTRL, - QCA8K_PORT_PAD_RGMII_RX_DELAY_EN); + /* RGMII mode means no delay so don't enable the delay */ + val = QCA8K_PORT_PAD_RGMII_EN; + qca8k_write(priv, reg, val); break; case PHY_INTERFACE_MODE_SGMII: qca8k_write(priv, reg, QCA8K_PORT_PAD_SGMII_EN);