[v2,2/7] remoteproc: fix rproc_da_to_va in case of unallocated carveout

Message ID 1547128151-44077-3-git-send-email-loic.pallardy@st.com
State Accepted
Commit 74457c40f97a98142bb13153395d304ad3c85cdd
Headers show
  • remoteproc: Fixes for memoy carveout management
Related show

Commit Message

Loic Pallardy Jan. 10, 2019, 1:49 p.m.
With introduction of rproc_alloc_registered_carveouts() which
delays carveout allocation just before the start of the remote
processor, rproc_da_to_va() could be called before all carveouts
are allocated.
This patch adds a check in rproc_da_to_va() to return NULL if
carveout is not allocated.

Fixes: d7c51706d095 ("remoteproc: add alloc ops in rproc_mem_entry struct")

Signed-off-by: Loic Pallardy <loic.pallardy@st.com>

 drivers/remoteproc/remoteproc_core.c | 4 ++++
 1 file changed, 4 insertions(+)



diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index c1a66e25b173..28df71cb3fef 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -204,6 +204,10 @@  void *rproc_da_to_va(struct rproc *rproc, u64 da, int len)
 	list_for_each_entry(carveout, &rproc->carveouts, node) {
 		int offset = da - carveout->da;
+		/*  Verify that carveout is allocated */
+		if (!carveout->va)
+			continue;
 		/* try next carveout if da is too small */
 		if (offset < 0)