From patchwork Fri Jan 11 09:18:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 155310 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp347882jaa; Fri, 11 Jan 2019 01:18:54 -0800 (PST) X-Google-Smtp-Source: ALg8bN7a3X7c9zA5UqsLT7hmgVt8dqNh5lJnQMvhfUr+S/8ARc/IuhOmCN40ZGwsZX6Quf7T4Mlt X-Received: by 2002:a63:f109:: with SMTP id f9mr2540794pgi.286.1547198334208; Fri, 11 Jan 2019 01:18:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547198334; cv=none; d=google.com; s=arc-20160816; b=ARlIGbQna/o23BWwbJCdnaKBnGT/pUuf30q33RXPteHhnyNPJQNG/aJgOCkrwaPQTw 9TrkoRqFR3CD27CXvOOkVBCeQFcFygQzysMl4YkGQTYBTDHH5lo2mHVngHMWFH97s7oh RXzCb+5pSUafbcKJ8f8rOd012pqjkw2hcix7ckHa8zsil7wKi7oasZ8Xl3TyNsAH/0Bz FHEKX4tFaX7RmvTNJqB1e37uzG4RWNndbHv2002qM5KovLHi79mhNg8mzAw/q/pkfgjr h3tKeCly3/ZEUa5Pe0AELbERjKdjez/sJKOzLu/H+UySdttcvvBSsJwsvKm+wXmaMLUK fyDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=j+6233nv3v674fm7wJsKedOHZKQamoc11CkEUfZqX4M=; b=l/tdsCgflBQRyJ8WPCDgRLeo/h/KCfiQTIUSOgmWgjo/wxYt6dj0zKQywyG7ZLcWSp /7FwUuZvfYuyuJUe6PLQ52XRL+WHHPbLQrngxfWI74MVzF1BNVo1QKlTLcGXHZtdNPHo KOBxASX0LLJaYj1IZTduAvFDXxw/yOtnOjsxHK5nkRiJNSt7okurvQofgYb92CPWwd6b 6iaj8qS/XSG70Pj4yo1oOfUgAtb8ubixiaryaqau+cSnhQFg7hH49Csq0S+M/XnrLuBC 9Atv0sae5X0FREwYbggEKdOm5wuGKS9VuoPq7dzywmIl2nATnvM14dJ+fzj/1JGHJPVe 1BNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FwbyUPAU; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ce11si24501110plb.420.2019.01.11.01.18.53; Fri, 11 Jan 2019 01:18:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FwbyUPAU; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731472AbfAKJSw (ORCPT + 11 others); Fri, 11 Jan 2019 04:18:52 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:42717 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731454AbfAKJSv (ORCPT ); Fri, 11 Jan 2019 04:18:51 -0500 Received: by mail-pf1-f196.google.com with SMTP id 64so6681685pfr.9 for ; Fri, 11 Jan 2019 01:18:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j+6233nv3v674fm7wJsKedOHZKQamoc11CkEUfZqX4M=; b=FwbyUPAUmpqC61yhz0XF4E2qHvR6Cdtuq/oGJ6LEvdual17YNidGP089pNN1OcdGhB K05rSCSYooEGkbYa2eWcYEC4of3smANzkOk9dYUA39f0+kWNsLPoBn5TzATaGfBnDcQ5 2opZHEx2LKv75FUC2Th8/jZWQHps3KQfSci3E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j+6233nv3v674fm7wJsKedOHZKQamoc11CkEUfZqX4M=; b=Lm7TQSLKcXSDpPjyl588FL+7px/ThBwAO5xmOXhDjj3rirYSY5nOrQFQsFXUM9v/9B rxfrX2ho5XC3vDRR7cm3PgV0J/s0J6UmW7vo5qE4emzY92JPHIcaa8d+yhLSO5kRS1D/ nSNsV2+jerWSgYiAA/0YUF9k/Vitjl3xCnSpioF+w05Y7Uaibr7SRubenXxFlQS4IBm+ T9slk8J+iUnrwvlcgU2zVX0zng6osYPtkDHduKfuq5MZ30PoCt4sdKYkgtQlTk4tpSm/ BYNy8ulGRDx3DrxmShAHgnGD7LxxSrytfq1zzr8fDbGXKiFKN2PHvMXKxDfp7vR1n2mm zLng== X-Gm-Message-State: AJcUukekFDTepQR8RT6v83fd5g03LIuIgdNGQl9pZE+8Of4Na5XBPVq6 jv1BS9mqatMtr8gUiP5LneXiXA== X-Received: by 2002:a63:86c1:: with SMTP id x184mr10318302pgd.305.1547198330528; Fri, 11 Jan 2019 01:18:50 -0800 (PST) Received: from localhost ([122.172.34.203]) by smtp.gmail.com with ESMTPSA id h134sm158868104pfe.27.2019.01.11.01.18.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Jan 2019 01:18:49 -0800 (PST) From: Viresh Kumar To: Rafael Wysocki , Greg Kroah-Hartman Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , mka@chromium.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] cpufreq: Implement freq-constraint callback Date: Fri, 11 Jan 2019 14:48:35 +0530 Message-Id: X-Mailer: git-send-email 2.20.1.321.g9e740568ce00 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org This implements the frequency constraint callback and registers it with the freq-constraint framework whenever a policy is created. On policy removal the callback is unregistered. The constraints are also taken into consideration in cpufreq_set_policy(). No constraints are added until now though. Signed-off-by: Viresh Kumar --- drivers/cpufreq/Kconfig | 1 + drivers/cpufreq/cpufreq.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+) -- 2.7.4 diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig index 608af20a3494..2c2842cf2734 100644 --- a/drivers/cpufreq/Kconfig +++ b/drivers/cpufreq/Kconfig @@ -2,6 +2,7 @@ menu "CPU Frequency scaling" config CPU_FREQ bool "CPU Frequency scaling" + select DEVICE_FREQ_CONSTRAINT select SRCU help CPU Frequency scaling allows you to change the clock speed of diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index a8fa684f5f90..63028612d011 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include #include @@ -1163,6 +1164,7 @@ static void cpufreq_policy_free(struct cpufreq_policy *policy) per_cpu(cpufreq_cpu_data, cpu) = NULL; write_unlock_irqrestore(&cpufreq_driver_lock, flags); + freq_constraint_remove_cpumask_callback(policy->related_cpus); cpufreq_policy_put_kobj(policy); free_cpumask_var(policy->real_cpus); free_cpumask_var(policy->related_cpus); @@ -1170,6 +1172,24 @@ static void cpufreq_policy_free(struct cpufreq_policy *policy) kfree(policy); } +static void freq_constraint_callback(void *param) +{ + struct cpufreq_policy *policy = param; + struct cpufreq_policy new_policy = *policy; + + new_policy.min = policy->user_policy.min; + new_policy.max = policy->user_policy.max; + + down_write(&policy->rwsem); + if (policy_is_inactive(policy)) + goto unlock; + + cpufreq_set_policy(policy, &new_policy); + +unlock: + up_write(&policy->rwsem); +} + static int cpufreq_online(unsigned int cpu) { struct cpufreq_policy *policy; @@ -1236,6 +1256,14 @@ static int cpufreq_online(unsigned int cpu) per_cpu(cpufreq_cpu_data, j) = policy; add_cpu_dev_symlink(policy, j); } + + ret = freq_constraint_set_cpumask_callback(policy->related_cpus, + freq_constraint_callback, policy); + if (ret) { + pr_err("Failed to set freq-constraints: %d (%*pbl)\n", + ret, cpumask_pr_args(policy->cpus)); + goto out_destroy_policy; + } } else { policy->min = policy->user_policy.min; policy->max = policy->user_policy.max; @@ -2198,6 +2226,8 @@ static int cpufreq_set_policy(struct cpufreq_policy *policy, struct cpufreq_policy *new_policy) { struct cpufreq_governor *old_gov; + struct device *cpu_dev = get_cpu_device(policy->cpu); + unsigned long fc_min, fc_max; int ret; pr_debug("setting new policy for CPU %u: %u - %u kHz\n", @@ -2217,6 +2247,20 @@ static int cpufreq_set_policy(struct cpufreq_policy *policy, if (ret) return ret; + ret = freq_constraints_get(cpu_dev, &fc_min, &fc_max); + if (ret) { + dev_err(cpu_dev, "cpufreq: Failed to get freq-constraints\n"); + } else { + if (fc_min > new_policy->min) + new_policy->min = fc_min; + if (fc_max < new_policy->max) + new_policy->max = fc_max; + } + + /* + * The notifier-chain shall be removed once all the users of + * CPUFREQ_ADJUST are moved to use the freq-constraints. + */ /* adjust if necessary - all reasons */ blocking_notifier_call_chain(&cpufreq_policy_notifier_list, CPUFREQ_ADJUST, new_policy);