ARM: bcm283x: Fix definition of MBOX_TAG_TEST_PIXEL_ORDER

Message ID
State New
Headers show
  • ARM: bcm283x: Fix definition of MBOX_TAG_TEST_PIXEL_ORDER
Related show

Commit Message

Alexander Graf Jan. 13, 2019, 7:30 p.m.
From: Berkus Decker <>

The MBOX_TAG_TEST_PIXEL_ORDER define is incorrect. According to official
documentation it has a slightly different numbering.

Correct mailbox constants are defined in e.g.
linux raspberry-firmware

These are obtained from the bcm2835 documentation

Fix the define to get us back in sync with the spec.

Signed-off-by: Berkus Decker <>
[agraf: clarify subject, extend commit message]
Signed-off-by: Alexander Graf <>
 arch/arm/mach-bcm283x/include/mach/mbox.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/arch/arm/mach-bcm283x/include/mach/mbox.h b/arch/arm/mach-bcm283x/include/mach/mbox.h
index 2776a396c7..e3a893e49c 100644
--- a/arch/arm/mach-bcm283x/include/mach/mbox.h
+++ b/arch/arm/mach-bcm283x/include/mach/mbox.h
@@ -348,7 +348,7 @@  struct bcm2835_mbox_tag_depth {
 #define BCM2835_MBOX_TAG_GET_PIXEL_ORDER	0x00040006
-#define BCM2835_MBOX_TAG_TEST_PIXEL_ORDER	0x00044005
+#define BCM2835_MBOX_TAG_TEST_PIXEL_ORDER	0x00044006
 #define BCM2835_MBOX_TAG_SET_PIXEL_ORDER	0x00048006
 #define BCM2835_MBOX_PIXEL_ORDER_BGR		0