[edk2,edk2-platforms] Platform/Intel/MinPlatformPkg: add MmServicesTableLib resolution

Message ID 20190114172441.11036-1-ard.biesheuvel@linaro.org
State New
Headers show
Series
  • [edk2,edk2-platforms] Platform/Intel/MinPlatformPkg: add MmServicesTableLib resolution
Related show

Commit Message

Ard Biesheuvel Jan. 14, 2019, 5:24 p.m.
Ensure that the platform will still build when we move the upstream
FTW and variable SMM runtime drivers to use the new MmServiceTableLib
library class.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc | 1 +
 1 file changed, 1 insertion(+)

-- 
2.17.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Gao, Liming Jan. 16, 2019, 2:57 p.m. | #1
Reviewed-by: Liming Gao <liming.gao@intel.com>


> -----Original Message-----

> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> Sent: Tuesday, January 15, 2019 1:25 AM

> To: edk2-devel@lists.01.org

> Cc: Gao, Liming <liming.gao@intel.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>

> Subject: [PATCH edk2-platforms] Platform/Intel/MinPlatformPkg: add MmServicesTableLib resolution

> 

> Ensure that the platform will still build when we move the upstream

> FTW and variable SMM runtime drivers to use the new MmServiceTableLib

> library class.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc

> index 1103572408d0..1ed3591f360a 100644

> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc

> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc

> @@ -77,6 +77,7 @@ [LibraryClasses.common.UEFI_DRIVER]

>  [LibraryClasses.common.DXE_SMM_DRIVER]

>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf

>    SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf

> +  MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf

>    ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/SmmReportStatusCodeLib.inf

>    MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemoryAllocationLib.inf

>    LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxSmmLib.inf

> --

> 2.17.1


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Yao, Jiewen Jan. 16, 2019, 4:05 p.m. | #2
Reviewed-by: Jiewen.yao@intel.com



> -----Original Message-----

> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of

> Gao, Liming

> Sent: Wednesday, January 16, 2019 6:57 AM

> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; edk2-devel@lists.01.org

> Subject: Re: [edk2] [PATCH edk2-platforms] Platform/Intel/MinPlatformPkg:

> add MmServicesTableLib resolution

> 

> Reviewed-by: Liming Gao <liming.gao@intel.com>

> 

> > -----Original Message-----

> > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> > Sent: Tuesday, January 15, 2019 1:25 AM

> > To: edk2-devel@lists.01.org

> > Cc: Gao, Liming <liming.gao@intel.com>; Ard Biesheuvel

> <ard.biesheuvel@linaro.org>

> > Subject: [PATCH edk2-platforms] Platform/Intel/MinPlatformPkg: add

> MmServicesTableLib resolution

> >

> > Ensure that the platform will still build when we move the upstream

> > FTW and variable SMM runtime drivers to use the new MmServiceTableLib

> > library class.

> >

> > Contributed-under: TianoCore Contribution Agreement 1.1

> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> > ---

> >  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc | 1 +

> >  1 file changed, 1 insertion(+)

> >

> > diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc

> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc

> > index 1103572408d0..1ed3591f360a 100644

> > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc

> > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc

> > @@ -77,6 +77,7 @@ [LibraryClasses.common.UEFI_DRIVER]

> >  [LibraryClasses.common.DXE_SMM_DRIVER]

> >    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf

> >

> SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesT

> ableLib.inf

> > +

> MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTabl

> eLib.inf

> >

> ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/Sm

> mReportStatusCodeLib.inf

> >

> MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMe

> moryAllocationLib.inf

> >

> LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxSmmLib.i

> nf

> > --

> > 2.17.1

> 

> _______________________________________________

> edk2-devel mailing list

> edk2-devel@lists.01.org

> https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Jan. 16, 2019, 4:46 p.m. | #3
On Wed, 16 Jan 2019 at 17:05, Yao, Jiewen <jiewen.yao@intel.com> wrote:
>

> Reviewed-by: Jiewen.yao@intel.com

>

>

> > -----Original Message-----

> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of

> > Gao, Liming

> > Sent: Wednesday, January 16, 2019 6:57 AM

> > To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; edk2-devel@lists.01.org

> > Subject: Re: [edk2] [PATCH edk2-platforms] Platform/Intel/MinPlatformPkg:

> > add MmServicesTableLib resolution

> >

> > Reviewed-by: Liming Gao <liming.gao@intel.com>

> >


Thanks all

Pushed as cc0bd1afbc09..9da76451349e


> > > -----Original Message-----

> > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> > > Sent: Tuesday, January 15, 2019 1:25 AM

> > > To: edk2-devel@lists.01.org

> > > Cc: Gao, Liming <liming.gao@intel.com>; Ard Biesheuvel

> > <ard.biesheuvel@linaro.org>

> > > Subject: [PATCH edk2-platforms] Platform/Intel/MinPlatformPkg: add

> > MmServicesTableLib resolution

> > >

> > > Ensure that the platform will still build when we move the upstream

> > > FTW and variable SMM runtime drivers to use the new MmServiceTableLib

> > > library class.

> > >

> > > Contributed-under: TianoCore Contribution Agreement 1.1

> > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> > > ---

> > >  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc | 1 +

> > >  1 file changed, 1 insertion(+)

> > >

> > > diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc

> > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc

> > > index 1103572408d0..1ed3591f360a 100644

> > > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc

> > > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc

> > > @@ -77,6 +77,7 @@ [LibraryClasses.common.UEFI_DRIVER]

> > >  [LibraryClasses.common.DXE_SMM_DRIVER]

> > >    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf

> > >

> > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesT

> > ableLib.inf

> > > +

> > MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTabl

> > eLib.inf

> > >

> > ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/Sm

> > mReportStatusCodeLib.inf

> > >

> > MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMe

> > moryAllocationLib.inf

> > >

> > LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxSmmLib.i

> > nf

> > > --

> > > 2.17.1

> >

> > _______________________________________________

> > edk2-devel mailing list

> > edk2-devel@lists.01.org

> > https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
index 1103572408d0..1ed3591f360a 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
@@ -77,6 +77,7 @@  [LibraryClasses.common.UEFI_DRIVER]
 [LibraryClasses.common.DXE_SMM_DRIVER]
   PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
   SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf
+  MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf
   ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/SmmReportStatusCodeLib.inf
   MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemoryAllocationLib.inf
   LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxSmmLib.inf