[v1,1/1] arm64: dt: poplar: add optee node

Message ID 1547735860-5298-1-git-send-email-igor.opaniuk@linaro.org
State Accepted
Commit 246fb9dd9c12f365bf3041547f2c4894dad4f1ab
Headers show
Series
  • [v1,1/1] arm64: dt: poplar: add optee node
Related show

Commit Message

Igor Opaniuk Jan. 17, 2019, 2:37 p.m.
As Poplar supports running TF-A with OP-TEE as BL32
payload, add op-tee node in DT, which enables usage of
OP-TEE driver (which provides an interface for requesting services
from OP-TEE).

Signed-off-by: Igor Opaniuk <igor.opaniuk@linaro.org>
---
 arch/arm/dts/hi3798cv200-poplar.dts | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Shawn Guo Jan. 18, 2019, 1:02 a.m. | #1
Hi Igor,

On Thu, Jan 17, 2019 at 04:37:40PM +0200, Igor Opaniuk wrote:
> As Poplar supports running TF-A with OP-TEE as BL32
> payload, add op-tee node in DT, which enables usage of
> OP-TEE driver (which provides an interface for requesting services
> from OP-TEE).
> 
> Signed-off-by: Igor Opaniuk <igor.opaniuk@linaro.org>

I'm fine with the change.  But rather than pushing changes to u-boot,
can you please push it to kernel repository, which is the DTS upstream
right now?  We sync DTS changes from kernel when needed, and only
maintains u-boot specific changes in hi3798cv200-u-boot.dtsi.

Shawn

> ---
>  arch/arm/dts/hi3798cv200-poplar.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/dts/hi3798cv200-poplar.dts b/arch/arm/dts/hi3798cv200-poplar.dts
> index 964326e..6bc2a23 100644
> --- a/arch/arm/dts/hi3798cv200-poplar.dts
> +++ b/arch/arm/dts/hi3798cv200-poplar.dts
> @@ -28,6 +28,13 @@
>  		reg = <0x0 0x0 0x0 0x80000000>;
>  	};
>  
> +	firmware {
> +		optee {
> +			compatible = "linaro,optee-tz";
> +			method = "smc";
> +		};
> +	};
> +
>  	leds {
>  		compatible = "gpio-leds";
>  
> -- 
> 2.7.4
>
Simon Glass Jan. 18, 2019, 5:38 p.m. | #2
On Thu, 17 Jan 2019 at 07:37, Igor Opaniuk <igor.opaniuk@linaro.org> wrote:
>
> As Poplar supports running TF-A with OP-TEE as BL32
> payload, add op-tee node in DT, which enables usage of
> OP-TEE driver (which provides an interface for requesting services
> from OP-TEE).
>
> Signed-off-by: Igor Opaniuk <igor.opaniuk@linaro.org>
> ---
>  arch/arm/dts/hi3798cv200-poplar.dts | 7 +++++++
>  1 file changed, 7 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

Patch

diff --git a/arch/arm/dts/hi3798cv200-poplar.dts b/arch/arm/dts/hi3798cv200-poplar.dts
index 964326e..6bc2a23 100644
--- a/arch/arm/dts/hi3798cv200-poplar.dts
+++ b/arch/arm/dts/hi3798cv200-poplar.dts
@@ -28,6 +28,13 @@ 
 		reg = <0x0 0x0 0x0 0x80000000>;
 	};
 
+	firmware {
+		optee {
+			compatible = "linaro,optee-tz";
+			method = "smc";
+		};
+	};
+
 	leds {
 		compatible = "gpio-leds";