From patchwork Thu Jan 17 17:44:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 155858 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp2247499jaa; Thu, 17 Jan 2019 09:44:26 -0800 (PST) X-Google-Smtp-Source: ALg8bN6y736SScrXXuyesKnStCh3uVuMO03kQdhb+Ocrx+v9q9EZHhqwvUI7gPmzO2Ji68sLq+RB X-Received: by 2002:a63:af52:: with SMTP id s18mr14300561pgo.385.1547747065983; Thu, 17 Jan 2019 09:44:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547747065; cv=none; d=google.com; s=arc-20160816; b=h7rXPEkKl1wNjyRMZRuK5RLU7Jnf+dOhFYyCrTMf0kKJPs0hxuwx4cwI/C78A/PnpV XQXtJyM1mXb64fK+/eEfQkWL3QSe0igZxvBQU7uXP+ePy9fYvzbekn+dLaSvRGTG6qER cZpWE/Tjr4ADp2vQcncshYbX2Qzdvt7+Ag96VxZLObd4zLzinyj2hGT0vYU/4rfIoDzn bqiWeDkMQAjd9lbAwlUUqbhs/aVpnhTR2lFR90lxyTIy7lERRUzo9uKEsF8PnogijVHa /FsC1mblx/67eZ/mtotENmUlX/zftCnVl/oEXawjM5PnP26D5QlBSIlia+549jdzFrv7 Z34A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=uaMFbDW5vM+8+YXiAv83MSY7jn86Anovx+UGEgOqUgo=; b=IElOZpxWTsNKMn/k36cU0QW13voh26MMxyfFic9iqoLuXQ3qfAeXIfcFL0VuxfNZgV J/5ghk+n6yvxtq13qFKuR3gLEqLU2XlG1ERvzyhoGzg52sJ2+jDZQHPBF5TlFVRltmD8 WOacvKHX1ICTN7/RjVFxl4zS8p2K76OcSskWK2ZPnj3ZFNTFTnefWmflV1YzaUD1AUZl SmeilrFShJBpp8xrON57eQo3PhmisodQ4BHKtHqsuv30U9Lmx5JIToc7UMn3/qTL54Re gP04l3ZeX9xWetTpt5h/CDXTqmCyiJvRAuLwyDBjihDUROpUyL6eNHOTvevh/tms5h1y 2BWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eG96rQKc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c81si2261370pfc.82.2019.01.17.09.44.25; Thu, 17 Jan 2019 09:44:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eG96rQKc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729425AbfAQRoZ (ORCPT + 21 others); Thu, 17 Jan 2019 12:44:25 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:38393 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727488AbfAQRoT (ORCPT ); Thu, 17 Jan 2019 12:44:19 -0500 Received: by mail-wr1-f66.google.com with SMTP id v13so11995935wrw.5 for ; Thu, 17 Jan 2019 09:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uaMFbDW5vM+8+YXiAv83MSY7jn86Anovx+UGEgOqUgo=; b=eG96rQKcFDARA+T56ZPel3qPYMvZY17GJQHiufMe2UrmJUbvHXxyYWuuA0odZAKgRU a/NuFZ5N7FUeQoqaCioqPiSPOkSS9/ATjS4+C2cZsSOSaY6VUU6dqwxo8EzPhNheMPdW QSPEoNOIceDz4tuuJsoIzmL1B5CGfFAtlHVxk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uaMFbDW5vM+8+YXiAv83MSY7jn86Anovx+UGEgOqUgo=; b=TwRyd50xTBM46gGo60jv3ygvmWDCrcQc2eXjBVPqV5anvgwaY9WxBoQa3WkN9A6SF5 hchCd2d/RzcXCy1p3hKFWAKxFC3PPJKyDtC1Sz5qBMBBRbwTxsQDCTxkzbBcTvAVD730 CWldk9tBZVnt/QpVtb32LPvyvgE1zLXAdRyxhzzqSt5hzThk2Kc4gstpVORZWTEPLY3x BB90i0lgwW3F/LROP3i4dWQ0HSHmVRnKwhByEVNF1MqBrhFboJlHEXIi501/zPLxY6Fk TvjBnnGvc1oTTYW1E4mOHc695AuBQHLph7uL+0fGvo/aBp/8CSvFHG0EyAyh8FRr70ls Rdaw== X-Gm-Message-State: AJcUukcbvtjRe5aeuV5hEDnVh4qsRGVmKTsE2L8FCRgTmnhD+9p45lEq kFfk9Ifk1m8YN8xmvoqgQBZuxqn2w2CP4A== X-Received: by 2002:a5d:6684:: with SMTP id l4mr14022779wru.154.1547747057358; Thu, 17 Jan 2019 09:44:17 -0800 (PST) Received: from localhost.localdomain ([2a01:e0a:f:6020:8435:96d6:e03:9e78]) by smtp.gmail.com with ESMTPSA id i186sm47583622wmd.19.2019.01.17.09.44.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Jan 2019 09:44:16 -0800 (PST) From: Vincent Guittot To: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org Cc: valentin.schneider@arm.com, Morten.Rasmussen@arm.com, Vincent Guittot Subject: [PATCH v4 2/3] sched/fair: trigger asym_packing during idle load balance Date: Thu, 17 Jan 2019 18:44:08 +0100 Message-Id: <1547747049-6320-3-git-send-email-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1547747049-6320-1-git-send-email-vincent.guittot@linaro.org> References: <1547747049-6320-1-git-send-email-vincent.guittot@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org newly idle load balance is not always triggered when a cpu becomes idle. This prevent the scheduler to get a chance to migrate task for asym packing. Enable active migration because of asym packing during idle load balance too. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 1e4bed4..bd3b0ac 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8853,7 +8853,7 @@ static int need_active_balance(struct lb_env *env) { struct sched_domain *sd = env->sd; - if (env->idle == CPU_NEWLY_IDLE) { + if (env->idle != CPU_NOT_IDLE) { /* * ASYM_PACKING needs to force migrate tasks from busy but