rtc: s3c: Use generic helper to get driver data

Message ID 20190118132837.15713-1-m.szyprowski@samsung.com
State New
Headers show
Series
  • rtc: s3c: Use generic helper to get driver data
Related show

Commit Message

Marek Szyprowski Jan. 18, 2019, 1:28 p.m.
Replace of_match_node() with of_device_get_match_data(), which removes a
few lines of code from the driver.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

---
 drivers/rtc/rtc-s3c.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

-- 
2.17.1

Comments

Krzysztof Kozlowski Jan. 19, 2019, 7:40 p.m. | #1
On Fri, Jan 18, 2019 at 02:28:37PM +0100, Marek Szyprowski wrote:
> Replace of_match_node() with of_device_get_match_data(), which removes a

> few lines of code from the driver.

> 

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---

>  drivers/rtc/rtc-s3c.c | 13 ++-----------


Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>


Best regards,
Krzysztof
Alexandre Belloni Jan. 22, 2019, 5:36 p.m. | #2
On 18/01/2019 14:28:37+0100, Marek Szyprowski wrote:
> Replace of_match_node() with of_device_get_match_data(), which removes a

> few lines of code from the driver.

> 

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---

>  drivers/rtc/rtc-s3c.c | 13 ++-----------

>  1 file changed, 2 insertions(+), 11 deletions(-)

> 

Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Patch

diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index e682977b4f6e..2904b872db88 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -26,6 +26,7 @@ 
 #include <linux/log2.h>
 #include <linux/slab.h>
 #include <linux/of.h>
+#include <linux/of_device.h>
 #include <linux/uaccess.h>
 #include <linux/io.h>
 
@@ -443,16 +444,6 @@  static int s3c_rtc_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static const struct of_device_id s3c_rtc_dt_match[];
-
-static const struct s3c_rtc_data *s3c_rtc_get_data(struct platform_device *pdev)
-{
-	const struct of_device_id *match;
-
-	match = of_match_node(s3c_rtc_dt_match, pdev->dev.of_node);
-	return match->data;
-}
-
 static int s3c_rtc_probe(struct platform_device *pdev)
 {
 	struct s3c_rtc *info = NULL;
@@ -472,7 +463,7 @@  static int s3c_rtc_probe(struct platform_device *pdev)
 	}
 
 	info->dev = &pdev->dev;
-	info->data = s3c_rtc_get_data(pdev);
+	info->data = of_device_get_match_data(&pdev->dev);
 	if (!info->data) {
 		dev_err(&pdev->dev, "failed getting s3c_rtc_data\n");
 		return -EINVAL;