| Message ID | 20190121171543.32422-2-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | vmbuild tweaks for BSD targets | expand |
On 1/21/19 6:15 PM, Alex Bennée wrote: > The "make check" target calls check-qtest which has the appropriate > system binaries as dependencies so we shouldn't need to do two steps > of make invocation. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > tests/vm/freebsd | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/vm/freebsd b/tests/vm/freebsd > index 19a3729172..a85c866c30 100755 > --- a/tests/vm/freebsd > +++ b/tests/vm/freebsd > @@ -25,7 +25,6 @@ class FreeBSDVM(basevm.BaseVM): > cd $(mktemp -d /var/tmp/qemu-test.XXXXXX); > tar -xf /dev/vtbd1; > ./configure {configure_opts}; > - gmake --output-sync -j{jobs} {verbose}; > gmake --output-sync -j{jobs} check {verbose}; > """ > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On Mon, Jan 21, 2019 at 11:53 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > On 1/21/19 6:15 PM, Alex Bennée wrote: > > The "make check" target calls check-qtest which has the appropriate > > system binaries as dependencies so we shouldn't need to do two steps > > of make invocation. Now I remember, this was necessary to do this in 2 steps before ebb61f804d6, build threaded and test not threaded. Maybe worth adding a comment referencing this commit? > > > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > > --- > > tests/vm/freebsd | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/tests/vm/freebsd b/tests/vm/freebsd > > index 19a3729172..a85c866c30 100755 > > --- a/tests/vm/freebsd > > +++ b/tests/vm/freebsd > > @@ -25,7 +25,6 @@ class FreeBSDVM(basevm.BaseVM): > > cd $(mktemp -d /var/tmp/qemu-test.XXXXXX); > > tar -xf /dev/vtbd1; > > ./configure {configure_opts}; > > - gmake --output-sync -j{jobs} {verbose}; > > gmake --output-sync -j{jobs} check {verbose}; > > """ > > > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> >
diff --git a/tests/vm/freebsd b/tests/vm/freebsd index 19a3729172..a85c866c30 100755 --- a/tests/vm/freebsd +++ b/tests/vm/freebsd @@ -25,7 +25,6 @@ class FreeBSDVM(basevm.BaseVM): cd $(mktemp -d /var/tmp/qemu-test.XXXXXX); tar -xf /dev/vtbd1; ./configure {configure_opts}; - gmake --output-sync -j{jobs} {verbose}; gmake --output-sync -j{jobs} check {verbose}; """
The "make check" target calls check-qtest which has the appropriate system binaries as dependencies so we shouldn't need to do two steps of make invocation. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- tests/vm/freebsd | 1 - 1 file changed, 1 deletion(-) -- 2.17.1