| Message ID | 31eaef0e389c7a33846a473fcf6b0676961b530a.1548278585.git.crobinso@redhat.com |
|---|---|
| State | Accepted |
| Commit | 5ac9889a696cac33c945243cb78e263c4f91f1e7 |
| Headers | show |
| Series | qemu: virtio-{non-}transitional support | expand |
On Wed, 2019-01-23 at 16:32 -0500, Cole Robinson wrote: > The vhost-scsi device string should depend on the requested > address type, not strictly on the emulated arch. This is the > same logic used by qemuBuildVirtioDevStr, and this particular > path is already tested in the hostdev-scsi-vhost-scsi-ccw tests > > Signed-off-by: Cole Robinson <crobinso@redhat.com> > --- > src/qemu/qemu_command.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index bbc85e75f0..a1d991cefc 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4925,7 +4925,7 @@ qemuBuildSCSIVHostHostdevDevStr(const virDomainDef *def, goto cleanup; } - if (ARCH_IS_S390(def->os.arch)) + if (dev->info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) virBufferAddLit(&buf, "vhost-scsi-ccw"); else virBufferAddLit(&buf, "vhost-scsi-pci");
The vhost-scsi device string should depend on the requested address type, not strictly on the emulated arch. This is the same logic used by qemuBuildVirtioDevStr, and this particular path is already tested in the hostdev-scsi-vhost-scsi-ccw tests Signed-off-by: Cole Robinson <crobinso@redhat.com> --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list