From patchwork Fri Jan 25 23:26:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 156653 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp923923jaa; Fri, 25 Jan 2019 15:26:44 -0800 (PST) X-Google-Smtp-Source: ALg8bN7+F88xcS0MxLJnKpcCJ/9sAnegsjIk7FZz+OxCJJJei8yMyRqk3swGb3Uurck0sDhaVrK1 X-Received: by 2002:a65:434d:: with SMTP id k13mr11790781pgq.269.1548458804213; Fri, 25 Jan 2019 15:26:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548458804; cv=none; d=google.com; s=arc-20160816; b=MrBQqFWDPLRBxWj3GK5kL1d9hlJkPEiJQu/HGSC8WOCzQHb0CjEjqyKWh2+bevxy66 PCXwlcZKpWXocatsAJxKcT+I5lGFzGG0zsveLDAf9dN0UA4f8v2kuvHweXZTMmEre0T5 HTZk2bWA895XzDRDGpQY4eJ5bNRWSm8hc2hJ8mvkij0WWl9XBMGq7QdFsVMv5pI5qtwO OfqzhqLqml95ZJOvOZBjBrwOeosUlWWJS3P/07HO0yv6KGxLYxR6498iKQtpTSu/FsM2 4hXsEV5Y5O+LDS25cnE89Xak2tm278+9J73TK05aIkrK1bClRG53wA95RFNHjv6I6Wwb DmXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=fUnzpkkKPd9BeYGxYL4u0M8CAGQFglMs7DV//KlK6OE=; b=NU1sveAjCp1m3ovG4Pi0GOJ9t22aHeDlNqx8/dEyrYYZV4q9e0CtEAeAMZzJU2Lqtt bmGiyPKsuNmhJT5/+EG2iAzeRutTj5eF4uKRE61D/tGU3xvvMXtMaPbrSYoe+WTa6frf vbsZjwt8LCUGXfF01+cK4mIycqBh0IqCES+fS91Yts4hNfL4IavkIv815XzGuOLYKInH Z47tWYwna3GzR8A9pEXjAnwe9G37UnWJNgjwRvI1CNLW18519GiwNGfoT0MatFqfN+x8 q6W7zBQ5qt3TOqHm6HKKvUWbh50BC9s0XzxMGHT6ZFWty0xbi6Wm+MYsR5PyWKfh0mwL tsEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GttiOvLI; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m3si5982832pld.331.2019.01.25.15.26.43; Fri, 25 Jan 2019 15:26:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GttiOvLI; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728104AbfAYX0n (ORCPT + 15 others); Fri, 25 Jan 2019 18:26:43 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:40689 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726262AbfAYX0n (ORCPT ); Fri, 25 Jan 2019 18:26:43 -0500 Received: by mail-pf1-f196.google.com with SMTP id i12so5417771pfo.7 for ; Fri, 25 Jan 2019 15:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=fUnzpkkKPd9BeYGxYL4u0M8CAGQFglMs7DV//KlK6OE=; b=GttiOvLIr7onsg9dwRLhZ7jAK9eHRevELHzImusdz/3ewHj1DFV8EAWMo7YYbd90+q hVr6muGPiZ6m2PkKo4ISbIe4hp0+Hm1Btg2BfzYhQZ/kKIp6MQCpPg8Q4o/iUkD3P0iV Rnd0E5PjJNQQuoo0VzEBXjRtyn/pffMOcD2M4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fUnzpkkKPd9BeYGxYL4u0M8CAGQFglMs7DV//KlK6OE=; b=UVHYFI5aXIlSfabFp/0lPQbEQdY9o3i1XtOFPMiFCnAxnRkiGCB8QZAGT9i/H/gHjj lEEXvTQjscz3EglyBzQMGy1cHVFsrRvT5mUUSOR6oaJ3ul9jpXMgatJxbgVsHHR/AitG q04awN9pAayvCzuUiqbWld1sgAqT/ZgyeKv3I8EYsS2r0sHqoT9dV/lT7sbwYduwUIOw 91QUdKjwdzduA8CLIVFOSLS7fgkrdMmRZbdqVV+A1+/XCqrv0RbtuJ2ROejG+Pac6xwr 4+mpDUMVg4muqf2bV/0K/cNArTtsKJ8SdLZZgxnrTaWUqyZt3+aCv4t2sIUMtQiAUWkc a/8Q== X-Gm-Message-State: AJcUukfTvkgsHDaThu8i1Ma/rYk1uvG30qbXefo1mEl7PD2oY/8bXAlg fIC4M06UdfcATV33gbuOjzCJ3Q== X-Received: by 2002:a62:a1a:: with SMTP id s26mr13008527pfi.31.1548458802427; Fri, 25 Jan 2019 15:26:42 -0800 (PST) Received: from localhost.localdomain (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id l70sm52910375pgd.20.2019.01.25.15.26.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Jan 2019 15:26:41 -0800 (PST) From: Bjorn Andersson To: Stanimir Varbanov , Lorenzo Pieralisi , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Khasim Syed Mohammed , Niklas Cassel , stable@vger.kernel.org Subject: [PATCH] PCI: qcom: Don't deassert reset GPIO during probe Date: Fri, 25 Jan 2019 15:26:16 -0800 Message-Id: <20190125232616.25714-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.18.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Acquiring the reset GPIO low means that reset is being deasserted, this is followed almost immediately with qcom_pcie_host_init() asserting it, initializing it and then finally deasserting it again, for the link to come up. Some PCIe devices requires a minimum time between the initial deassert and subsequent reset cycles. In a platform that boots with the reset GPIO asserted this requirement is being violated by this deassert/assert pulse. Acquiring the reset GPIO high will prevent this by matching the state to the subsequent asserted state. Cc: stable@vger.kernel.org Signed-off-by: Bjorn Andersson --- drivers/pci/controller/dwc/pcie-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.18.0 diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index d185ea5fe996..a7f703556790 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1228,7 +1228,7 @@ static int qcom_pcie_probe(struct platform_device *pdev) pcie->ops = of_device_get_match_data(dev); - pcie->reset = devm_gpiod_get_optional(dev, "perst", GPIOD_OUT_LOW); + pcie->reset = devm_gpiod_get_optional(dev, "perst", GPIOD_OUT_HIGH); if (IS_ERR(pcie->reset)) { ret = PTR_ERR(pcie->reset); goto err_pm_runtime_put;