[edk2,edk2-platforms,v1,03/16] Hisilicon/D06: Optimize SAS driver for reducing boot time

Message ID 20190201133436.10500-4-ming.huang@linaro.org
State Superseded
Headers show
Series
  • Fix issues and improve D0x
Related show

Commit Message

Ming Huang Feb. 1, 2019, 1:34 p.m.
SAS controller is always existed, so accessing SAS register don't
depend on PciBusDxe (pci enumeration).
Move the SAS module early in D06.fdf for dispatching SAS driver
early. This can avoid wait in BDS normally and reduce boot time.

This patch is relative with SasDriverDxe in edk2-non-osi.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <ming.huang@linaro.org>

---
 Platform/Hisilicon/D06/D06.fdf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.9.5

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Feb. 12, 2019, 3:12 p.m. | #1
On Fri, Feb 01, 2019 at 09:34:23PM +0800, Ming Huang wrote:
> SAS controller is always existed, so accessing SAS register don't

> depend on PciBusDxe (pci enumeration).

> Move the SAS module early in D06.fdf for dispatching SAS driver

> early. This can avoid wait in BDS normally and reduce boot time.

> 

> This patch is relative with SasDriverDxe in edk2-non-osi.


I think you are saying that this change is only valid after the
update to SasDriverDxe in edk2-non-osi has been applied?
Or does it mean that it only improves performance after that
edk2-non-osi patch has been applied?

Please be more explicit in the commit message.

Other than that. I'm OK with this patch.

/
    Leif

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ming Huang <ming.huang@linaro.org>

> ---

>  Platform/Hisilicon/D06/D06.fdf | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/Platform/Hisilicon/D06/D06.fdf b/Platform/Hisilicon/D06/D06.fdf

> index a937660a09e2..d495ad7f264c 100644

> --- a/Platform/Hisilicon/D06/D06.fdf

> +++ b/Platform/Hisilicon/D06/D06.fdf

> @@ -165,6 +165,7 @@ [FV.FvMain]

>    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>  

>    INF Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.inf

> +  INF Platform/Hisilicon/D06/Drivers/Sas/SasDxeDriver.inf

>    #

>    # PI DXE Drivers producing Architectural Protocols (EFI Services)

>    #

> @@ -296,7 +297,6 @@ [FV.FvMain]

>    #

>    INF Platform/Hisilicon/D06/Drivers/Sm750Dxe/UefiSmi.inf

>    INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf

> -  INF Platform/Hisilicon/D06/Drivers/Sas/SasDxeDriver.inf

>    INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf

>    INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf

>    INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf

> -- 

> 2.9.5

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ming Huang Feb. 13, 2019, 6:01 a.m. | #2
On 2/12/2019 11:12 PM, Leif Lindholm wrote:
> On Fri, Feb 01, 2019 at 09:34:23PM +0800, Ming Huang wrote:

>> SAS controller is always existed, so accessing SAS register don't

>> depend on PciBusDxe (pci enumeration).

>> Move the SAS module early in D06.fdf for dispatching SAS driver

>> early. This can avoid wait in BDS normally and reduce boot time.

>>

>> This patch is relative with SasDriverDxe in edk2-non-osi.

> 

> I think you are saying that this change is only valid after the

> update to SasDriverDxe in edk2-non-osi has been applied?

> Or does it mean that it only improves performance after that

> edk2-non-osi patch has been applied?


This change is only valid after the update to SasDriverDxe in
edk2-non-osi has been applied.

Thanks

> 

> Please be more explicit in the commit message.

> 

> Other than that. I'm OK with this patch.

> 

> /

>     Leif

> 

>> Contributed-under: TianoCore Contribution Agreement 1.1

>> Signed-off-by: Ming Huang <ming.huang@linaro.org>

>> ---

>>  Platform/Hisilicon/D06/D06.fdf | 2 +-

>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/Platform/Hisilicon/D06/D06.fdf b/Platform/Hisilicon/D06/D06.fdf

>> index a937660a09e2..d495ad7f264c 100644

>> --- a/Platform/Hisilicon/D06/D06.fdf

>> +++ b/Platform/Hisilicon/D06/D06.fdf

>> @@ -165,6 +165,7 @@ [FV.FvMain]

>>    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

>>  

>>    INF Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.inf

>> +  INF Platform/Hisilicon/D06/Drivers/Sas/SasDxeDriver.inf

>>    #

>>    # PI DXE Drivers producing Architectural Protocols (EFI Services)

>>    #

>> @@ -296,7 +297,6 @@ [FV.FvMain]

>>    #

>>    INF Platform/Hisilicon/D06/Drivers/Sm750Dxe/UefiSmi.inf

>>    INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf

>> -  INF Platform/Hisilicon/D06/Drivers/Sas/SasDxeDriver.inf

>>    INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf

>>    INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf

>>    INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf

>> -- 

>> 2.9.5

>>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Platform/Hisilicon/D06/D06.fdf b/Platform/Hisilicon/D06/D06.fdf
index a937660a09e2..d495ad7f264c 100644
--- a/Platform/Hisilicon/D06/D06.fdf
+++ b/Platform/Hisilicon/D06/D06.fdf
@@ -165,6 +165,7 @@  [FV.FvMain]
   INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
 
   INF Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.inf
+  INF Platform/Hisilicon/D06/Drivers/Sas/SasDxeDriver.inf
   #
   # PI DXE Drivers producing Architectural Protocols (EFI Services)
   #
@@ -296,7 +297,6 @@  [FV.FvMain]
   #
   INF Platform/Hisilicon/D06/Drivers/Sm750Dxe/UefiSmi.inf
   INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
-  INF Platform/Hisilicon/D06/Drivers/Sas/SasDxeDriver.inf
   INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
   INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
   INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf