grub2: Disable address-of-packed-member warnings

Message ID 20190206084444.16250-1-raj.khem@gmail.com
State New
Headers show
Series
  • grub2: Disable address-of-packed-member warnings
Related show

Commit Message

Khem Raj Feb. 6, 2019, 8:44 a.m.
gcc9 has turned this warning into error when -Werror is used, lets paper
it over by turning it into a warning for now

Fixes
error: taking address of packed member of 'struct head' may result in an unaligned pointer value [-Werror=address-of-packed-member]

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta/recipes-bsp/grub/grub2.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Richard Purdie Feb. 6, 2019, 8:23 p.m. | #1
On Wed, 2019-02-06 at 00:44 -0800, Khem Raj wrote:
> gcc9 has turned this warning into error when -Werror is used, lets

> paper

> it over by turning it into a warning for now

> 

> Fixes

> error: taking address of packed member of 'struct head' may result in

> an unaligned pointer value [-Werror=address-of-packed-member]

> 

> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> ---

>  meta/recipes-bsp/grub/grub2.inc | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/meta/recipes-bsp/grub/grub2.inc b/meta/recipes-

> bsp/grub/grub2.inc

> index 8e0f86217c..28e1c210e8 100644

> --- a/meta/recipes-bsp/grub/grub2.inc

> +++ b/meta/recipes-bsp/grub/grub2.inc

> @@ -60,7 +60,7 @@ BUILD_CPPFLAGS = ""

>  BUILD_CFLAGS = ""

>  BUILD_CXXFLAGS = ""

>  BUILD_LDFLAGS = ""

> -

> +CPPFLAGS += "-Wno-error=address-of-packed-member"

>  do_configure_prepend() {

>  	# The grub2 configure script uses variables such as

> TARGET_CFLAGS etc

>  	# for its own purposes. Remove the OE versions from the

> environment to


This failed all over the place, e.g.:

https://autobuilder.yoctoproject.org/typhoon/#/builders/48/builds/264

Cheers,

Richard



-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj Feb. 6, 2019, 8:48 p.m. | #2
On Wed, Feb 6, 2019 at 12:23 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>

> On Wed, 2019-02-06 at 00:44 -0800, Khem Raj wrote:

> > gcc9 has turned this warning into error when -Werror is used, lets

> > paper

> > it over by turning it into a warning for now

> >

> > Fixes

> > error: taking address of packed member of 'struct head' may result in

> > an unaligned pointer value [-Werror=address-of-packed-member]

> >

> > Signed-off-by: Khem Raj <raj.khem@gmail.com>

> > ---

> >  meta/recipes-bsp/grub/grub2.inc | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> >

> > diff --git a/meta/recipes-bsp/grub/grub2.inc b/meta/recipes-

> > bsp/grub/grub2.inc

> > index 8e0f86217c..28e1c210e8 100644

> > --- a/meta/recipes-bsp/grub/grub2.inc

> > +++ b/meta/recipes-bsp/grub/grub2.inc

> > @@ -60,7 +60,7 @@ BUILD_CPPFLAGS = ""

> >  BUILD_CFLAGS = ""

> >  BUILD_CXXFLAGS = ""

> >  BUILD_LDFLAGS = ""

> > -

> > +CPPFLAGS += "-Wno-error=address-of-packed-member"

> >  do_configure_prepend() {

> >       # The grub2 configure script uses variables such as

> > TARGET_CFLAGS etc

> >       # for its own purposes. Remove the OE versions from the

> > environment to

>

> This failed all over the place, e.g.:

>

> https://autobuilder.yoctoproject.org/typhoon/#/builders/48/builds/264

>


yeah this is new gcc9+ option , it did not occur to me. I think we
need to make the code to see if compiler supports this option before
adding it. Ideally code should be fixed but thats for laters. Drop
this patch I will add a m4 macro check and add/remove it in
Makefile.am

> Cheers,

>

> Richard

>

>

>

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-bsp/grub/grub2.inc b/meta/recipes-bsp/grub/grub2.inc
index 8e0f86217c..28e1c210e8 100644
--- a/meta/recipes-bsp/grub/grub2.inc
+++ b/meta/recipes-bsp/grub/grub2.inc
@@ -60,7 +60,7 @@  BUILD_CPPFLAGS = ""
 BUILD_CFLAGS = ""
 BUILD_CXXFLAGS = ""
 BUILD_LDFLAGS = ""
-
+CPPFLAGS += "-Wno-error=address-of-packed-member"
 do_configure_prepend() {
 	# The grub2 configure script uses variables such as TARGET_CFLAGS etc
 	# for its own purposes. Remove the OE versions from the environment to