mtd: rawnand: call onfi_fill_data_interface() once again after nand_detect

Message ID
State New
Headers show
  • mtd: rawnand: call onfi_fill_data_interface() once again after nand_detect
Related show

Commit Message

Masahiro Yamada Feb. 7, 2019, 9:57 a.m.
nand_scan_ident() calls onfi_fill_data_interface() at its entry
to set up the initial timing parameters.

The timing parameters are needed not only for ->setup_data_interface(),
but also for giving the correct delay to NAND_OP_WAIT_RDY, for example.

If the driver sets the NAND_KEEP_TIMINGS flag, or does not support
->setup_data_interface() hook, those parameters will never updated.

Before nand_detect(), we never know whether the chip is ONFi or not.
So, onfi_fill_data_interface() has to assume the worst case, i.e.

After nand_detect(), if the chip turns out to be ONFi-compliant,
we can optimize tPROG_max, tBERS_max, etc.

Call onfi_fill_data_interface() once again.

Signed-off-by: Masahiro Yamada <>


 drivers/mtd/nand/raw/nand_base.c | 3 +++
 1 file changed, 3 insertions(+)


Linux MTD discussion mailing list


diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index 9b3d7ff..35e543c 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -5040,6 +5040,9 @@  static int nand_scan_ident(struct nand_chip *chip, unsigned int maxchips,
+	/* If the chip turns out ONFi, we can optimize timing parameters. */
+	onfi_fill_data_interface(chip, NAND_SDR_IFACE, 0);
 	/* Check for a chip array */
 	for (i = 1; i < maxchips; i++) {
 		u8 id[2];