clk: uniphier: Fix update register for CPU-gear

Message ID 1549592723-18494-1-git-send-email-hayashi.kunihiko@socionext.com
State Accepted
Commit 521282237b9d78b9bff423ec818becd4c95841c2
Headers show
Series
  • clk: uniphier: Fix update register for CPU-gear
Related show

Commit Message

Kunihiko Hayashi Feb. 8, 2019, 2:25 a.m.
Need to set the update bit in UNIPHIER_CLK_CPUGEAR_UPD to update
the CPU-gear value.

Fixes: d08f1f0d596c ("clk: uniphier: add CPU-gear change (cpufreq) support")
Cc: linux-stable@vger.kernel.org
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

---
 drivers/clk/uniphier/clk-uniphier-cpugear.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

Comments

Masahiro Yamada Feb. 8, 2019, 2:31 a.m. | #1
On Fri, Feb 8, 2019 at 11:25 AM Kunihiko Hayashi
<hayashi.kunihiko@socionext.com> wrote:
>

> Need to set the update bit in UNIPHIER_CLK_CPUGEAR_UPD to update

> the CPU-gear value.

>

> Fixes: d08f1f0d596c ("clk: uniphier: add CPU-gear change (cpufreq) support")

> Cc: linux-stable@vger.kernel.org

> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

> ---



Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>



-- 
Best Regards
Masahiro Yamada
Stephen Boyd Feb. 21, 2019, 9:50 p.m. | #2
Quoting Kunihiko Hayashi (2019-02-07 18:25:23)
> Need to set the update bit in UNIPHIER_CLK_CPUGEAR_UPD to update

> the CPU-gear value.

> 

> Fixes: d08f1f0d596c ("clk: uniphier: add CPU-gear change (cpufreq) support")

> Cc: linux-stable@vger.kernel.org

> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

> ---


Applied to clk-next

Patch

diff --git a/drivers/clk/uniphier/clk-uniphier-cpugear.c b/drivers/clk/uniphier/clk-uniphier-cpugear.c
index ec11f55..5d2d42b 100644
--- a/drivers/clk/uniphier/clk-uniphier-cpugear.c
+++ b/drivers/clk/uniphier/clk-uniphier-cpugear.c
@@ -47,7 +47,7 @@  static int uniphier_clk_cpugear_set_parent(struct clk_hw *hw, u8 index)
 		return ret;
 
 	ret = regmap_write_bits(gear->regmap,
-				gear->regbase + UNIPHIER_CLK_CPUGEAR_SET,
+				gear->regbase + UNIPHIER_CLK_CPUGEAR_UPD,
 				UNIPHIER_CLK_CPUGEAR_UPD_BIT,
 				UNIPHIER_CLK_CPUGEAR_UPD_BIT);
 	if (ret)