[edk2,edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h

Message ID 20190211180202.991-1-leif.lindholm@linaro.org
State New
Headers show
Series
  • [edk2,edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h
Related show

Commit Message

Leif Lindholm Feb. 11, 2019, 6:02 p.m.
Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe
.vfr rather than local definitions.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

---
 .../Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr   | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ard Biesheuvel Feb. 11, 2019, 6:03 p.m. | #1
On Mon, 11 Feb 2019 at 19:02, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>

> Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe

> .vfr rather than local definitions.

>

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>


Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


> ---

>  .../Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr   | 9 +--------

>  1 file changed, 1 insertion(+), 8 deletions(-)

>

> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr

> index 8a395eac68..25b7b49a3d 100644

> --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr

> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr

> @@ -15,14 +15,7 @@

>  #include <Guid/HiiPlatformSetupFormset.h>

>  #include <Guid/SynQuacerPlatformFormSet.h>

>  #include <Platform/VarStore.h>

> -

> -//

> -// EFI Variable attributes

> -//

> -#define EFI_VARIABLE_NON_VOLATILE       0x00000001

> -#define EFI_VARIABLE_BOOTSERVICE_ACCESS 0x00000002

> -#define EFI_VARIABLE_RUNTIME_ACCESS     0x00000004

> -#define EFI_VARIABLE_READ_ONLY          0x00000008

> +#include <Uefi/UefiMultiPhase.h>

>

>  formset

>    guid      = SYNQUACER_PLATFORM_FORMSET_GUID,

> --

> 2.11.0

>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Leif Lindholm Feb. 11, 2019, 7:06 p.m. | #2
On Mon, Feb 11, 2019 at 07:03:09PM +0100, Ard Biesheuvel wrote:
> On Mon, 11 Feb 2019 at 19:02, Leif Lindholm <leif.lindholm@linaro.org> wrote:

> >

> > Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe

> > .vfr rather than local definitions.

> >

> > Contributed-under: TianoCore Contribution Agreement 1.1

> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

> 

> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


Thanks, pushed as d7b29975f8.

> > ---

> >  .../Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr   | 9 +--------

> >  1 file changed, 1 insertion(+), 8 deletions(-)

> >

> > diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr

> > index 8a395eac68..25b7b49a3d 100644

> > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr

> > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr

> > @@ -15,14 +15,7 @@

> >  #include <Guid/HiiPlatformSetupFormset.h>

> >  #include <Guid/SynQuacerPlatformFormSet.h>

> >  #include <Platform/VarStore.h>

> > -

> > -//

> > -// EFI Variable attributes

> > -//

> > -#define EFI_VARIABLE_NON_VOLATILE       0x00000001

> > -#define EFI_VARIABLE_BOOTSERVICE_ACCESS 0x00000002

> > -#define EFI_VARIABLE_RUNTIME_ACCESS     0x00000004

> > -#define EFI_VARIABLE_READ_ONLY          0x00000008

> > +#include <Uefi/UefiMultiPhase.h>

> >

> >  formset

> >    guid      = SYNQUACER_PLATFORM_FORMSET_GUID,

> > --

> > 2.11.0

> >

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
index 8a395eac68..25b7b49a3d 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
+++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
@@ -15,14 +15,7 @@ 
 #include <Guid/HiiPlatformSetupFormset.h>
 #include <Guid/SynQuacerPlatformFormSet.h>
 #include <Platform/VarStore.h>
-
-//
-// EFI Variable attributes
-//
-#define EFI_VARIABLE_NON_VOLATILE       0x00000001
-#define EFI_VARIABLE_BOOTSERVICE_ACCESS 0x00000002
-#define EFI_VARIABLE_RUNTIME_ACCESS     0x00000004
-#define EFI_VARIABLE_READ_ONLY          0x00000008
+#include <Uefi/UefiMultiPhase.h>
 
 formset
   guid      = SYNQUACER_PLATFORM_FORMSET_GUID,