diff mbox series

cpufreq: Replace double NOT (!!) with single NOT (!)

Message ID e0ea5fc21f9d3bd38eb4eb678d39359d66c8e79e.1550141092.git.viresh.kumar@linaro.org
State Accepted
Commit a9a22b570bd512eb1ed946042bb88f11ecccca0c
Headers show
Series cpufreq: Replace double NOT (!!) with single NOT (!) | expand

Commit Message

Viresh Kumar Feb. 14, 2019, 10:46 a.m. UTC
Double NOT (!!) operation is normally done to convert a non-zero value
to 1 and keep zero as is, but that isn't the requirement in this case.
All we wanted was to make sure that only one of the two routines isn't
set, i.e. either both function pointers are set or both are unset.

This can be done with a single NOT (!) operation as well.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

---
 drivers/cpufreq/cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.21.0.rc0.269.g1a574e7a288b

Comments

Rafael J. Wysocki Feb. 19, 2019, 10:20 a.m. UTC | #1
On Thursday, February 14, 2019 11:46:21 AM CET Viresh Kumar wrote:
> Double NOT (!!) operation is normally done to convert a non-zero value

> to 1 and keep zero as is, but that isn't the requirement in this case.

> All we wanted was to make sure that only one of the two routines isn't

> set, i.e. either both function pointers are set or both are unset.

> 

> This can be done with a single NOT (!) operation as well.

> 

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

> ---

>  drivers/cpufreq/cpufreq.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c

> index 55e9795801a4..ad4e9991c3cc 100644

> --- a/drivers/cpufreq/cpufreq.c

> +++ b/drivers/cpufreq/cpufreq.c

> @@ -2505,7 +2505,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data)

>  		    driver_data->target) ||

>  	     (driver_data->setpolicy && (driver_data->target_index ||

>  		    driver_data->target)) ||

> -	     (!!driver_data->get_intermediate != !!driver_data->target_intermediate) ||

> +	     (!driver_data->get_intermediate != !driver_data->target_intermediate) ||

>  	     (!driver_data->online != !driver_data->offline))

>  		return -EINVAL;

>  

> 


Applied, thanks!
diff mbox series

Patch

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 55e9795801a4..ad4e9991c3cc 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -2505,7 +2505,7 @@  int cpufreq_register_driver(struct cpufreq_driver *driver_data)
 		    driver_data->target) ||
 	     (driver_data->setpolicy && (driver_data->target_index ||
 		    driver_data->target)) ||
-	     (!!driver_data->get_intermediate != !!driver_data->target_intermediate) ||
+	     (!driver_data->get_intermediate != !driver_data->target_intermediate) ||
 	     (!driver_data->online != !driver_data->offline))
 		return -EINVAL;