| Message ID | 20190214125107.22178-8-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add model of the Arm Musca devboards | expand |
On 2/14/19 4:51 AM, Peter Maydell wrote: > The pl011 logs when the guest makes a bad access. It prints > the address offset in hex but confusingly omits the '0x' > prefix; add it. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > hw/char/pl011.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 2/14/19 1:51 PM, Peter Maydell wrote: > The pl011 logs when the guest makes a bad access. It prints > the address offset in hex but confusingly omits the '0x' > prefix; add it. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/char/pl011.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/char/pl011.c b/hw/char/pl011.c > index 29f4e5eb224..e5dd448f854 100644 > --- a/hw/char/pl011.c > +++ b/hw/char/pl011.c > @@ -143,7 +143,7 @@ static uint64_t pl011_read(void *opaque, hwaddr offset, > break; > default: > qemu_log_mask(LOG_GUEST_ERROR, > - "pl011_read: Bad offset %x\n", (int)offset); > + "pl011_read: Bad offset 0x%x\n", (int)offset); > r = 0; > break; > } > @@ -232,7 +232,7 @@ static void pl011_write(void *opaque, hwaddr offset, > break; > default: > qemu_log_mask(LOG_GUEST_ERROR, > - "pl011_write: Bad offset %x\n", (int)offset); > + "pl011_write: Bad offset 0x%x\n", (int)offset); > } > } > >
diff --git a/hw/char/pl011.c b/hw/char/pl011.c index 29f4e5eb224..e5dd448f854 100644 --- a/hw/char/pl011.c +++ b/hw/char/pl011.c @@ -143,7 +143,7 @@ static uint64_t pl011_read(void *opaque, hwaddr offset, break; default: qemu_log_mask(LOG_GUEST_ERROR, - "pl011_read: Bad offset %x\n", (int)offset); + "pl011_read: Bad offset 0x%x\n", (int)offset); r = 0; break; } @@ -232,7 +232,7 @@ static void pl011_write(void *opaque, hwaddr offset, break; default: qemu_log_mask(LOG_GUEST_ERROR, - "pl011_write: Bad offset %x\n", (int)offset); + "pl011_write: Bad offset 0x%x\n", (int)offset); } }
The pl011 logs when the guest makes a bad access. It prints the address offset in hex but confusingly omits the '0x' prefix; add it. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- hw/char/pl011.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.20.1