[v2] uapi/if_ether.h: prevent redefinition of struct ethhdr

Message ID 20190214131800.8760-1-linus.walleij@linaro.org
State New
Headers show
Series
  • [v2] uapi/if_ether.h: prevent redefinition of struct ethhdr
Related show

Commit Message

Linus Walleij Feb. 14, 2019, 1:18 p.m.
From: Hauke Mehrtens <hauke@hauke-m.de>


commit 6926e041a8920c8ec27e4e155efa760aa01551fd upstream.

Musl provides its own ethhdr struct definition. Add a guard to prevent
its definition of the appropriate musl header has already been included.

glibc does not implement this header, but when glibc will implement this
they can just define __UAPI_DEF_ETHHDR 0 to make it work with the
kernel.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

Signed-off-by: David S. Miller <davem@davemloft.net>

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
ChangeLog v1->v2:
- Add SoB line

- This is upstream in v4.15
- This should be applied for stable v4.14.y and v4.9.y
---
 include/uapi/linux/if_ether.h    | 3 +++
 include/uapi/linux/libc-compat.h | 6 ++++++
 2 files changed, 9 insertions(+)

-- 
2.20.1

Comments

Sasha Levin Feb. 17, 2019, 6:21 p.m. | #1
On Thu, Feb 14, 2019 at 02:18:00PM +0100, Linus Walleij wrote:
>From: Hauke Mehrtens <hauke@hauke-m.de>

>

>commit 6926e041a8920c8ec27e4e155efa760aa01551fd upstream.

>

>Musl provides its own ethhdr struct definition. Add a guard to prevent

>its definition of the appropriate musl header has already been included.

>

>glibc does not implement this header, but when glibc will implement this

>they can just define __UAPI_DEF_ETHHDR 0 to make it work with the

>kernel.

>

>Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

>Signed-off-by: David S. Miller <davem@davemloft.net>

>Signed-off-by: Linus Walleij <linus.walleij@linaro.org>


Queued up, thank you.

--
Thanks,
Sasha

Patch

diff --git a/include/uapi/linux/if_ether.h b/include/uapi/linux/if_ether.h
index 244e3213ecb0..60ec9114e28f 100644
--- a/include/uapi/linux/if_ether.h
+++ b/include/uapi/linux/if_ether.h
@@ -23,6 +23,7 @@ 
 #define _UAPI_LINUX_IF_ETHER_H
 
 #include <linux/types.h>
+#include <linux/libc-compat.h>
 
 /*
  *	IEEE 802.3 Ethernet magic constants.  The frame sizes omit the preamble
@@ -150,11 +151,13 @@ 
  *	This is an Ethernet frame header.
  */
 
+#if __UAPI_DEF_ETHHDR
 struct ethhdr {
 	unsigned char	h_dest[ETH_ALEN];	/* destination eth addr	*/
 	unsigned char	h_source[ETH_ALEN];	/* source ether addr	*/
 	__be16		h_proto;		/* packet type ID field	*/
 } __attribute__((packed));
+#endif
 
 
 #endif /* _UAPI_LINUX_IF_ETHER_H */
diff --git a/include/uapi/linux/libc-compat.h b/include/uapi/linux/libc-compat.h
index 8254c937c9f4..fc29efaa918c 100644
--- a/include/uapi/linux/libc-compat.h
+++ b/include/uapi/linux/libc-compat.h
@@ -264,4 +264,10 @@ 
 
 #endif /* __GLIBC__ */
 
+/* Definitions for if_ether.h */
+/* allow libcs like musl to deactivate this, glibc does not implement this. */
+#ifndef __UAPI_DEF_ETHHDR
+#define __UAPI_DEF_ETHHDR		1
+#endif
+
 #endif /* _UAPI_LIBC_COMPAT_H */