From patchwork Fri Feb 15 00:45:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaldo Carvalho de Melo X-Patchwork-Id: 158460 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp103738jaa; Thu, 14 Feb 2019 16:47:59 -0800 (PST) X-Google-Smtp-Source: AHgI3IbIwbdUrdLz05tEsZqE5xNICZ9cEkS7Tx9ehlMMoWT+o6IUP4EBOTzF2ZxfL2+2SMiM16Bj X-Received: by 2002:a17:902:834b:: with SMTP id z11mr7390692pln.151.1550191679413; Thu, 14 Feb 2019 16:47:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550191679; cv=none; d=google.com; s=arc-20160816; b=Yahaj5h1ks+aFwHVJpiTDrJetCMNmwetYgUl0dMz5Fv2t7n39VUYNNQ8djdEZmi0zK 9n8sSAHvmnpZXWQTmoPLaa7H4cvdeZEtCnSHHKSgjHZX+VXZzaedoHo5DXsuu/amuK1/ yAkGe0txgw2xm0jE2Ht4AmansnOZKPZ6kOK/pjRfhOfj3xXE5nuvPZPc4+a2c60nkUH9 +QM/fCYcZKzYcqgCZlOLI+GautNri3vJ+DMZ/75vZ0DubD4tUssosXduD7jEyrAUCTLK 8wGoA69GPRzeR23jCWvg6JWbv+9MPw8RgKnP0cza3aXNJKnqno7fpn+XSpv8E0Vdrsp/ mWNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lJht4p+PfXX6983vavsajvrMtgqctU7/Pul/pwHAuXU=; b=TyGWpuSVRfHaXb+oiVTvFuLyhvB8apVUY1pvJkC8Hm+V96uVH4O6JNMM/f2ZMPDBlV nnbTh2Xyj1pJ5zCxcZvH+zAygn5eYhTds5+MfEktJDuUgOfmyrAieq+JZ+Wx8R/naqfN 4+mms9wYKhfZrrqCS1zyhOP9j5tGqSfuu/P4JMJNtW9Jxsv0KSumofost9KgfjEq16FQ bwKyigRDEF/dRGuiT97DRwuZRT2s4xKr+C+01j9C3ieKMlUo4VSnS8jLxdEtusBS6nke USPX9KOWfk/l61hBntZN03w0v3Ex62MlixSPsqD27mIfFNyCQy3QMT0L90g5unu2FFWU tBqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cw8O50MJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j10si3551428pgp.282.2019.02.14.16.47.58; Thu, 14 Feb 2019 16:47:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cw8O50MJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389439AbfBOAr5 (ORCPT + 31 others); Thu, 14 Feb 2019 19:47:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:46838 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389360AbfBOArz (ORCPT ); Thu, 14 Feb 2019 19:47:55 -0500 Received: from quaco.ghostprotocols.net (unknown [189.40.103.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 606CC222D9; Fri, 15 Feb 2019 00:47:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550191674; bh=yroGFyXr1DKQoOXBtBFkaB/GilLvU7Nfnt5EmXm6KWI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cw8O50MJ7nTEMaq2mfUU8rgq5KbmIxMSFJWLvhiU2F8FjjwLkMH59h5RKWpb8a8Cf C3qPbl6xg6gV6ufLYZ9f0vTXFPwN/cziHy55/X8ikvh92l0NbrzFDv2Qjldj23PBpa ZH6Y5h6wb3fzdJD58bnzos3UUStWVdCq2vVTQAkk= From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Mathieu Poirier , Jiri Olsa , Leo Yan , Peter Zijlstra , Suzuki K Poulouse , linux-arm-kernel@lists.infradead.org, Arnaldo Carvalho de Melo Subject: [PATCH 29/43] perf cs-etm: Fix erroneous comment Date: Thu, 14 Feb 2019 21:45:25 -0300 Message-Id: <20190215004539.23571-30-acme@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190215004539.23571-1-acme@kernel.org> References: <20190215004539.23571-1-acme@kernel.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mathieu Poirier The comment just before initialising the decoder is plane wrong since it is part of the decoding queue setup function and the operation code specifically mention that trace data is to be decoded rather than printed out. This patch simply fix the comment to prevent people from getting really confused. Signed-off-by: Mathieu Poirier Cc: Jiri Olsa Cc: Leo Yan Cc: Peter Zijlstra Cc: Suzuki K Poulouse Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/20190212171618.25355-8-mathieu.poirier@linaro.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/cs-etm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.19.1 diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index f3a6dfaf3026..4cc9fce97a86 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -459,7 +459,7 @@ static struct cs_etm_queue *cs_etm__alloc_queue(struct cs_etm_auxtrace *etm, if (cs_etm__init_trace_params(t_params, etm)) goto out_free; - /* Set decoder parameters to simply print the trace packets */ + /* Set decoder parameters to decode trace packets */ if (cs_etm__init_decoder_params(&d_params, etmq, CS_ETM_OPERATION_DECODE)) goto out_free;