From patchwork Fri Feb 15 11:49:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Coelho X-Patchwork-Id: 158510 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp608289jaa; Fri, 15 Feb 2019 03:49:41 -0800 (PST) X-Google-Smtp-Source: AHgI3IanGnyk4ftQ+8LuKhwLkebljkL1ZRaNSPe1Al/KA3Fs62OghoYu8lTw3tELIS4oBLLxnuU3 X-Received: by 2002:a63:1753:: with SMTP id 19mr4998213pgx.439.1550231381468; Fri, 15 Feb 2019 03:49:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550231381; cv=none; d=google.com; s=arc-20160816; b=wAACYbJSByXOxizx9+bp+Jf3vauWE4WVeKKBdVF/PYtzXL58ERS/e0dsCZJst/nTjd skAlRrVh2AQ1aiX4VumwvvRWq+I28LWbgKZcIEVHGdqOf5ZZglSrfybTqM0GYkaN63FJ ap1Gtrl+EcTuamg2IBwGqRPqE82weuYhCzKRckVoMZ/UdN1yo2Q68lp8IkZXwjGxaufE pJ7uFJTEPhnKqt1KJvU7VTqGf58gtD2RXqpYeYGfqRxk+3fwA08Y2j/Ab6tlWuvrGAEj M665VtGbHfjrq81k533QoynIzBF5s5ytfgizj4w18DkXIMMCDzqi4HSrFX7LRfPShnui TGzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:cc:to:from; bh=zvCHLF2hk3n84bas4LxL3wtHw9ZAge39LfaLdmdhI+Y=; b=pRvmyH5+bHRt51Jx9ujNNrzr476V5JNGAWhxGioDugsGvzwtLYQZnRyTDwqKCnU/wy jE9/Cg+MrntynINjvicJssXprAFX3X77FX6jIIU756WbpxMI95RW81TWCytV7UQoVOpU gbui4Xyxz2Yjav2qhg6g9YBz+icIjbzX4UKqaak+cP8SNlz3pGGZsMlbmvydKkTu08lo dO1q/gTXU1FcO2Sq24tCj6vboT6Cw0Bb0Q2TtJEFy9DbJMEmdSN0yS4VfVgA2GNY8fUd ZalaeqjeX57xehHfVu0h9isfDXIUjamKkQsTDQaW/yBPKyAczzVgm0XsI3va078AdrOY CWNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p1si5463134pld.353.2019.02.15.03.49.41; Fri, 15 Feb 2019 03:49:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436514AbfBOLtf (ORCPT + 2 others); Fri, 15 Feb 2019 06:49:35 -0500 Received: from paleale.coelho.fi ([176.9.41.70]:60384 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727457AbfBOLte (ORCPT ); Fri, 15 Feb 2019 06:49:34 -0500 Received: from 91-156-4-241.elisa-laajakaista.fi ([91.156.4.241] helo=redipa.ger.corp.intel.com) by farmhouse.coelho.fi with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.91) (envelope-from ) id 1gubzn-0008TN-RE; Fri, 15 Feb 2019 13:49:32 +0200 From: Luca Coelho To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, Arnd Bergmann , Luca Coelho Date: Fri, 15 Feb 2019 13:49:07 +0200 Message-Id: <20190215114924.2545-4-luca@coelho.fi> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190215114924.2545-1-luca@coelho.fi> References: <20190215114924.2545-1-luca@coelho.fi> MIME-Version: 1.0 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1 Subject: [PATCH 03/20] iwlwifi: fix false-positive maybe-uninitialized warning Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Arnd Bergmann With CONFIG_NO_AUTO_INLINE, we run into a silly warning when gcc fails to remember that n_profiles is constant across the function call to iwl_mvm_sar_set_profile: drivers/net/wireless/intel/iwlwifi/mvm/fw.c: In function 'iwl_mvm_sar_get_ewrd_table': drivers/net/wireless/intel/iwlwifi/mvm/fw.c:746:9: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] Marking that function 'inline' avoids the warning. Signed-off-by: Arnd Bergmann Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.20.1 diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c index 1bc51e3260eb..00a47f6f1d81 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c @@ -646,10 +646,10 @@ static int iwl_mvm_config_ltr(struct iwl_mvm *mvm) } #ifdef CONFIG_ACPI -static int iwl_mvm_sar_set_profile(struct iwl_mvm *mvm, - union acpi_object *table, - struct iwl_mvm_sar_profile *profile, - bool enabled) +static inline int iwl_mvm_sar_set_profile(struct iwl_mvm *mvm, + union acpi_object *table, + struct iwl_mvm_sar_profile *profile, + bool enabled) { int i;