[08/10] bhyve: domcaps: fill in explicit supported BOOL_NO

Message ID 04fd5c660083c2493bea90d0df8cf7bb6f6f78c4.1550606392.git.crobinso@redhat.com
State Superseded
Headers show
Series
  • domcaps: use virTristateBool
Related show

Commit Message

Cole Robinson Feb. 19, 2019, 8:09 p.m.
<hostdev> and <features> are not supported. <loader>, <graphics>,
and <video> are supported conditionally

Signed-off-by: Cole Robinson <crobinso@redhat.com>

---
This patch is untested. If someone has a bhyve build setup I'd
appreciate a test

 src/bhyve/bhyve_capabilities.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patch

diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c
index 79d7659da3..ff78023895 100644
--- a/src/bhyve/bhyve_capabilities.c
+++ b/src/bhyve/bhyve_capabilities.c
@@ -86,6 +86,7 @@  virBhyveDomainCapsFill(virDomainCapsPtr caps,
 
     caps->os.supported = VIR_TRISTATE_BOOL_YES;
 
+    caps->os.loader.supported = VIR_TRISTATE_BOOL_NO;
     if (bhyvecaps & BHYVE_CAP_LPC_BOOTROM) {
         caps->os.loader.supported = VIR_TRISTATE_BOOL_YES;
         VIR_DOMAIN_CAPS_ENUM_SET(caps->os.loader.type,
@@ -98,12 +99,21 @@  virBhyveDomainCapsFill(virDomainCapsPtr caps,
     }
 
 
+    caps->graphics.supported = VIR_TRISTATE_BOOL_NO;
+    caps->video.supported = VIR_TRISTATE_BOOL_NO;
     if (bhyvecaps & BHYVE_CAP_FBUF) {
         caps->graphics.supported = VIR_TRISTATE_BOOL_YES;
         caps->video.supported = VIR_TRISTATE_BOOL_YES;
         VIR_DOMAIN_CAPS_ENUM_SET(caps->graphics.type, VIR_DOMAIN_GRAPHICS_TYPE_VNC);
         VIR_DOMAIN_CAPS_ENUM_SET(caps->video.modelType, VIR_DOMAIN_VIDEO_TYPE_GOP);
     }
+
+    caps->hostdev.supported = VIR_TRISTATE_BOOL_NO;
+    caps->iothreads = VIR_TRISTATE_BOOL_NO;
+    caps->vmcoreinfo = VIR_TRISTATE_BOOL_NO;
+    caps->genid = VIR_TRISTATE_BOOL_NO;
+    caps->gic.supported = VIR_TRISTATE_BOOL_NO;
+
     return 0;
 }