[Linaro-uefi,v2] opteed-build.sh: change file for detection of..

Message ID 20190225100348.20541-1-victor.chong@linaro.org
State New
Headers show
Series
  • [Linaro-uefi,v2] opteed-build.sh: change file for detection of..
Related show

Commit Message

Victor Chong Feb. 25, 2019, 10:03 a.m.
..trusted OS directory

documentation/optee_design.md was recently removed in a patch upstream
so use another file less likely to be removed again.

Signed-off-by: Victor Chong <victor.chong@linaro.org>
---

v2: update commit message to fix filename typo

---
 opteed-build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Victor Chong March 28, 2019, 11:22 a.m. | #1
Hi Leif,

Ping

On Mon, Feb 25, 2019 at 7:03 PM Victor Chong <victor.chong@linaro.org>
wrote:

> ..trusted OS directory

>

> documentation/optee_design.md was recently removed in a patch upstream

> so use another file less likely to be removed again.

>

> Signed-off-by: Victor Chong <victor.chong@linaro.org>

> ---

>

> v2: update commit message to fix filename typo

>

> ---

>  opteed-build.sh | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/opteed-build.sh b/opteed-build.sh

> index 2dd40ff..3229cbb 100755

> --- a/opteed-build.sh

> +++ b/opteed-build.sh

> @@ -126,7 +126,7 @@ function build_platform

>

>  # Check to see if we are in a trusted OS directory

>  # refuse to continue if we aren't

> -if [ ! -f documentation/optee_design.md ]

> +if [ ! -f core/tee/tee_svc.c ]

>  then

>         echo "ERROR: we aren't in the optee_os directory."

>         usage

> --

> 2.17.1

>

>
<div dir="ltr"><div>Hi Leif,</div><div><br></div><div>Ping<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Feb 25, 2019 at 7:03 PM Victor Chong &lt;<a href="mailto:victor.chong@linaro.org">victor.chong@linaro.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">..trusted OS directory<br>
<br>
documentation/optee_design.md was recently removed in a patch upstream<br>
so use another file less likely to be removed again.<br>
<br>
Signed-off-by: Victor Chong &lt;<a href="mailto:victor.chong@linaro.org" target="_blank">victor.chong@linaro.org</a>&gt;<br>

---<br>
<br>
v2: update commit message to fix filename typo<br>
<br>
---<br>
 opteed-build.sh | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/opteed-build.sh b/opteed-build.sh<br>
index 2dd40ff..3229cbb 100755<br>
--- a/opteed-build.sh<br>
+++ b/opteed-build.sh<br>
@@ -126,7 +126,7 @@ function build_platform<br>
<br>
 # Check to see if we are in a trusted OS directory<br>
 # refuse to continue if we aren&#39;t<br>
-if [ ! -f documentation/optee_design.md ]<br>
+if [ ! -f core/tee/tee_svc.c ]<br>
 then<br>
        echo &quot;ERROR: we aren&#39;t in the optee_os directory.&quot;<br>
        usage<br>
-- <br>
2.17.1<br>
<br>
</blockquote></div></div>
Leif Lindholm March 28, 2019, 12:29 p.m. | #2
On Mon, Feb 25, 2019 at 10:03:48AM +0000, Victor Chong wrote:
> ..trusted OS directory
> 
> documentation/optee_design.md was recently removed in a patch upstream
> so use another file less likely to be removed again.
> 
> Signed-off-by: Victor Chong <victor.chong@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as a34412f.

Thanks. Apologies for dropping these.

> ---
> 
> v2: update commit message to fix filename typo
> 
> ---
>  opteed-build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/opteed-build.sh b/opteed-build.sh
> index 2dd40ff..3229cbb 100755
> --- a/opteed-build.sh
> +++ b/opteed-build.sh
> @@ -126,7 +126,7 @@ function build_platform
>  
>  # Check to see if we are in a trusted OS directory
>  # refuse to continue if we aren't
> -if [ ! -f documentation/optee_design.md ]
> +if [ ! -f core/tee/tee_svc.c ]
>  then
>  	echo "ERROR: we aren't in the optee_os directory."
>  	usage
> -- 
> 2.17.1
>

Patch

diff --git a/opteed-build.sh b/opteed-build.sh
index 2dd40ff..3229cbb 100755
--- a/opteed-build.sh
+++ b/opteed-build.sh
@@ -126,7 +126,7 @@  function build_platform
 
 # Check to see if we are in a trusted OS directory
 # refuse to continue if we aren't
-if [ ! -f documentation/optee_design.md ]
+if [ ! -f core/tee/tee_svc.c ]
 then
 	echo "ERROR: we aren't in the optee_os directory."
 	usage