| Message ID | 20190303003834.44637-1-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] grub: Enhance Waddress-of-packed-member patch to cover x86_64 testcase | expand |
On 3/2/19 4:38 PM, Khem Raj wrote: > This was not compiled last time when testing aarch64 The subject and body have conflicting archs. is it both? - armin > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > .../files/disable-address-of-packed-member.patch | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch b/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch > index 4af6a599d5..415f52ebe3 100644 > --- a/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch > +++ b/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch > @@ -247,3 +247,16 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com> > > static grub_dl_t my_mod; > > +--- a/grub-core/commands/usbtest.c > ++++ b/grub-core/commands/usbtest.c > +@@ -63,6 +63,10 @@ static const char *usb_devspeed[] = > + "High" > + }; > + > ++#if __GNUC__ >= 9 > ++#pragma GCC diagnostic ignored "-Waddress-of-packed-member" > ++#endif > ++ > + static grub_usb_err_t > + grub_usb_get_string (grub_usb_device_t dev, grub_uint8_t index, int langid, > + char **string) -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On Sat, Mar 2, 2019 at 5:57 PM akuster808 <akuster808@gmail.com> wrote: > > > On 3/2/19 4:38 PM, Khem Raj wrote: > > This was not compiled last time when testing aarch64 > > The subject and body have conflicting archs. > is it both? That’s just for history since last time I tested it with Aarch64/Gcc9 and now I got to test x86_64/gcc9 And saw that the patch was not taking care of additional test cases that were getting built for x86 > > - armin > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > --- > > .../files/disable-address-of-packed-member.patch | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git > a/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch > b/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch > > index 4af6a599d5..415f52ebe3 100644 > > --- a/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch > > +++ b/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch > > @@ -247,3 +247,16 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com> > > > > static grub_dl_t my_mod; > > > > +--- a/grub-core/commands/usbtest.c > > ++++ b/grub-core/commands/usbtest.c > > +@@ -63,6 +63,10 @@ static const char *usb_devspeed[] = > > + "High" > > + }; > > + > > ++#if __GNUC__ >= 9 > > ++#pragma GCC diagnostic ignored "-Waddress-of-packed-member" > > ++#endif > > ++ > > + static grub_usb_err_t > > + grub_usb_get_string (grub_usb_device_t dev, grub_uint8_t index, int > langid, > > + char **string) > > > <div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Mar 2, 2019 at 5:57 PM akuster808 <<a href="mailto:akuster808@gmail.com">akuster808@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br> <br> On 3/2/19 4:38 PM, Khem Raj wrote:<br> > This was not compiled last time when testing aarch64<br> <br> The subject and body have conflicting archs.<br> is it both?</blockquote><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto">That’s just for history since last time I tested it with </div><div dir="auto">Aarch64/Gcc9 and now I got to test x86_64/gcc9</div><div dir="auto">And saw that the patch was not taking care of additional test cases that were getting built for x86</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br> - armin<br> ><br> > Signed-off-by: Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>><br> > ---<br> > .../files/disable-address-of-packed-member.patch | 13 +++++++++++++<br> > 1 file changed, 13 insertions(+)<br> ><br> > diff --git a/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch b/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch<br> > index 4af6a599d5..415f52ebe3 100644<br> > --- a/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch<br> > +++ b/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch<br> > @@ -247,3 +247,16 @@ Signed-off-by: Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>><br> > <br> > static grub_dl_t my_mod;<br> > <br> > +--- a/grub-core/commands/usbtest.c<br> > ++++ b/grub-core/commands/usbtest.c<br> > +@@ -63,6 +63,10 @@ static const char *usb_devspeed[] =<br> > + "High"<br> > + };<br> > + <br> > ++#if __GNUC__ >= 9<br> > ++#pragma GCC diagnostic ignored "-Waddress-of-packed-member"<br> > ++#endif<br> > ++<br> > + static grub_usb_err_t<br> > + grub_usb_get_string (grub_usb_device_t dev, grub_uint8_t index, int langid,<br> > + char **string)<br> <br> <br> </blockquote></div></div> -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On Sat, 2019-03-02 at 17:57 -0800, akuster808 wrote: > > On 3/2/19 4:38 PM, Khem Raj wrote: > > This was not compiled last time when testing aarch64 > > The subject and body have conflicting archs. > is it both? I've tweaked the commit message... Cheers, Richard -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff --git a/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch b/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch index 4af6a599d5..415f52ebe3 100644 --- a/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch +++ b/meta/recipes-bsp/grub/files/disable-address-of-packed-member.patch @@ -247,3 +247,16 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com> static grub_dl_t my_mod; +--- a/grub-core/commands/usbtest.c ++++ b/grub-core/commands/usbtest.c +@@ -63,6 +63,10 @@ static const char *usb_devspeed[] = + "High" + }; + ++#if __GNUC__ >= 9 ++#pragma GCC diagnostic ignored "-Waddress-of-packed-member" ++#endif ++ + static grub_usb_err_t + grub_usb_get_string (grub_usb_device_t dev, grub_uint8_t index, int langid, + char **string)
This was not compiled last time when testing aarch64 Signed-off-by: Khem Raj <raj.khem@gmail.com> --- .../files/disable-address-of-packed-member.patch | 13 +++++++++++++ 1 file changed, 13 insertions(+) -- 2.21.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core