pinctrl: freescale: fix link errors

Message ID 20190304202640.1765847-1-arnd@arndb.de
State New
Headers show
Series
  • pinctrl: freescale: fix link errors
Related show

Commit Message

Arnd Bergmann March 4, 2019, 8:26 p.m.
Submitted by Anders Roxell already

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/pinctrl/freescale/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.20.0

Comments

Dong Aisheng March 5, 2019, 3 a.m. | #1
Hi Arnd,

> From: Arnd Bergmann [mailto:arnd@arndb.de]

> Sent: Tuesday, March 5, 2019 4:26 AM

> 

> Submitted by Anders Roxell already

> 

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


How would suggest to handle this patch?

I've already given an Ack to Andres' v3 patch with a few additional comments,
but seems did not see any follow ups.

https://lore.kernel.org/patchwork/patch/1034330/

Regards
Dong Aisheng

> ---

>  drivers/pinctrl/freescale/Kconfig | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig

> index e6dff3167a67..e447b996e79f 100644

> --- a/drivers/pinctrl/freescale/Kconfig

> +++ b/drivers/pinctrl/freescale/Kconfig

> @@ -138,14 +138,14 @@ config PINCTRL_IMX8MQ

> 

>  config PINCTRL_IMX8QM

>  	bool "IMX8QM pinctrl driver"

> -	depends on ARCH_MXC && ARM64

> +	depends on ARCH_MXC && ARM64 && IMX_SCU

>  	select PINCTRL_IMX_SCU

>  	help

>  	  Say Y here to enable the imx8qm pinctrl driver

> 

>  config PINCTRL_IMX8QXP

>  	bool "IMX8QXP pinctrl driver"

> -	depends on ARCH_MXC && ARM64

> +	depends on ARCH_MXC && ARM64 && IMX_SCU

>  	select PINCTRL_IMX_SCU

>  	help

>  	  Say Y here to enable the imx8qxp pinctrl driver

> --

> 2.20.0
Arnd Bergmann March 5, 2019, 8:29 a.m. | #2
On Tue, Mar 5, 2019 at 4:00 AM Aisheng Dong <aisheng.dong@nxp.com> wrote:
>

> Hi Arnd,

>

> > From: Arnd Bergmann [mailto:arnd@arndb.de]

> > Sent: Tuesday, March 5, 2019 4:26 AM

> >

> > Submitted by Anders Roxell already

> >

> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

>

> How would suggest to handle this patch?

>

> I've already given an Ack to Andres' v3 patch with a few additional comments,

> but seems did not see any follow ups.

>

> https://lore.kernel.org/patchwork/patch/1034330/



Sorry about that, I sent this out as part of a long set of bugfixes, and the
comment in my patch was supposed to tell me not to send it. Please just
ignore my submission, and let's go on with his version.

       Arnd
Dong Aisheng March 5, 2019, 8:36 a.m. | #3
> From: Arnd Bergmann [mailto:arnd@arndb.de]

> Sent: Tuesday, March 5, 2019 4:30 PM

> On Tue, Mar 5, 2019 at 4:00 AM Aisheng Dong <aisheng.dong@nxp.com>

> wrote:

> >

> > Hi Arnd,

> >

> > > From: Arnd Bergmann [mailto:arnd@arndb.de]

> > > Sent: Tuesday, March 5, 2019 4:26 AM

> > >

> > > Submitted by Anders Roxell already

> > >

> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> >

> > How would suggest to handle this patch?

> >

> > I've already given an Ack to Andres' v3 patch with a few additional

> > comments, but seems did not see any follow ups.

> >

> 

> Sorry about that, I sent this out as part of a long set of bugfixes, and the

> comment in my patch was supposed to tell me not to send it. Please just

> ignore my submission, and let's go on with his version.

> 


Never mind, it does remind me that missing fixes.
I will send out that patch for Andres.

Regards
Dong Aisheng

>        Arnd

Patch

diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
index e6dff3167a67..e447b996e79f 100644
--- a/drivers/pinctrl/freescale/Kconfig
+++ b/drivers/pinctrl/freescale/Kconfig
@@ -138,14 +138,14 @@  config PINCTRL_IMX8MQ
 
 config PINCTRL_IMX8QM
 	bool "IMX8QM pinctrl driver"
-	depends on ARCH_MXC && ARM64
+	depends on ARCH_MXC && ARM64 && IMX_SCU
 	select PINCTRL_IMX_SCU
 	help
 	  Say Y here to enable the imx8qm pinctrl driver
 
 config PINCTRL_IMX8QXP
 	bool "IMX8QXP pinctrl driver"
-	depends on ARCH_MXC && ARM64
+	depends on ARCH_MXC && ARM64 && IMX_SCU
 	select PINCTRL_IMX_SCU
 	help
 	  Say Y here to enable the imx8qxp pinctrl driver