[2/6] mmc: mmci: Drop unnecessary clear of variant->qcom_dml flag

Message ID 20190306140456.28187-3-ulf.hansson@linaro.org
State New
Headers show
Series
  • mmc: mmci: Cleanup some variant related code
Related show

Commit Message

Ulf Hansson March 6, 2019, 2:04 p.m.
There's no point clearing the variant flag in case the qcom variant fails
to setup DMA. This is because if mmci_dma_setup() fails, then the use_dma
flag remains set to false, which leads to mmci using PIO mode and not DMA.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

---
 drivers/mmc/host/mmci_qcom_dml.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.17.1

Patch

diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c
index 25d0a75533ea..b942d4aeeb77 100644
--- a/drivers/mmc/host/mmci_qcom_dml.c
+++ b/drivers/mmc/host/mmci_qcom_dml.c
@@ -133,7 +133,6 @@  static int qcom_dma_setup(struct mmci_host *host)
 	producer_id = of_get_dml_pipe_index(np, "rx");
 
 	if (producer_id < 0 || consumer_id < 0) {
-		host->variant->qcom_dml = false;
 		mmci_dmae_release(host);
 		return -EINVAL;
 	}