diff mbox series

bitbake: add readlink to HOSTTOOLS

Message ID 20190306161348.24575-1-ross.burton@intel.com
State Accepted
Commit ace3c0fff40604450ea8f0a669aaa37fbe730069
Headers show
Series bitbake: add readlink to HOSTTOOLS | expand

Commit Message

Ross Burton March 6, 2019, 4:13 p.m. UTC
If systemd has EFI enabled it uses readlink.

Signed-off-by: Ross Burton <ross.burton@intel.com>

---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.11.0

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Andre McCurdy March 7, 2019, 6:51 p.m. UTC | #1
On Wed, Mar 6, 2019 at 8:14 AM Ross Burton <ross.burton@intel.com> wrote:
>

> If systemd has EFI enabled it uses readlink.

>

> Signed-off-by: Ross Burton <ross.burton@intel.com>

> ---

>  meta/conf/bitbake.conf | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf

> index f1540a0acf7..3d1434931d1 100644

> --- a/meta/conf/bitbake.conf

> +++ b/meta/conf/bitbake.conf

> @@ -485,7 +485,7 @@ HOSTTOOLS += " \

>      fgrep file find flock g++ gawk gcc getconf getopt git grep gunzip gzip \

>      head hostname id install ld ldd ln ls make makeinfo md5sum mkdir mknod \

>      mktemp mv nm objcopy objdump od patch perl pod2man pr printf pwd python2 \

> -    python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed seq sh sha256sum \

> +    python2.7 python3 ranlib readelf readlink realpath rm rmdir rpcgen sed seq sh sha256sum \


Comments mention "readlink" but patch adds "realpath" ?

>      sleep sort split stat strings strip tail tar tee test touch tr true uname \

>      uniq wc wget which xargs \

>  "

> --

> 2.11.0

>

> --

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Ross Burton March 7, 2019, 8:43 p.m. UTC | #2
Whoops!  v2 incoming.

Ross

On Thu, 7 Mar 2019 at 18:51, Andre McCurdy <armccurdy@gmail.com> wrote:
>

> On Wed, Mar 6, 2019 at 8:14 AM Ross Burton <ross.burton@intel.com> wrote:

> >

> > If systemd has EFI enabled it uses readlink.

> >

> > Signed-off-by: Ross Burton <ross.burton@intel.com>

> > ---

> >  meta/conf/bitbake.conf | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> >

> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf

> > index f1540a0acf7..3d1434931d1 100644

> > --- a/meta/conf/bitbake.conf

> > +++ b/meta/conf/bitbake.conf

> > @@ -485,7 +485,7 @@ HOSTTOOLS += " \

> >      fgrep file find flock g++ gawk gcc getconf getopt git grep gunzip gzip \

> >      head hostname id install ld ldd ln ls make makeinfo md5sum mkdir mknod \

> >      mktemp mv nm objcopy objdump od patch perl pod2man pr printf pwd python2 \

> > -    python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed seq sh sha256sum \

> > +    python2.7 python3 ranlib readelf readlink realpath rm rmdir rpcgen sed seq sh sha256sum \

>

> Comments mention "readlink" but patch adds "realpath" ?

>

> >      sleep sort split stat strings strip tail tar tee test touch tr true uname \

> >      uniq wc wget which xargs \

> >  "

> > --

> > 2.11.0

> >

> > --

> > _______________________________________________

> > Openembedded-core mailing list

> > Openembedded-core@lists.openembedded.org

> > http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff mbox series

Patch

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index f1540a0acf7..3d1434931d1 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -485,7 +485,7 @@  HOSTTOOLS += " \
     fgrep file find flock g++ gawk gcc getconf getopt git grep gunzip gzip \
     head hostname id install ld ldd ln ls make makeinfo md5sum mkdir mknod \
     mktemp mv nm objcopy objdump od patch perl pod2man pr printf pwd python2 \
-    python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed seq sh sha256sum \
+    python2.7 python3 ranlib readelf readlink realpath rm rmdir rpcgen sed seq sh sha256sum \
     sleep sort split stat strings strip tail tar tee test touch tr true uname \
     uniq wc wget which xargs \
 "