igc: remove unused igc_priv_flags_strings array

Message ID 20190307093014.3293229-1-arnd@arndb.de
State New
Headers show
Series
  • igc: remove unused igc_priv_flags_strings array
Related show

Commit Message

Arnd Bergmann March 7, 2019, 9:29 a.m.
clang points out that the igc_priv_flags_strings[] array is never
referenced, aside from being used for calculating its length:

drivers/net/ethernet/intel/igc/igc_ethtool.c:9:19: error: variable 'igc_priv_flags_strings' is not needed and will not
      be emitted [-Werror,-Wunneeded-internal-declaration]
static const char igc_priv_flags_strings[][ETH_GSTRING_LEN] = {

A similar array is present in several other intel ethernet drivers,
but all the others use it in their .get_strings() callback, which
igc does not implement (yet).

Probably it should be implemented, but as I have no way of testing
it, this does the simpler alternative of removing the array to
get rid of the warning.

Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/net/ethernet/intel/igc/igc_ethtool.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

-- 
2.20.0

Comments

David Miller March 7, 2019, 5:29 p.m. | #1
From: Arnd Bergmann <arnd@arndb.de>

Date: Thu,  7 Mar 2019 10:29:57 +0100

> clang points out that the igc_priv_flags_strings[] array is never

> referenced, aside from being used for calculating its length:

> 

> drivers/net/ethernet/intel/igc/igc_ethtool.c:9:19: error: variable 'igc_priv_flags_strings' is not needed and will not

>       be emitted [-Werror,-Wunneeded-internal-declaration]

> static const char igc_priv_flags_strings[][ETH_GSTRING_LEN] = {

> 

> A similar array is present in several other intel ethernet drivers,

> but all the others use it in their .get_strings() callback, which

> igc does not implement (yet).

> 

> Probably it should be implemented, but as I have no way of testing

> it, this does the simpler alternative of removing the array to

> get rid of the warning.

> 

> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Jeff, I assume you will pick this up.
Neftin, Sasha March 7, 2019, 5:37 p.m. | #2
On 3/7/2019 09:29, David Miller wrote:
> From: Arnd Bergmann <arnd@arndb.de>

> Date: Thu,  7 Mar 2019 10:29:57 +0100

> 

>> clang points out that the igc_priv_flags_strings[] array is never

>> referenced, aside from being used for calculating its length:

>>

>> drivers/net/ethernet/intel/igc/igc_ethtool.c:9:19: error: variable 'igc_priv_flags_strings' is not needed and will not

>>        be emitted [-Werror,-Wunneeded-internal-declaration]

>> static const char igc_priv_flags_strings[][ETH_GSTRING_LEN] = {

>>

>> A similar array is present in several other intel ethernet drivers,

>> but all the others use it in their .get_strings() callback, which

>> igc does not implement (yet).

>>

>> Probably it should be implemented, but as I have no way of testing

>> it, this does the simpler alternative of removing the array to

>> get rid of the warning.

>>

>> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")

>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> 

> Jeff, I assume you will pick this up.

> 

I've submitted igc: Add support for statistics commit 
7aa2547613233a232b9b2e1942d67da4997e6ad0. This patch in Jeff's Kirsher 
next-queue and used igc_priv_flags_strings.
Thanks,
Sasha

Patch

diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index eff37a6c0afa..9e352c2be644 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -6,12 +6,9 @@ 
 
 #include "igc.h"
 
-static const char igc_priv_flags_strings[][ETH_GSTRING_LEN] = {
 #define IGC_PRIV_FLAGS_LEGACY_RX	BIT(0)
-	"legacy-rx",
-};
 
-#define IGC_PRIV_FLAGS_STR_LEN ARRAY_SIZE(igc_priv_flags_strings)
+#define IGC_PRIV_FLAGS_STR_LEN		1
 
 static void igc_get_drvinfo(struct net_device *netdev,
 			    struct ethtool_drvinfo *drvinfo)