From patchwork Tue Mar 12 08:44:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 160062 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp12851370jad; Tue, 12 Mar 2019 01:46:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqwrZlQzXUDPIv40frFPRsJyPCGmGMln+y5+vueFt3Ko5YzqYvaIZCRBIppoUpGzhl7aJCbr X-Received: by 2002:a17:902:2a27:: with SMTP id i36mr8339837plb.334.1552380379895; Tue, 12 Mar 2019 01:46:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552380379; cv=none; d=google.com; s=arc-20160816; b=RcU8pXE1g8rRsK2b3Ft97u295m4tidRVOWV5KvvZUK5OmHIp0vxTx0/jdwtTqUbQ+q RBf3ptVVqAiMevoNxSJltdf7TupAlra0wKDxVcJxdiCuu+fkKwa7mh4IrqOh56rS+E61 vaXssvS5V50aIz1iz7paKf2q+udI5/cfVZQI8M5Uz5GS8dhLCb6BDCnyiTD9xY5kYYMR s+jaa++LNNcHMUAOkwA2Dd2qJlTwmM4bM/b2ur1SehLKXWZtabvUioPSB1iD0y0N/9eX o6DEnVlc/piirrykXrdIybU9P37YzLVHEt+pJaGayLntj13WfSDok3zJ+iI5njUkNRcE XJlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:dkim-filter:dkim-signature; bh=nB6WyYc/vPjFBHB1KEH1e4Uli8n96s+WwDgJQyty90A=; b=n11a9IUBILgysdQ7QZ8mz86k4zPF97vPsUTUF8lttjUJel8uM/udmBlCe29XIAX7ft 2Yu4iMGHdgAR1Rw/jWli60SxtxyTFVKwNqzhRTGNI54k37+xTSrXovgjJqmTI8Ruyc6r VyIsXZwSNkg69g7UsuJ3twL4kPfbUjyAzXBJSeIT1c0YarSOFZlCYHa/PjFpTb/F9Up0 XLWZ+Bo954zAJz5ZjZapP4Tsp/N1rq8zE2+mxBWXOBOC4g19BHFbtESdpFMJ85B+7rsG yxHFLKucAQVJXZrOEq3QBtAm33TzaQgH9AgW89KT3a/9T+jmRIYlfLz+4/GURir840Kw GYaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=MVbk9xJS; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=OON98J3F; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id i37si7897814plb.188.2019.03.12.01.46.19 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2019 01:46:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=MVbk9xJS; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=OON98J3F; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=nB6WyYc/vPjFBHB1KEH1e4Uli8n96s+WwDgJQyty90A=; b=MVbk9xJSJHMb8T+CscIylXa6x6 1272UOVhwSXUeSe0n1qeGhkloMMHZc5fVhiUZ6WUKDtvFUe4l7AxvqLHxbDonsRjWdnXY0gntuX0n DjAyLwZuauqTm/MPBJvCGbbiJh6n9Vj88YmBuCnQrpLU0bILE49eviyuqcvW/BM/KGkw9nKYCa9BH CZpmxZSFxEQOoBFfjrNaPjy3Q99R1sDp1VPbK2bTM5UYc123KwTVfbcSwd2zu0bIZ8Tuc+98bJfeJ DOmae0Iw0/na8QnE0BCl3eajqqyTwdRLyDzTeJHKqnqV3md6dmmIIBemx0lVFbV5qY8vo1B7xTV3o U4ojGuAg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3d30-0000a2-DT; Tue, 12 Mar 2019 08:46:06 +0000 Received: from conuserg-09.nifty.com ([210.131.2.76]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3d2e-000079-Ia for linux-mtd@lists.infradead.org; Tue, 12 Mar 2019 08:45:47 +0000 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-09.nifty.com with ESMTP id x2C8j6Zi004092; Tue, 12 Mar 2019 17:45:22 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com x2C8j6Zi004092 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1552380322; bh=mQR7r33kBKitXzpLskswUugSgJVShOOSmdtp2U7FsBI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OON98J3FEZh2Hac6J3ryrNkBWKlixGE5hrR/QiFztrKdj6rCq9lLwnv26WQIwELj5 BGmAq+P00Gdp2Fp7YytELfpeyjqvVECZ/eriemWyCZUVOjaSCaW8//qPMRRiziOtan UPYNmYa5HvLe1tVAU8jASrOJk98zAonzc2E+SmEyW42APZ/87f/KHlwIgNHa182yIP G8zhl6udnZwEGut/FlYHS4qkYYuskWNtDuVDlH1ztTxGl6gT1/26TEVUYkwCjSDyyw mQWPmGstMSuWR1geG9w4TKfiDskowoZVbBjhROfmpv4/s4NhpnA3LNCb2gVk2QH49M 6YcN6UVsdT9bw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Miquel Raynal Subject: [PATCH v3 8/9] mtd: rawnand: denali: remove DENALI_NR_BANKS macro Date: Tue, 12 Mar 2019 17:44:49 +0900 Message-Id: <1552380290-19951-9-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1552380290-19951-1-git-send-email-yamada.masahiro@socionext.com> References: <1552380290-19951-1-git-send-email-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190312_014544_990093_B3B97BCA X-CRM114-Status: GOOD ( 10.88 ) X-Spam-Score: 1.0 (+) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [210.131.2.76 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Masahiro Yamada , Richard Weinberger , Boris Brezillon , linux-kernel@vger.kernel.org, Marek Vasut , Brian Norris , David Woodhouse MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org Use the runtime-detected denali->nbanks instead of hard-coded DENALI_NR_BANKS (=4). The actual number of banks depends on the IP configuration, and can be less than DENALI_NR_BANKS. It is pointless to touch registers of unsupported banks. Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: None drivers/mtd/nand/raw/denali.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) -- 2.7.4 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c index 0c47c56..b1a4d9c 100644 --- a/drivers/mtd/nand/raw/denali.c +++ b/drivers/mtd/nand/raw/denali.c @@ -40,7 +40,6 @@ #define DENALI_BANK(denali) ((denali)->active_bank << 24) #define DENALI_INVALID_BANK -1 -#define DENALI_NR_BANKS 4 static struct denali_chip *to_denali_chip(struct nand_chip *chip) { @@ -92,7 +91,7 @@ static void denali_enable_irq(struct denali_controller *denali) { int i; - for (i = 0; i < DENALI_NR_BANKS; i++) + for (i = 0; i < denali->nbanks; i++) iowrite32(U32_MAX, denali->reg + INTR_EN(i)); iowrite32(GLOBAL_INT_EN_FLAG, denali->reg + GLOBAL_INT_ENABLE); } @@ -101,7 +100,7 @@ static void denali_disable_irq(struct denali_controller *denali) { int i; - for (i = 0; i < DENALI_NR_BANKS; i++) + for (i = 0; i < denali->nbanks; i++) iowrite32(0, denali->reg + INTR_EN(i)); iowrite32(0, denali->reg + GLOBAL_INT_ENABLE); } @@ -117,7 +116,7 @@ static void denali_clear_irq_all(struct denali_controller *denali) { int i; - for (i = 0; i < DENALI_NR_BANKS; i++) + for (i = 0; i < denali->nbanks; i++) denali_clear_irq(denali, i, U32_MAX); } @@ -130,7 +129,7 @@ static irqreturn_t denali_isr(int irq, void *dev_id) spin_lock(&denali->irq_lock); - for (i = 0; i < DENALI_NR_BANKS; i++) { + for (i = 0; i < denali->nbanks; i++) { irq_status = ioread32(denali->reg + INTR_STATUS(i)); if (irq_status) ret = IRQ_HANDLED;