From patchwork Wed Mar 13 06:12:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Garg X-Patchwork-Id: 160197 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp13941786jad; Tue, 12 Mar 2019 23:13:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqzYLCqwtRquAXd8PRcml4uNA3G+2yoFlMhtjmA3F4BgfZwRUZLLvA0nYBByY/7L3OFzFI8u X-Received: by 2002:adf:f149:: with SMTP id y9mr25231227wro.282.1552457627990; Tue, 12 Mar 2019 23:13:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552457627; cv=none; d=google.com; s=arc-20160816; b=GsPs0IsoSzCuaByldmGFyMoqvjww7KXAsyuGUVI5p7Z3BlXMhYMYTB5a0bIpugJrDx wHwXA3HNYWEftpdCbysumFaDd2WQ8purAMFfa/1MmWHIdKAObbve9VV6Q/vhXY41g3Je btEYszugaXQhEcPo6e/70KhzbQNcTC6AnJhDrQHYjtYZ9Gdg38M8X0LXWRcX7I+94AXM GCLsW0pR1VJUW8w4cUXQQshsCiP26X6Ik7VAfX2Kc132PiHaq2X17BI0nQtT5E4BoK7O J3YZSoRyVI6ePMrWo68fp3r8f/4TjOwFTEiTxX47BiaOOLkNix7/FaM6Pu9tPeOf4vk+ I3CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=pNQXHzId4OMHRv+Xps24KSk0/4jsGo2OwK/vXrsfnSg=; b=g6p1l8PBGUjz9nM3+KqQzDpeS5podOSMnXwt3+Xc0MJw5fPVLvES6eE66xy3zOw1jF r7GMl4f1V3Ge5e05GKT2v4PH2uNySOrfir+wL9MZ4K3A8bbvKmfGmUmTLaKiUaUObGm4 sJr49DYJ9gRVKDLfN6w7LACZM6gFmbrdzylEB8wOzx447GD4G2UwhSMwWbQ688xLp4io aHLonraABsacKE4ciAjcOZrIx3/kN7BRuWsg/jqBDqVndL5obk+/fJ6+BwOALT46s518 oA/3RO9fztvlHB2T/3s1n0ZhEu68IJqLjTDguzzChccoAzG6YQ31AxMPq+S/V2Oa4LJx ZBHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=j0qYNG5p; spf=pass (google.com: domain of ltp-bounces+patch=linaro.org@lists.linux.it designates 213.254.12.146 as permitted sender) smtp.mailfrom="ltp-bounces+patch=linaro.org@lists.linux.it"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from picard.linux.it (picard.linux.it. [213.254.12.146]) by mx.google.com with ESMTPS id n11si6584969wrp.151.2019.03.12.23.13.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2019 23:13:47 -0700 (PDT) Received-SPF: pass (google.com: domain of ltp-bounces+patch=linaro.org@lists.linux.it designates 213.254.12.146 as permitted sender) client-ip=213.254.12.146; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=j0qYNG5p; spf=pass (google.com: domain of ltp-bounces+patch=linaro.org@lists.linux.it designates 213.254.12.146 as permitted sender) smtp.mailfrom="ltp-bounces+patch=linaro.org@lists.linux.it"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 828B23EA452 for ; Wed, 13 Mar 2019 07:13:47 +0100 (CET) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) by picard.linux.it (Postfix) with ESMTP id D12DC3EA37D for ; Wed, 13 Mar 2019 07:13:40 +0100 (CET) Received: from mail-yw1-xc42.google.com (mail-yw1-xc42.google.com [IPv6:2607:f8b0:4864:20::c42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 16FEA1400E05 for ; Wed, 13 Mar 2019 07:13:40 +0100 (CET) Received: by mail-yw1-xc42.google.com with SMTP id 189so524038ywi.3 for ; Tue, 12 Mar 2019 23:13:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kQWap+WkUDTEK03wgdD1UaUPh7EgDyiYegPY+sAW2Ss=; b=j0qYNG5p5ZNPr3S6xpWpDiaExGtRQPTmp8Cgq1HmKFPgFYM9s3eCA815pW0KtLEJgj fkO0FA1/UT4CoLSxDEFC5vgXkdC4fQ4ed0TvHisIi1ndtssdpIWTSqtlf/QAtKsZHjLW KxavGduAU3bNi8RsqjNmk/Qe1u4Zu+9fgst1cCu6JBlUunxhkSffgv0Capfc/6/4UZKW 8Yc97ApEmPY2cnzqcUiQSkDlSsR+LfZV1R0GGAOjjnIiCwA/oX7h1lgDiqy0V1+6Eas4 0voASkxIHl/qWz5TnSfMGGrtVxjuQ1uJJ08BAnHRD6r6bnIxv5oKPtPpn3PDHtS7etel qM3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kQWap+WkUDTEK03wgdD1UaUPh7EgDyiYegPY+sAW2Ss=; b=c13nDSkNOjm+mDo0eslRyaZwwcNBYMOqUAADafSdeA6O24kf6GDTXGoByWnRlNbMfu EIrqZLtSswvvHApRBc45uXPzdE9WILtuoiKy63wxqLozEUad1MUt21K4Xem7xzcClJPN am3gJw11zVOqODGoXLBDQ/d3YE2bRX5mKAbZFQmMNQYUcrUS0DmW3X24Ro6RVeePKCGl XG5ej6Pg5V2nQlEmmHLGWWy2sm1dv/pOMY4eXxTtx6J1fNWCV8MIyoRno9/drrlZ+D7Q alajuxj0P+k8WmsVXAAY/USj3ChY9xbHSe4KFE9FEZ9g/dxHHdxK0eHcbl5TIEw9sexa xP3Q== X-Gm-Message-State: APjAAAWa91PtrxgAG/ngY1AXh9TVElVJs5jmx468viN5n+FW0HOAs9XB g2o/s4ansQnUPSyWqyGeywlDmiVAvl0= X-Received: by 2002:a25:d656:: with SMTP id n83mr33464949ybg.423.1552457618832; Tue, 12 Mar 2019 23:13:38 -0700 (PDT) Received: from localhost.localdomain ([117.196.233.204]) by smtp.gmail.com with ESMTPSA id b132sm4319949ywh.79.2019.03.12.23.13.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Mar 2019 23:13:38 -0700 (PDT) From: Sumit Garg To: ltp@lists.linux.it Date: Wed, 13 Mar 2019 11:42:53 +0530 Message-Id: <1552457573-1354-4-git-send-email-sumit.garg@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1552457573-1354-1-git-send-email-sumit.garg@linaro.org> References: <1552457573-1354-1-git-send-email-sumit.garg@linaro.org> X-Virus-Scanned: clamav-milter 0.99.2 at in-6.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-6.smtp.seeweb.it Cc: daniel.thompson@linaro.org, Greg Hackmann Subject: [LTP] [PATCH v2 3/3] syscalls/tgkill03: add new test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ltp-bounces+patch=linaro.org@lists.linux.it Sender: "ltp" From: Greg Hackmann Test simple tgkill() error cases. Signed-off-by: Greg Hackmann Signed-off-by: Sumit Garg Reviewed-by: Li Wang --- runtest/syscalls | 1 + testcases/kernel/syscalls/tgkill/.gitignore | 1 + testcases/kernel/syscalls/tgkill/tgkill03.c | 122 ++++++++++++++++++++++++++++ 3 files changed, 124 insertions(+) create mode 100644 testcases/kernel/syscalls/tgkill/tgkill03.c diff --git a/runtest/syscalls b/runtest/syscalls index 1f4a2da..b92244d 100644 --- a/runtest/syscalls +++ b/runtest/syscalls @@ -1401,6 +1401,7 @@ syslog12 syslog12 tgkill01 tgkill01 tgkill02 tgkill02 +tgkill03 tgkill03 time01 time01 time02 time02 diff --git a/testcases/kernel/syscalls/tgkill/.gitignore b/testcases/kernel/syscalls/tgkill/.gitignore index 42be2bb..a6d2299 100644 --- a/testcases/kernel/syscalls/tgkill/.gitignore +++ b/testcases/kernel/syscalls/tgkill/.gitignore @@ -1,2 +1,3 @@ tgkill01 tgkill02 +tgkill03 diff --git a/testcases/kernel/syscalls/tgkill/tgkill03.c b/testcases/kernel/syscalls/tgkill/tgkill03.c new file mode 100644 index 0000000..3597d1b --- /dev/null +++ b/testcases/kernel/syscalls/tgkill/tgkill03.c @@ -0,0 +1,122 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (c) 2018 Google, Inc. + * + * Test simple tgkill() error cases. + */ + +#include +#include +#include + +#include "tst_safe_pthread.h" +#include "tst_test.h" +#include "tgkill.h" + +static pthread_t child_thread; + +static pid_t parent_tgid; +static pid_t parent_tid; +static pid_t child_tid; +static pid_t defunct_tid; + +static const int invalid_pid = -1; + +static int test_running; +static pthread_cond_t test_running_cond = PTHREAD_COND_INITIALIZER; +static pthread_mutex_t test_running_mutex = PTHREAD_MUTEX_INITIALIZER; + +static void *child_thread_func(void *arg) +{ + child_tid = sys_gettid(); + + TST_CHECKPOINT_WAKE(0); + + pthread_mutex_lock(&test_running_mutex); + while (test_running) + pthread_cond_wait(&test_running_cond, &test_running_mutex); + pthread_mutex_unlock(&test_running_mutex); + + return arg; +} + +static void *defunct_thread_func(void *arg) +{ + defunct_tid = sys_gettid(); + + return arg; +} + +static void setup(void) +{ + sigset_t sigusr1; + pthread_t defunct_thread; + + sigemptyset(&sigusr1); + sigaddset(&sigusr1, SIGUSR1); + pthread_sigmask(SIG_BLOCK, &sigusr1, NULL); + + parent_tgid = getpid(); + parent_tid = sys_gettid(); + + test_running = 1; + + SAFE_PTHREAD_CREATE(&child_thread, NULL, child_thread_func, NULL); + + TST_CHECKPOINT_WAIT(0); + + SAFE_PTHREAD_CREATE(&defunct_thread, NULL, defunct_thread_func, NULL); + + SAFE_PTHREAD_JOIN(defunct_thread, NULL); +} + +static void cleanup(void) +{ + test_running = 0; + pthread_cond_broadcast(&test_running_cond); + + SAFE_PTHREAD_JOIN(child_thread, NULL); +} + +static const struct testcase { + const char *desc; + const int *tgid; + const int *tid; + const int sig; + const int err; +} testcases[] = { + { "Invalid tgid", &invalid_pid, &parent_tid, SIGUSR1, EINVAL }, + { "Invalid tid", &parent_tgid, &invalid_pid, SIGUSR1, EINVAL }, + { "Invalid signal", &parent_tgid, &parent_tid, -1, EINVAL }, + { "Defunct thread ID", &parent_tgid, &defunct_tid, SIGUSR1, ESRCH }, + { "Valid tgkill call", &parent_tgid, &child_tid, SIGUSR1, 0 }, +}; + +static void run(unsigned int i) +{ + const struct testcase *tc = &testcases[i]; + + TEST(sys_tgkill(*tc->tgid, *tc->tid, tc->sig)); + if (tc->err) { + if (TST_RET < 0 && TST_ERR == tc->err) + tst_res(TPASS | TTERRNO, "%s failed as expected", + tc->desc); + else + tst_res(TFAIL | TTERRNO, + "%s should have failed with %s", tc->desc, + tst_strerrno(tc->err)); + } else { + if (TST_RET == 0) + tst_res(TPASS, "%s succeeded", tc->desc); + else + tst_res(TFAIL | TTERRNO, "%s failed", tc->desc); + } +} + +static struct tst_test test = { + .tcnt = ARRAY_SIZE(testcases), + .needs_checkpoints = 1, + .setup = setup, + .cleanup = cleanup, + .test = run, +};