[v3,1/6] iio: gyro: add DT bindings to fxas21002c

Message ID 20190313184002.2501-2-rui.silva@linaro.org
State New
Headers show
Series
  • iio: gyro: add fxas21002c driver
Related show

Commit Message

Rui Miguel Silva March 13, 2019, 6:39 p.m.
Add device tree bindings for the FXAS21002C gyroscope.

Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>

---
 .../bindings/iio/gyroscope/nxp,fxas21002c.txt | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt

-- 
2.20.1

Comments

Tomasz Duszynski March 14, 2019, 7:09 p.m. | #1
On Wed, Mar 13, 2019 at 06:39:57PM +0000, Rui Miguel Silva wrote:
> Add device tree bindings for the FXAS21002C gyroscope.

>

> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>

> ---

>  .../bindings/iio/gyroscope/nxp,fxas21002c.txt | 26 +++++++++++++++++++

>  1 file changed, 26 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt

>

> diff --git a/Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt b/Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt

> new file mode 100644

> index 000000000000..68b4cd283d1d

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt

> @@ -0,0 +1,26 @@

> +* NXP FXAS21002C Gyroscope device tree bindings

> +

> +http://www.nxp.com/products/sensors/gyroscopes/3-axis-digital-gyroscope:FXAS21002C

> +

> +Required properties:

> +  - compatible : should be "nxp,fxas21002c"

> +  - reg : the I2C address of the sensor or SPI chip select number for the

> +          device.

> +  - vdd-supply: phandle to the regulator that provides power to the sensor.

> +  - vddio-supply: phandle to the regulator that provides power to the bus.

> +

> +Optional properties:

> +  - reset-gpios : gpio used to reset the device, see gpio/gpio.txt

> +  - interrupts : device support 2 interrupts, INT1 and INT2.

> +                 See interrupt-controller/interrupts.txt


Mentioning supported irq flags seems to be fairy common across driver
bindings. At least one does not need to scan driver sources to find what is
supported.

One more thing. Your are using drive-open-drain property. Perhaps it's
worth mentioning it in this binding.

> +  - interrupt-names: should contain "INT1" or "INT2", the gyroscope interrupt

> +                     line in use.

> +

> +Example:

> +

> +gyroscope@20 {

> +	compatible = "nxp,fxas21002c";

> +	reg = <0x20>;

> +	vdd-supply = <&reg_peri_3p15v>;

> +	vddio-supply = <&reg_peri_3p15v>;

> +};

> --

> 2.20.1

>
Rui Miguel Silva March 18, 2019, 8:28 a.m. | #2
Hi Tomasz,
On Thu 14 Mar 2019 at 19:09, Tomasz Duszynski wrote:
> On Wed, Mar 13, 2019 at 06:39:57PM +0000, Rui Miguel Silva 

> wrote:

>> Add device tree bindings for the FXAS21002C gyroscope.

>>

>> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>

>> ---

>>  .../bindings/iio/gyroscope/nxp,fxas21002c.txt | 26 

>>  +++++++++++++++++++

>>  1 file changed, 26 insertions(+)

>>  create mode 100644 

>>  Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt

>>

>> diff --git 

>> a/Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt 

>> b/Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt

>> new file mode 100644

>> index 000000000000..68b4cd283d1d

>> --- /dev/null

>> +++ 

>> b/Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt

>> @@ -0,0 +1,26 @@

>> +* NXP FXAS21002C Gyroscope device tree bindings

>> +

>> +http://www.nxp.com/products/sensors/gyroscopes/3-axis-digital-gyroscope:FXAS21002C

>> +

>> +Required properties:

>> +  - compatible : should be "nxp,fxas21002c"

>> +  - reg : the I2C address of the sensor or SPI chip select 

>> number for the

>> +          device.

>> +  - vdd-supply: phandle to the regulator that provides power 

>> to the sensor.

>> +  - vddio-supply: phandle to the regulator that provides power 

>> to the bus.

>> +

>> +Optional properties:

>> +  - reset-gpios : gpio used to reset the device, see 

>> gpio/gpio.txt

>> +  - interrupts : device support 2 interrupts, INT1 and INT2.

>> +                 See interrupt-controller/interrupts.txt

>

> Mentioning supported irq flags seems to be fairy common across 

> driver

> bindings. At least one does not need to scan driver sources to 

> find what is

> supported.

>

> One more thing. Your are using drive-open-drain property. 

> Perhaps it's

> worth mentioning it in this binding.


Yeah, Thanks for the reviews, I will take them in account in v4.

---
Cheers,
	Rui

>

>> +  - interrupt-names: should contain "INT1" or "INT2", the 

>> gyroscope interrupt

>> +                     line in use.

>> +

>> +Example:

>> +

>> +gyroscope@20 {

>> +	compatible = "nxp,fxas21002c";

>> +	reg = <0x20>;

>> +	vdd-supply = <&reg_peri_3p15v>;

>> +	vddio-supply = <&reg_peri_3p15v>;

>> +};

>> --

>> 2.20.1

>>

Patch

diff --git a/Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt b/Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt
new file mode 100644
index 000000000000..68b4cd283d1d
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt
@@ -0,0 +1,26 @@ 
+* NXP FXAS21002C Gyroscope device tree bindings
+
+http://www.nxp.com/products/sensors/gyroscopes/3-axis-digital-gyroscope:FXAS21002C
+
+Required properties:
+  - compatible : should be "nxp,fxas21002c"
+  - reg : the I2C address of the sensor or SPI chip select number for the
+          device.
+  - vdd-supply: phandle to the regulator that provides power to the sensor.
+  - vddio-supply: phandle to the regulator that provides power to the bus.
+
+Optional properties:
+  - reset-gpios : gpio used to reset the device, see gpio/gpio.txt
+  - interrupts : device support 2 interrupts, INT1 and INT2.
+                 See interrupt-controller/interrupts.txt
+  - interrupt-names: should contain "INT1" or "INT2", the gyroscope interrupt
+                     line in use.
+
+Example:
+
+gyroscope@20 {
+	compatible = "nxp,fxas21002c";
+	reg = <0x20>;
+	vdd-supply = <&reg_peri_3p15v>;
+	vddio-supply = <&reg_peri_3p15v>;
+};